From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA5BDA09E4; Fri, 29 Jan 2021 15:47:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3097C4067B; Fri, 29 Jan 2021 15:47:23 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 4648940395 for ; Fri, 29 Jan 2021 15:47:21 +0100 (CET) IronPort-SDR: pup/+kgDpJ1YoYihGGMF9tpjocSStgTu3BeRlb2zKJrxSBFqHr/GBFqKZ3lssIlYWgSAj9m/ag wiBpyG2AJ4xw== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="241953589" X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="241953589" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 06:47:19 -0800 IronPort-SDR: yVMlMvcBrbdihtNtY1P7ZcA/GfZ/fccba+/Y3LPegjD5pU7WpApBlUpZ9Y3KQJ8MYCzy+I3iws 5950XXq9pN1A== X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="365268383" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.210.186]) ([10.213.210.186]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 06:47:18 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, liang.j.ma@intel.com, bruce.richardson@intel.com, david.hunt@intel.com References: <9108096.lcpG89tWLO@thomas> From: "Burakov, Anatoly" Message-ID: <3902b060-146b-5f23-a1c2-9e549f0b1ae8@intel.com> Date: Fri, 29 Jan 2021 14:47:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <9108096.lcpG89tWLO@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v20 0/4] Add PMD power management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 29-Jan-21 2:20 PM, Thomas Monjalon wrote: > 22/01/2021 18:12, Anatoly Burakov: >> Things of note: >> >> - Only 1:1 core to queue mapping is supported, meaning that each lcore >> must at most handle RX on a single queue > > Is there a way to have a more generic solution? > I think it may deserve some comments in the API. If you're referring to possibility of monitoring multiple queues from one core, we are investigating ways to make that happen, but for now, this is the limitation. > >> - Support 3 type policies. Monitor/Pause/Frequency Scaling >> - Power management is enabled per-queue >> - The API doesn't extend to other device types > > Could it be extended to more device types? > Otherwise it should be called specifically ethdev power management. It can theoretically be extended to any device type that has callbacks. Current focus is obviously NICs, but in general, it doesn't have to be. Anything that polls and has callbacks should work. > >> Anatoly Burakov (2): >> eal: rename power monitor condition member >> eal: improve comments around power monitoring API >> >> Liang Ma (2): >> power: add PMD power management API and callback >> examples/l3fwd-power: enable PMD power mgmt > > Applied with few formatting improvements, thanks > > Thanks! -- Thanks, Anatoly