From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 240C32C01 for ; Wed, 20 Jul 2016 11:55:11 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id q128so49158808wma.1 for ; Wed, 20 Jul 2016 02:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=0Uoel6Z9oWSWyX79uzwPkxk9bIL7xrHVzV+VsPO13YM=; b=HXirjZPO5R3Cz31O/JYiJ848ySIuqI92fpOnkyja7YJi/bRvPmE8rY9ePtUAPJYBFS /DpVVVIbavxYnDYd/+RoSUH5t0ts4e/i/3Fc5qeiIsfEuEtIySZkZNfJNW4DgrzgMEYS h+jOSovIrGAGlLTQjKzpJVrFC1AAJIDBdVFQwNMBV+a4M1IbxKcck3wdkoR72gR39R+h TeWiIxD6p3/N4I8JmudHUSLWD1ywavikBnjvm/mhlJt5Pm8vFwdUWnLQ9A0vjvhgR/vX 7+CcwlDDW8QxBM67rKysIu7rqpDVslHHAXnIcBT+ZtfPaZUE/iS/3mMiRac9Zp7mQS7U xE7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=0Uoel6Z9oWSWyX79uzwPkxk9bIL7xrHVzV+VsPO13YM=; b=gD9HJUY4auSuR06Nlt7JcguF7NogBk51qwrypxCcEWTDMdAatoCZ3fX/8wlg1JewZL U8gbMVSC34VDEHWn1Hqt58o+3A+uWHoB4kupyL3uyQARwewzUrDvySdqVs2eVGrP1zNO bVQq8BGgN2qXRSZa9+RawddE82ZhScABtqnE0Fp1cPp/jNG30kvC9xFL3ei1FEepRW+U d4N4LjqJSiZvJKfFE78/0jfiJYkRLQR9ZBeK5RXJRDIb3eXoVvw8fNxlDwnQ6mHLc69K zGnlGSM1rgbMQFhC66cwYFgq8hKip/tm63OX4Y4gYbG4h7wXuTy5Ye2wGJsdxmmR5WW1 0SOg== X-Gm-Message-State: ALyK8tKsXrgcncP4DMlSVzK3lxIforeGDOWFmGH2HhlCqgmbNJm9tX1/tmO+vf+OJLuG7zEw X-Received: by 10.194.69.198 with SMTP id g6mr463038wju.136.1469008510839; Wed, 20 Jul 2016 02:55:10 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id jj5sm381764wjb.40.2016.07.20.02.55.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jul 2016 02:55:10 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Adrien Mazarguil , Ferruh Yigit Date: Wed, 20 Jul 2016 11:55:09 +0200 Message-ID: <3903019.fxq95zhOST@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160715210302.GA52536@bricha3-MOBL3> References: <20160715210302.GA52536@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 00/10] Fix build errors related to exported headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2016 09:55:11 -0000 2016-07-15 22:03, Bruce Richardson: > On Wed, Jul 13, 2016 at 03:02:37PM +0200, Adrien Mazarguil wrote: > > DPDK uses GNU C language extensions in most of its code base. This is fine > > for internal source files whose compilation flags are controlled by DPDK, > > however user applications that use exported "public" headers may experience > > compilation failures when enabling strict error/standard checks (-std and > > -pedantic for instance). > > > > Exported headers are installed system-wide and must be as clean as possible > > so applications do not have to resort to workarounds. > > > > This patchset affects exported headers only, compilation problems are > > addressed as follows: > > > > - Adding the __extension__ keyword to nonstandard constructs (same method > > as existing libraries when there is no other choice). > > - Adding the __extension__ keyword to C11 constructs to remain compatible > > with pure C99. > > - Adding missing includes so exported files can be included out of order > > and on their own. > > - Fixing GNU printf-like variadic macros as there is no magic keyword for > > these. > > > > Having upgraded to Fedora 24, I'm seeing quite a few errors compiling with gcc > 6.1.1 in debug mode. Applying this patchset seems to really cut down on those > errors, so may need to be applied for 16.07 release. It is reducing the number of warnings but do not completely solve it, right? It is a very good patchset but it needs to be validated with a large number of compilers and options. That's why I think it is too late for 16.07.