From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 283AD8E01 for ; Wed, 21 Mar 2018 21:52:27 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8803C20BF5; Wed, 21 Mar 2018 16:52:26 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 21 Mar 2018 16:52:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=z1bOihh0yn2CV73T1ft2ffse+7 xef133g3qqVpGLYsc=; b=JEI/U4MmbV9sSu072Cd4rDUnNwYOK3f6qr0l8jvvuA iCNnB7U0T0Fa9Nr5+DlAKDZYl+czdiobyVACcxIPluxnDfpFj+x4j7Nc72BWpQFH v16YnEwKf99RsWlZKWnP2VVFHhVZQSF7WeZn7GWgdLl9aRI38fzhmFHBmTU9ego3 k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=z1bOih h0yn2CV73T1ft2ffse+7xef133g3qqVpGLYsc=; b=mHm6B4D7STlbmDfUgVeAEK XkIZQUuoBv8OJ9BcEwVJQt3jfrIgTNx4e0FWtMyMJsPRd37hGq/XMRSU3IAzsYhM FxuFiJ1gyHpTs9MLIkO8588uNxEWrxIphXHGfVxJHTI0Y1NzdTQ/QMpyG7+70Hb6 38ctuBOhH9Sk7uFU93z1IBK2ewbmeE9ZAxf0QULSVne/CfCuE1OFtKUB551M3V+8 p6ljpmD7CPRZk/5u2wHdTuUTSf5Qr6N/R5X6G8XMkPGFzf4MBqGpqK1CGqkUhmYH Co25jbfbh1VIJA9sT6McvLu5H6SAWSflvktyqpF/qgelkz8dMYGwmgP4tJyhRB4Q == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EECC524211; Wed, 21 Mar 2018 16:52:24 -0400 (EDT) From: Thomas Monjalon To: Xiao Wang , rosen.xu@intel.com Cc: dev@dpdk.org, maxime.coquelin@redhat.com, yliu@fridaylinux.org, zhihong.wang@intel.com, tiwei.bie@intel.com, junjie.j.chen@intel.com, dan.daly@intel.com, cunming.liang@intel.com, anatoly.burakov@intel.com, gaetan.rivet@6wind.com Date: Wed, 21 Mar 2018 21:52:10 +0100 Message-ID: <3903591.iEHhUDiruC@xps> In-Reply-To: <20180321132108.52464-4-xiao.w.wang@intel.com> References: <20180309230809.63361-3-xiao.w.wang@intel.com> <20180321132108.52464-1-xiao.w.wang@intel.com> <20180321132108.52464-4-xiao.w.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/ifcvf: add ifcvf driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 20:52:27 -0000 21/03/2018 14:21, Xiao Wang: > ifcvf driver uses vdev as a control domain to manage ifc VFs that belong > to it. It registers vDPA device ops to vhost lib to enable these VFs to be > used as vhost data path accelerator. Not everybody work at Intel. Please explain what means ifcvf and what is a control domain. > Live migration feature is supported by ifc VF and this driver enables > it based on vhost lib. > > Because vDPA driver needs to set up MSI-X vector to interrupt the guest, > only vfio-pci is supported currently. > > Signed-off-by: Xiao Wang > Signed-off-by: Rosen Xu > --- > v2: > - Rebase on Zhihong's vDPA v3 patch set. > --- > config/common_base | 6 + > config/common_linuxapp | 1 + > drivers/net/Makefile | 1 + > drivers/net/ifcvf/Makefile | 40 + > drivers/net/ifcvf/base/ifcvf.c | 329 ++++++++ > drivers/net/ifcvf/base/ifcvf.h | 156 ++++ > drivers/net/ifcvf/base/ifcvf_osdep.h | 52 ++ > drivers/net/ifcvf/ifcvf_ethdev.c | 1240 +++++++++++++++++++++++++++++++ > drivers/net/ifcvf/rte_ifcvf_version.map | 4 + > mk/rte.app.mk | 1 + This feature needs to be explained and documented. It will be helpful to understand the mechanism and to have a good review. Please do not merge it until there is a good documentation.