From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44E9C43B45; Mon, 19 Feb 2024 02:51:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAABA4029B; Mon, 19 Feb 2024 02:51:28 +0100 (CET) Received: from fhigh8-smtp.messagingengine.com (fhigh8-smtp.messagingengine.com [103.168.172.159]) by mails.dpdk.org (Postfix) with ESMTP id 3B0C240278 for ; Mon, 19 Feb 2024 02:51:27 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.nyi.internal (Postfix) with ESMTP id BB303114008F; Sun, 18 Feb 2024 20:51:26 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 18 Feb 2024 20:51:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1708307486; x=1708393886; bh=9SDkaWDuxWHkw6LyFaa0dNV6prGX2O558Yus9yvgLGk=; b= icjpRC3a1QBAZh4GeZ3kGb75MqLr2i5AvCyVCy3m8C8mYJPOyCQ6kp8abYIoGpcq wv5BcJqqAXDFVz9XtnWdWAuU58/CfvWT3mjWkiWe1OVMJQor9OQlPXIInXao23r4 sbJ1VWU2rakjkFSFpcG9UfZnRi4lbGd036JfJjCKdvUUKa28iabJpVI84EKq6I8Z yIBQcWrF1fBTrfPj+qzWdvCNGT1NmJzl0eE7xuIrZB83m/9/CZenmqAHThI7PPEi IQRnCVVFOBERV21cPNZoWcmEgJw5ciaWpnLGISgvqudPP4TS7UIazhMpAfO7QrGJ DHTmq2sgxM45FltGbsPyoQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708307486; x= 1708393886; bh=9SDkaWDuxWHkw6LyFaa0dNV6prGX2O558Yus9yvgLGk=; b=n 3Zfw44FXhisJ/tdxUX3XgZ2nqPd/F9magc/ityAdBs4yJ//wkfNufx1NFnsj92La e8foosKibwUq9aR4ozL8pnvZyu1AruWedm1V3DWAem1EAf8Udr41RHbrF+MY3wai tVE29Y+ze1PQciAVUJ6FId4Lsce5GqM5EvY9l2jYcwmGFBbNO7YJTu1BTxdP4LH9 o0yBKZnIa+mIKVm+NaZFUlCZnxG8NQkyddCgSbJO3Bw9yhqZYqWiLuQHexg6fxdj tjSq3exQZ2oQzzxjsmuD7oSsMmA8Gk1pL/DpxzTD3EGaGpKvN3kJHUk+mjqb8hPx bDK+yMCvWQaK6eRpIJCZA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdejgdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 18 Feb 2024 20:51:25 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, Bruce Richardson Subject: Re: [PATCH v2] build: set rte toolchain macros from predefined macros Date: Mon, 19 Feb 2024 02:51:24 +0100 Message-ID: <3905014.ECZNHGQPT7@thomas> In-Reply-To: References: <1704238041-25304-1-git-send-email-roretzla@linux.microsoft.com> <1704240675-3964-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 08/01/2024 12:18, Bruce Richardson: > On Tue, Jan 02, 2024 at 04:11:15PM -0800, Tyler Retzlaff wrote: > > Stop writing RTE_TOOLCHAIN_XXX macros to rte_build_config.h. When an > > application builds it doesn't necessarily use the same toolchain that > > DPDK was built with. > > > > Instead evaluate toolchain predefined macros and define > > RTE_TOOLCHAIN_XXX macros as appropriate each time rte_config.h is > > preprocessed. > > > > Signed-off-by: Tyler Retzlaff > > I don't see an issue with doing this. > > Acked-by: Bruce Richardson Applied, thanks.