From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C258A00C2; Sat, 25 Apr 2020 23:00:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DF6741C197; Sat, 25 Apr 2020 23:00:03 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 2B70E1C139; Sat, 25 Apr 2020 23:00:02 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 84F815C030E; Sat, 25 Apr 2020 17:00:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sat, 25 Apr 2020 17:00:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 1UKpdksXevA/80YfmyB9QiPuyEoMDoaI/zoY9xBusBg=; b=jCDVfJo3TOrURKHJ ab7MLhuYjTRSIZGjGAS1sL6b9d/OCnb4FsNlieH0GGFDxARh//6aWgiRvP6pbNXp XV89WzfEGbLqcUciAWQzDCiIKXjms1CdBSKhQpHd2chaWzlG6fY76CBxkvAMwb+F WtBBvuA9lfBhQ0w/0pGlycRDICiNX8UujBf0x0FFUBJFvzSLmW6ylMmo0H/hBuQS 3ST062FKiZ/vdACLuBmZ5NKSKqrAk1yi9t/mbxaZ6Awgi9cG9wVd5U7QQ9K7En8o w6l48pLhgzN8cxB4B04jiKNq9Yos8tpus+0Kn9Z8buI7eFFowx8xCmCkGixDqQAz m0ygwA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=1UKpdksXevA/80YfmyB9QiPuyEoMDoaI/zoY9xBus Bg=; b=onkHWn/eaUb49SA8fXm+PgrFl922AhsjyI4JdjKIxGUo3yFoibActN3RA TE9lGJPyF+6KEBzir2K4UedHwYdTWE0CJbs9iaOvRxakw2u7FzOYRQWd7aC6lC0C 8ajUUFvbug+RAKkPc8GVf5i7CaaPyimFfuZt3Wq1c6h3rSrNk26Ztfd4Fs+0Ee/X yu59Ew0PjYAxerRtabn6WSImu/CNl/KYU+j9fSNqq4AgSlFaEq2zTDklJUwSLJ6Q mWZjJkDQtDbfC50rX89j+oOEI2N3qBVSMOt9f8vxvwUQEI+imm+TbmqmsOCDpdom ma0oxitn8UxoLFqm+SP7W33HeHTfQ== X-ME-Sender: <xms:z6SkXme4fY9XjT-z906Q8kCJdDMublFKilg4PnNkIFMeuPjlTkcsPQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrheeggddufedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:z6SkXkcDTf6NrCR0GbPm__H9xY-aasKpxtMungfaKuMfQgGviUVrzw> <xmx:z6SkXigc29BR7WwKM4BH0Y5gkjjgTKXUwNZRuwzGTK77QWWqTw9Okw> <xmx:z6SkXoT2dXy382hBO2tN6VHD4m4dk9xVH_6TxW4mBW2ZKeCpX7x95g> <xmx:0KSkXuuvfAYIZbjTaPRCgrEK-xzxZmDOk5VqThQ0a476nSkop8XRQQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E0DD1328005E; Sat, 25 Apr 2020 16:59:58 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Muhammad Bilal <m.bilal@emumba.com> Cc: hemant.agrawal@nxp.com, olivier.matz@6wind.com, stephen@networkplumber.org, dev@dpdk.org, stable@dpdk.org Date: Sat, 25 Apr 2020 22:59:57 +0200 Message-ID: <3912068.8vf5iQgoFF@thomas> In-Reply-To: <20200407075613.29273-1-m.bilal@emumba.com> References: <20200406113020.8074-1-m.bilal@emumba.com> <20200407075613.29273-1-m.bilal@emumba.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] putting null checks on ops_name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 07/04/2020 09:56, Muhammad Bilal: > Bugzilla ID: 353 > Cc: dev@dpdk.org > Cc: stable@dpdk.org > Cc: hemant.agrawal@nxp.com > Signed-off-by: Muhammad Bilal <m.bilal@emumba.com> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> No need to Cc stable in my opinion, as there is no bug fixed. Changing the name to: mbuf: prevent setting mempool ops name empty Applied with below minor change, thanks The blank line below should remain: > const struct rte_memzone *mz; > - > - if (strlen(ops_name) >= RTE_MEMPOOL_OPS_NAMESIZE) > + size_t len = strnlen(ops_name, RTE_MEMPOOL_OPS_NAMESIZE); > + if (len == 0) > + return -EINVAL;