From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2] rte mempool: division or modulo by zero
Date: Tue, 24 May 2016 11:07:59 +0200 [thread overview]
Message-ID: <3912401.t7DCyFBsR0@xps13> (raw)
In-Reply-To: <5742E961.4060501@6wind.com>
Please take care of the title.
Here you know it is not a modulo but you keep copying the coverity message.
It is fixed to "mempool: avoid division by zero"
2016-05-23 13:28, Olivier Matz:
> On 05/19/2016 02:36 PM, Slawomir Mrozowicz wrote:
> > Fix issue reported by Coverity.
> >
> > Coverity ID 13243: Division or modulo by zero
> > In function call rte_mempool_xmem_size, division by expression total_size
> > which may be zero has undefined behavior.
Please prefer this format instead of the first 2 lines:
Coverity issue: 13243
> > Fixes: 148f963fb532 ("xen: core library changes")
> >
> > Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
prev parent reply other threads:[~2016-05-24 9:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 12:36 Slawomir Mrozowicz
2016-05-23 11:28 ` Olivier Matz
2016-05-24 9:07 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3912401.t7DCyFBsR0@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=slawomirx.mrozowicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).