From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id BB1B55A57
 for <dev@dpdk.org>; Tue, 24 May 2016 11:08:01 +0200 (CEST)
Received: by mail-wm0-f43.google.com with SMTP id n129so118439000wmn.1
 for <dev@dpdk.org>; Tue, 24 May 2016 02:08:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=BD3gcwEm6+AUYdMoKuBC6eTCQiX+Sj6DLaJlNPPd4A4=;
 b=YRAKuvuY1G0MEDF89LUU5qsMtmOmAegWC7pXpbmoDD+tTZFhXzwYxNWFlpDKQw05Y+
 FrStw6FUcMt/xj2k4MPB4VO5jnjkBqz2VmuBdaINPKUjswH6V7hiHz2B44ipp7FmpnT2
 jlp7nXJbiLasUWBNme2bD4zG/KbuobQwEclBL5HC/QhSz5AL8dzqsO0u3V76osRG3kzd
 xbhltsOk6yrSncn0VAnL3C88sVZSmmUCyKvBxIHlZzrmI+BLuS8Q/++oofOsA3MtZFOQ
 JlsKpUKroNeG83OpBJ2Etl9SvHe7hYyKENinhLtLZQEYHtSponOMPXGkuMm7Q5JbuRUz
 Dllw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=BD3gcwEm6+AUYdMoKuBC6eTCQiX+Sj6DLaJlNPPd4A4=;
 b=bdTfXKKL6hFer7FJSiQf3Hq9VGJDoCsWLP+jMhRrJNypnUKx07TUXNQ5I7L+WEK+JP
 p4p9m0qPrsGzTUzt3TAhdONFBrNIabHEWetzf4lcl6/pqnc7mvB/k16EJW3Q9KSbVeK/
 nf2KbcbdkSlqdxPxVuvJkg4C8AaDGicvmFBBzo7vYadkfLV8qIUEldDkajIt4+b+tbNi
 GLqV6nIEjzQsZi82lbuEohvkANb8YHfm+cHNTFB8ojasIm7dzsD2FDUZhgQ3tkOuO4BO
 kaeC44RHQ89H49NHt3YGrDEugbSHTfHUy/SwB+tHXp4DeZgCOq7EWzQabXBIP1BhQkXq
 2jZw==
X-Gm-Message-State: ALyK8tKO4akUJk7BRpCe3PtcRfp5DEQ5MtnyxCE50a2CkfXBetQZNG3KRj+tkVb8bHGJ272s
X-Received: by 10.28.149.69 with SMTP id x66mr7410204wmd.100.1464080881524;
 Tue, 24 May 2016 02:08:01 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id f135sm2510415wmf.22.2016.05.24.02.08.00
 (version=TLSv1/SSLv3 cipher=OTHER);
 Tue, 24 May 2016 02:08:00 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>
Date: Tue, 24 May 2016 11:07:59 +0200
Message-ID: <3912401.t7DCyFBsR0@xps13>
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <5742E961.4060501@6wind.com>
References: <1463661395-6979-1-git-send-email-slawomirx.mrozowicz@intel.com>
 <5742E961.4060501@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] rte mempool: division or modulo by zero
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 May 2016 09:08:01 -0000

Please take care of the title.
Here you know it is not a modulo but you keep copying the coverity message.
It is fixed to "mempool: avoid division by zero"

2016-05-23 13:28, Olivier Matz:
> On 05/19/2016 02:36 PM, Slawomir Mrozowicz wrote:
> > Fix issue reported by Coverity.
> > 
> > Coverity ID 13243: Division or modulo by zero
> > In function call rte_mempool_xmem_size, division by expression total_size
> > which may be zero has undefined behavior.

Please prefer this format instead of the first 2 lines:

Coverity issue: 13243
> > Fixes: 148f963fb532 ("xen: core library changes")
> > 
> > Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks