From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B97FA04B5; Tue, 27 Oct 2020 15:33:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 03C1D5947; Tue, 27 Oct 2020 15:33:42 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 1020D5937 for ; Tue, 27 Oct 2020 15:33:40 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 880765C00A9; Tue, 27 Oct 2020 10:33:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 27 Oct 2020 10:33:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 2EBZjIFlgkfr/AdtSr305Q8JjmhMkktxe3R2M5hlqFE=; b=qc6i4nMtVQvIzvtX e86/ykZpioXwA24WFWuKhi5WM70HOsJOVdudMZZaZdaoQ17YROStloJwjdRGQz9u NOHvVsUlhJNEQCMr9v/93NpT3tpkCmYUlPkhD2pQgevvmHiCW22yi5QRxFH9qBJL 6U20BDFV/JHbEYYBywZa6WWp0SMoTzzg03aXps+qV9d5Q5pMaiZgqH4dq0dHuVSn Hc1uZ2BzU1mITYCaIt6J4wzaprx565NWUh0MKjuA9yf7Qvtqny6ko4G9z4KMvVJX RtI8cybEcQsB3MThup4qs3XEpCcxR0/aOSw8qura+wYivo2b46so51xxtC+1Tr3i E1Zj5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=2EBZjIFlgkfr/AdtSr305Q8JjmhMkktxe3R2M5hlq FE=; b=fMQFNAu/IN0SL3xU5dT2X/f/kqHvPcqpu7IjIXgNZTM39uwhTqOMbrn8/ uI1989ZykjS+R9oIunamSueGCYemh5H0pY2LZ7kv691E/NDP3qapasY/F9n5Pv+6 vp0U00d9uaBhTto5sGjOLtSBUs4Xn4pISPEpDNmRNDPt5gC1DVpPHWqCZnZasw0W Wicf3cMZzVHNOYGiTdBi1DHE7cg2+ZWqlKOvEg5VbUP/veHSQ54aFnerV8F5B9Cc DLzQA6ThxHMibzeR0nIERjrA16E1nIbJRvLUUUHPOy+U1JT68ifgSoPAaZhNcdb/ zSI5/vP61jhqo7cm9BD1lpCAJZVIg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrkeelgdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 70E733064685; Tue, 27 Oct 2020 10:33:36 -0400 (EDT) From: Thomas Monjalon To: Nithin Dabilpuram Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, akhil.goyal@nxp.com, Pavan Nikhilesh Date: Tue, 27 Oct 2020 15:33:35 +0100 Message-ID: <3912863.aCUjeiqxCm@thomas> In-Reply-To: References: <20201026052105.1561859-1-thomas@monjalon.net> <20201026222013.2147904-5-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 04/15] node: switch IPv4 metadata to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/10/2020 15:23, Nithin Dabilpuram: > On Mon, Oct 26, 2020 at 11:20:02PM +0100, Thomas Monjalon wrote: > > The node_mbuf_priv1 was stored in the deprecated mbuf field udata64. > > It is moved to a dynamic field in order to allow removal of udata64. > > > > Signed-off-by: Thomas Monjalon > > --- > > --- a/lib/librte_node/ip4_lookup.c > > +++ b/lib/librte_node/ip4_lookup.c > > +int node_mbuf_priv1_dynfield_offset; > > + > > This change doesn't work in secondary as it is process local memory. Yes that's an issue. Can we copy the value when starting a secondary process? [...] > > static __rte_always_inline struct node_mbuf_priv1 * > > node_mbuf_priv1(struct rte_mbuf *m) > > { > > - return (struct node_mbuf_priv1 *)&m->udata64; > > + return RTE_MBUF_DYNFIELD(m, > > + node_mbuf_priv1_dynfield_offset, struct node_mbuf_priv1 *); > > There is a performance regression of ~1.4% in our platform (Octeontx2) because > of this change. Yes that's the price to pay for a more extensible DPDK. It is much cheaper than not having room for new features, or having features conflicting on the same mbuf field like here.