From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D8E7440D7; Sun, 26 May 2024 17:07:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49815402B2; Sun, 26 May 2024 17:07:50 +0200 (CEST) Received: from fout4-smtp.messagingengine.com (fout4-smtp.messagingengine.com [103.168.172.147]) by mails.dpdk.org (Postfix) with ESMTP id 45AD840279 for ; Sun, 26 May 2024 17:07:48 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id ACDE413805C7; Sun, 26 May 2024 11:07:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 26 May 2024 11:07:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1716736067; x=1716822467; bh=OaXORHPV2KcQrshjIetuLws410Dx5jf/zuFR6oce8UM=; b= YyLeGGleD9Evdmq7fbkVMAouqRMLd15asEAMsA59BeUhHVFnndjjwWBEqa3gbPrv yQWEoZsbWEE59fdrFHA+KPVL5itpqZjuqpcGi9v+luJIsSpB4q2G2DV43UP4XTzc XaY80/D7SXZ3LMEQkk55nlGVGJWBXCQWiSEeC/d7wLh0tH7TOmipyerk6+TlVuAG yzmsOgTyeRhhvvzVf4uBph7VaASW54A88XcvObeUEl8ML73MOy7PBS7JKgJvE6RI 4+hYms7cVUknvJxw+9pdI382aKrkF7WePaPzcDGvbBeQ+76C2PfT1ohVDK8t/VUr SsT25ywTliHKTmfoZa+riw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1716736067; x= 1716822467; bh=OaXORHPV2KcQrshjIetuLws410Dx5jf/zuFR6oce8UM=; b=q VXqtkHN82wVMoRzvaIl1AAIJxA8sMuW/M5dbVTWbuI3z5wljehWfnfEULSwXZC6+ 9ZcpSA5eg4i6WfdUbaPPawJli6Mq0kPgUUKr3AfPu8x6mLwAo3IJ8LBCgywR9BKT Vr8EfBGJEjmAzUXveR52uULJoSSl1Cg82NRNvNuq0BrYEkwSuXLKYqURPAintHKq jKNfvL+Nk/yWdt6Ar8/Gp+bHNyL8UhIfOjkHPUytd+PM2wJViM4V5tFkOh0AU7/a okkIRA6HnMyTpQv/bUuF1ZWGXC9JW/yFNMUBo10rLD2aC9Nk//l9CeHBBdeexAMT TWm7cxMmCgy2xAIKEn1RA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdejvddgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 26 May 2024 11:07:45 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: Stephen Hemminger , dev@dpdk.org, Bruce Richardson , Sameh Gobriel , Vladimir Medvedkin , Yipeng Wang , Morten =?ISO-8859-1?Q?Br=F8rup?= Subject: Re: [PATCH v2] hash: provide crc32 functions based on intrinsics Date: Sun, 26 May 2024 17:07:44 +0200 Message-ID: <3913071.fW5hKsROvD@thomas> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F489@smartserver.smartshare.dk> References: <1710970127-25938-2-git-send-email-roretzla@linux.microsoft.com> <20240521192111.3c2e9eda@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9F489@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 22/05/2024 10:36, Morten Br=C3=B8rup: > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Wednesday, 22 May 2024 04.21 > >=20 > > On Tue, 21 May 2024 17:02:14 -0700 > > Tyler Retzlaff wrote: > >=20 > > > MSVC does not support inline asm so replace crc32 inline function > > > implementations with intrinsics compatible with all toolchains. > > > > > > Signed-off-by: Tyler Retzlaff > >=20 > > always good to remove asm since in tends not to get optimized. > >=20 > > Acked-by: Stephen Hemminger >=20 > Acked-by: Morten Br=C3=B8rup Applied, thanks.