* [dpdk-dev] [PATCH] doc: clarify adding author to commit message
@ 2020-06-30 19:01 Honnappa Nagarahalli
2020-07-30 23:18 ` Thomas Monjalon
2020-08-01 23:11 ` [dpdk-dev] [PATCH v2] " Honnappa Nagarahalli
0 siblings, 2 replies; 3+ messages in thread
From: Honnappa Nagarahalli @ 2020-06-30 19:01 UTC (permalink / raw)
To: dev, honnappa.nagarahalli, thomas; +Cc: nd
Clarify to add the author in CC while contributing patches to stable.
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
doc/guides/contributing/patches.rst | 1 +
doc/guides/contributing/stable.rst | 1 +
2 files changed, 2 insertions(+)
diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
index 16b40225f..282c1fec3 100644
--- a/doc/guides/contributing/patches.rst
+++ b/doc/guides/contributing/patches.rst
@@ -329,6 +329,7 @@ In the commit message body the Cc: stable@dpdk.org should be inserted as follows
Update the docs, fixing description of some parameter.
Fixes: abcdefgh1234 ("doc: add some parameter")
+ Cc: author@example.com
Cc: stable@dpdk.org
Signed-off-by: Alex Smith <alex.smith@example.com>
diff --git a/doc/guides/contributing/stable.rst b/doc/guides/contributing/stable.rst
index 890bbeccc..747d4bc7c 100644
--- a/doc/guides/contributing/stable.rst
+++ b/doc/guides/contributing/stable.rst
@@ -85,6 +85,7 @@ commit message body as follows::
Update the docs, fixing description of some parameter.
Fixes: abcdefgh1234 ("doc: add some parameter")
+ Cc: author@example.com
Cc: stable@dpdk.org
Signed-off-by: Alex Smith <alex.smith@example.com>
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] doc: clarify adding author to commit message
2020-06-30 19:01 [dpdk-dev] [PATCH] doc: clarify adding author to commit message Honnappa Nagarahalli
@ 2020-07-30 23:18 ` Thomas Monjalon
2020-08-01 23:11 ` [dpdk-dev] [PATCH v2] " Honnappa Nagarahalli
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-07-30 23:18 UTC (permalink / raw)
To: Honnappa Nagarahalli; +Cc: dev, nd
30/06/2020 21:01, Honnappa Nagarahalli:
> Clarify to add the author in CC while contributing patches to stable.
Not only for stable.
We should explain in this commit log that this Cc is for automatic
handling by git-send-email.
It is manually removed when pushing in the git repository
to avoid naming people who were not involved
(acked-by or reviewed-by are added if they are involved).
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> doc/guides/contributing/patches.rst | 1 +
> doc/guides/contributing/stable.rst | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
> index 16b40225f..282c1fec3 100644
> --- a/doc/guides/contributing/patches.rst
> +++ b/doc/guides/contributing/patches.rst
> @@ -329,6 +329,7 @@ In the commit message body the Cc: stable@dpdk.org should be inserted as follows
> Update the docs, fixing description of some parameter.
>
> Fixes: abcdefgh1234 ("doc: add some parameter")
> + Cc: author@example.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Alex Smith <alex.smith@example.com>
> diff --git a/doc/guides/contributing/stable.rst b/doc/guides/contributing/stable.rst
> index 890bbeccc..747d4bc7c 100644
> --- a/doc/guides/contributing/stable.rst
> +++ b/doc/guides/contributing/stable.rst
> @@ -85,6 +85,7 @@ commit message body as follows::
> Update the docs, fixing description of some parameter.
>
> Fixes: abcdefgh1234 ("doc: add some parameter")
> + Cc: author@example.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Alex Smith <alex.smith@example.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* [dpdk-dev] [PATCH v2] doc: clarify adding author to commit message
2020-06-30 19:01 [dpdk-dev] [PATCH] doc: clarify adding author to commit message Honnappa Nagarahalli
2020-07-30 23:18 ` Thomas Monjalon
@ 2020-08-01 23:11 ` Honnappa Nagarahalli
1 sibling, 0 replies; 3+ messages in thread
From: Honnappa Nagarahalli @ 2020-08-01 23:11 UTC (permalink / raw)
To: dev, honnappa.nagarahalli, thomas; +Cc: nd
Clarify to add the author of the commit in CC while contributing
patches to stable. git-send-email will automatically send the
the patch to this email ID. It is manually removed when the patch
is merged.
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
v2: expand commit log to explain how Cc is used (Thomas)
doc/guides/contributing/patches.rst | 1 +
doc/guides/contributing/stable.rst | 1 +
2 files changed, 2 insertions(+)
diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
index 16b40225f..282c1fec3 100644
--- a/doc/guides/contributing/patches.rst
+++ b/doc/guides/contributing/patches.rst
@@ -329,6 +329,7 @@ In the commit message body the Cc: stable@dpdk.org should be inserted as follows
Update the docs, fixing description of some parameter.
Fixes: abcdefgh1234 ("doc: add some parameter")
+ Cc: author@example.com
Cc: stable@dpdk.org
Signed-off-by: Alex Smith <alex.smith@example.com>
diff --git a/doc/guides/contributing/stable.rst b/doc/guides/contributing/stable.rst
index 890bbeccc..747d4bc7c 100644
--- a/doc/guides/contributing/stable.rst
+++ b/doc/guides/contributing/stable.rst
@@ -85,6 +85,7 @@ commit message body as follows::
Update the docs, fixing description of some parameter.
Fixes: abcdefgh1234 ("doc: add some parameter")
+ Cc: author@example.com
Cc: stable@dpdk.org
Signed-off-by: Alex Smith <alex.smith@example.com>
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-01 23:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-30 19:01 [dpdk-dev] [PATCH] doc: clarify adding author to commit message Honnappa Nagarahalli
2020-07-30 23:18 ` Thomas Monjalon
2020-08-01 23:11 ` [dpdk-dev] [PATCH v2] " Honnappa Nagarahalli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).