From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61E07A0093; Wed, 9 Mar 2022 19:54:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0D1E40395; Wed, 9 Mar 2022 19:54:27 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 655E44013F; Wed, 9 Mar 2022 19:54:26 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 64FE05C0112; Wed, 9 Mar 2022 13:54:23 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 09 Mar 2022 13:54:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=Q0xES4y8NAAtLF y7CN7g15EycIFQ0A7+BN7SVNOW6PE=; b=XDGGxMzyuAYdXK85Emf6NEUPljyHIx S9goDgt/wRLB7xIUL5x37p/D1xrKDvcGL33N8JEC0TOdMfxoMFcaDSBrPZmveO7e 396J8GArqkze5+ugfKLEEK+E1bklf5teG9cdrxbOtM7RsJdGT9FoBzjgWZxP24nD fXOfa+gCFS8Ragj3lFGzObYp/Ayn0IxVUbHLJVlyPsa6c/e7rLEL8rbEpXPpMy8C NqK740NNSDb6HIButEe/3vp4j8qwGJtJn6Xp/XfmfKJ9zO6L6wEkDOXuZSikxXgv nXBgWBHZdoONYHYc7mOkXrxhrEc4YDF8qUu3R3A/6Y4TLomB3xrrA/cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Q0xES4y8NAAtLFy7CN7g15EycIFQ0A7+BN7SVNOW6 PE=; b=Lv81X+gL+DJHqeq/mugl0UgFViKYvoDx4wndjt10VISXSdmH+FBrty57M cQK90tvPHOUA13V8Ic3O8fN026BPI2zoH10Fa7YDO1KB08+moaioQiUskqxFa5VA xmMIBt2e108JYk176vmBSKi7RyOcAvhB+BP0S6Bu/dWN8mcDog4VREjKdPvoLhES WCCqBf5DIbQ3yHN9lx58ya+1ucatk1l0ob2OJe7vTFztILBFNirUjH1Tg6LC/EqJ GUteThIHP2m6j/9SylzRlXtJ0Y3M6ak/AzcMbDy7MgGMq96H+0HnrOX/M/ALi040 s2M/e68XTzoKutahQ/aEwRQoWXVlQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddukedgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Mar 2022 13:54:21 -0500 (EST) From: Thomas Monjalon To: Kevin Traynor Cc: dev@dpdk.org, david.marchand@redhat.com, stable@dpdk.org, Ray Kinsella , Parav Pandit , Xueming Li , Elena Agostini , Ori Kam , Andrew Rybchenko , Michael Baum Subject: Re: [PATCH v2 2/2] build: hide local symbols in shared libraries Date: Wed, 09 Mar 2022 19:54:19 +0100 Message-ID: <3916698.Zkmt1EvEu4@thomas> In-Reply-To: <0e4927c4-53ae-23a6-1fb5-fa5bd8a35d83@redhat.com> References: <20220306092023.2461466-1-thomas@monjalon.net> <20220308142412.2069408-3-thomas@monjalon.net> <0e4927c4-53ae-23a6-1fb5-fa5bd8a35d83@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 09/03/2022 11:58, Kevin Traynor: > Hi Thomas, > > On 08/03/2022 14:24, Thomas Monjalon wrote: > > The symbols which are not listed in the version script > > are exported by default. > > Adding a local section with a wildcard make non-listed functions > > and variables as hidden, as it should be in all version.map files. > > > > These are the changes done in the shared libraries: > > - DF .text Base auxiliary_add_device > > - DF .text Base auxiliary_dev_exists > > - DF .text Base auxiliary_dev_iterate > > - DF .text Base auxiliary_insert_device > > - DF .text Base auxiliary_is_ignored_device > > - DF .text Base auxiliary_match > > - DF .text Base auxiliary_on_scan > > - DF .text Base auxiliary_scan > > - DO .bss Base auxiliary_bus_logtype > > - DO .data Base auxiliary_bus > > - DO .bss Base gpu_logtype > > > > There is no impact on regexdev library. > > > > Because these local symbols were exported as non-internal > > in DPDK 21.11, any change in these functions would break the ABI. > > Exception rules are added for these experimental libraries, > > so the ABI check will skip them until the next ABI version. > > > > A check is added to avoid such miss in future. > > > > Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus") > > Fixes: 8b8036a66e3d ("gpudev: introduce GPU device class library") > > Cc: stable@dpdk.org > > > > If I take this 2/2 for 21.11.1, then I also need to backport [0] so I > won't have errors for common_mlx5. > > Any problem with taking both? > > [0] > commit c2e3059a10f2389b791d5d485fe71e666984c193 > Author: Michael Baum > Date: Fri Feb 25 01:25:06 2022 +0200 > > common/mlx5: consider local functions as internal I think that's fine to backport this as well.