From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7366EAADA for ; Mon, 16 Apr 2018 18:57:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7E62D21771; Mon, 16 Apr 2018 12:57:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 16 Apr 2018 12:57:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=pRZINgyEarAiAmGq+7sRkvPY8B AYdG/+KbuFgggjkDk=; b=JvMsElIE1J3zi1/BZaAfWQMRiuiWlMYNHiv+7/kdjx fq8jq57PSBkbNXVtinehwzXHCpPFoYmuNuFm63WOj1MJoFUIi2z8lvMws0Z4SfQI 6IddaHugZmXaFqhW+UYjMxBglvcWqQ3D/Tn2DPFmU23ECWfk9NeNHUedlXoGFJ7P E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=pRZINg yEarAiAmGq+7sRkvPY8BAYdG/+KbuFgggjkDk=; b=jWfZyv7Z6e2A1g7b0SmPmN cK9jq4No9kI+pQQknT2qqxkDK0zcC0lYFtoY76kvYCmEDQIHEMpdcy8Hh7o489vg hjzjqMwCTvfbOr8ejP/5AP8LusYChkPGh6sAUNlnPDcIZem3mNYkYvCRMirE9KkU g8w/udKkWEAniHRAAbwAmas9fC6spYZDKC9p80ZU7AoKdLVFz0me4iwqAjVAVB0h LzDLI4tCPZK1YZjMQ0ajHM5/dlqInPT0zEJ4l0YYgo0YDUmn2lzTWdFLafvfR67D KqA9kV6KjlKk0gO4AbYw0cts+ctRsLqJzWJO3NhQjxv4dKj9sC7HkD/lvtyINVVQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D96CCE4394; Mon, 16 Apr 2018 12:57:56 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, wenzhuo.lu@intel.com Date: Mon, 16 Apr 2018 18:57:55 +0200 Message-ID: <3918223.XbEGDHI6z0@xps> In-Reply-To: <20180416133911.289196-1-bruce.richardson@intel.com> References: <20180416133911.289196-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix compilation when vector driver disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 16:57:58 -0000 16/04/2018 15:39, Bruce Richardson: > The new functions for Rx and Tx offloads should not be inside the > conditional block for the vector driver, otherwise compile errors occur > when vector driver is disabled. For example: >=20 > ixgbe_ethdev.c:3636:36: error: implicit declaration of function =E2=80= =98ixgbe_get_rx_queue_offloads=E2=80=99; >=20 > This shows up as an error when doing ARM builds using meson as the vector > driver is not (yet) enabled for those builds. >=20 > Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API") > Fixes: ec3b1124d14d ("net/ixgbe: convert to new Rx offloads API") >=20 > Signed-off-by: Bruce Richardson Applied, thanks