From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 00A20F72 for ; Fri, 4 Mar 2016 18:47:08 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id n186so1310976wmn.1 for ; Fri, 04 Mar 2016 09:47:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=fddNLvtUvdIcVBLne6+y+5E7O90XREY1d7T1qJFrkis=; b=OfzwH2xxuoRNKkT7/fSFjQV5hp2j527rCkf3iGUwQCrIbTHLolGp8rF97WQRUn2Zvg K8gM3uWXY/qbjpjYI1OrGcOwSDEBr8uHFlltyaoB73Pqs5LEQJ5dkpVw8yLNsGOdOX5G R/q8BVBhz6RwLBjoBPr3bS3l54WHdSynB68KJXyDcGstHvHLhmsOVkChpFICj76GQXfb AjuLJgE7QzDNS8iedi+Mni6YWy1oRdoNvTm1omZ6cVIdmOqlw/rdFqST65IYVCrqucbY PDTMzArUtMTM+Dl1Ce2D59c4HK1OKJp7pkLDCEYtB/P1P5YPbJpqoGTin+TNU2/XlaA2 s9CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=fddNLvtUvdIcVBLne6+y+5E7O90XREY1d7T1qJFrkis=; b=Rq0sMt4GzU/fqsFVFhHwKp5Im1YuV+HSziB5DzamjNRWbPc1Iqav/LB8/LqZ9Ap2i1 S9h1X233lyO4WlmpXpwi8xklpJUtTK8NRo3ACy4mEMBzHjn3+RtkR70HhC7Y+H6uN/Nl tc/FZ8Kom5tlNJxgqrrMtriAHzOIdfaNyid1BkktB0kavcyvn5DQpjlQ8P6PFMpzyPIC eDBqiNCkIQdlTCQ2fghcskXndWR2+tUbpZhCE7B91Q1VhyPizyKYh0h3AFguz72DYOwg 33F7qxP9kGfAaTwRV7unmzT6/n6bOl55Dv4c412vvUkpa91U82GgSMH9Jx9vg6FUWSL2 15vg== X-Gm-Message-State: AD7BkJLOycgKYx9CGXdzktixsegSGEQy/+HNJyhIR/txmRfKFyel3ugawiSnklkYxEsXeX2Y X-Received: by 10.28.147.206 with SMTP id v197mr156383wmd.70.1457113628841; Fri, 04 Mar 2016 09:47:08 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id hh8sm4370025wjc.42.2016.03.04.09.47.07 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 04 Mar 2016 09:47:08 -0800 (PST) From: Thomas Monjalon To: "Trahe, Fiona" Date: Fri, 04 Mar 2016 18:45:31 +0100 Message-ID: <3919673.VtXZRcbfcO@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <348A99DA5F5B7549AA880327E580B43588F892F0@IRSMSX101.ger.corp.intel.com> References: <1456764731-27168-1-git-send-email-declan.doherty@intel.com> <2831187.Fjk3A3necn@xps13> <348A99DA5F5B7549AA880327E580B43588F892F0@IRSMSX101.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 0/2] cryptodev API changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2016 17:47:09 -0000 2016-03-04 17:43, Trahe, Fiona: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-03-04 17:17, Fiona Trahe: > > > This patch set separates the symmetric crypto operations from generic > > operations and then modifies the cryptodev burst API to accept bursts of > > rte_crypto_op rather than rte_mbufs. > > > > > > V5: > > > - updates .map file > > > - removes EXPERIMENTAL label from rte_cryptodev.h > > > > Why do you want to remove the experimental label? > > Declan had already removed from the MAINTAINERS file and other places in previous patches. > This one was just forgotten as far as we know, though as Declan is out we can't confirm with him. > Do you think we should keep the label ? I cannot really decide because it's hard to understand the improvements in a such big patch. It would be easier if the changes were split in several steps. Maybe the last step (last patch) would be to remove the flag. Having it in a separate patch would give the opportunity to detail the reason of the removal in the commit message.