From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80C89A04C7; Mon, 14 Sep 2020 16:44:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 673FA1C0D5; Mon, 14 Sep 2020 16:44:02 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id AF53B1BE98; Mon, 14 Sep 2020 16:44:00 +0200 (CEST) IronPort-SDR: 36IPjb2TjbYSKKrQAc7592EkV5GWRiD00xctbb2oueRm8hdbfaPv4Eti0/IxAGbY205ns61j+Q y9lim/5Q0tSA== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="223270486" X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="223270486" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 07:43:58 -0700 IronPort-SDR: PE7ZH7ZgidLCmsIWs2lhOMwVzLhulYeponck/04OAtpcsQUeyq84WEG043zlgYzgDV6tYPO/fb OId0tjGUI1aQ== X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="507166668" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.247.225]) ([10.213.247.225]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 07:43:56 -0700 To: wangyunjian , dev@dpdk.org, nikhil.rao@intel.com Cc: jerry.lilijun@huawei.com, xudingke@huawei.com, stable@dpdk.org References: <40a0e68ed41b05fba8cbe5f34e369a59a1c0c09c.1596022448.git.wangyunjian@huawei.com> <1596880723-1552-1-git-send-email-wangyunjian@huawei.com> From: Ferruh Yigit Message-ID: <391ede8a-2308-4cf6-c0cc-55716a113217@intel.com> Date: Mon, 14 Sep 2020 15:43:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <1596880723-1552-1-git-send-email-wangyunjian@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/tap: free mempool when closing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/8/2020 10:58 AM, wangyunjian wrote: > From: Yunjian Wang > > When setup tx queues, we will create a mempool for the 'gso_ctx'. > The mempool is not freed when closing tap device. If free the tap > device and create it with different name, it will create a new > mempool. This maybe cause an OOM. > > The snprintf function return value is not checked and the mempool > name may be truncated. This patch also fix it. > > Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.