From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D29BA057B; Tue, 14 Apr 2020 15:04:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B3451C1F6; Tue, 14 Apr 2020 15:04:00 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3C78A1C124 for ; Tue, 14 Apr 2020 15:03:58 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id D90B15C02A3; Tue, 14 Apr 2020 09:03:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 14 Apr 2020 09:03:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=qTTOHa6TyZh1Zsr86QXp7nKf+yJesdri1VG+XV6759I=; b=Dotjf6BoDYV/ +5em0sH9pH79/y5xQ9fGU0RmZClo9ALbScblpfNqUh6+qNsTTi0DEe/WI7wBf1Oc AC4N33gUOhyiJU34ybfPcNBGwPzHAl5maWcoAxbeCvD01P45RwB0tQl3tAMIQNXz SkL3K9KSBu07W9PXZN/yEvqAmcxeQI0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=qTTOHa6TyZh1Zsr86QXp7nKf+yJesdri1VG+XV675 9I=; b=J1v5GA2MSuaSJ/hEsB7CXJYcwLY6jNLNbpXGVbhJsOHYbMe7CA07MTZwW y6LF48QkxJmlceAD1m6dkLSfnWd1XKgjXQDOdpj+1tcdMzIRymak6VAtZOkfDjNY F6pAqjbOsbe3tZLLIXONpGvdv02Nki0tYOpWt85JYQOW4YTCoStYNMOQpnxlYy23 kclhsXfGqDsOc2/y5bgeIO1Vkooa8gT2HXB238IHJN+i7S0wjO8nuxhXyXl56wJ/ uvKzKZmP5ciaXjp5sk4IUOkEvbxa+DmOZmaaU/rIWkPi1OSPnXZrDygiizWtNd2G o1IpuFNjJ75tB0fnc8qKNpGzZNYDw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfedugdeitdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 30432328005A; Tue, 14 Apr 2020 09:03:55 -0400 (EDT) From: Thomas Monjalon To: Arek Kusztal Cc: Ray Kinsella , "bruce.richardson@intel.com" , dev@dpdk.org, "fiona.trahe@intel.com" , "dev@dpdk.org" , Akhil Goyal Date: Tue, 14 Apr 2020 15:03:54 +0200 Message-ID: <3920120.q0ZmV6gNhb@thomas> In-Reply-To: References: <20200318204136.10508-1-arkadiuszx.kusztal@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/04/2020 14:13, Akhil Goyal: > Hi Ray/Thomas/Bruce, > > Could you please help review this patch wrt ABI policy? > > > > This patch adds versioned function rte_cryptodev_info_get. > > Node 20.05 function works the same way it was working before. > > Node 20.0 function strips capability added in 20.05 release What are Nodes 20.05 and 20.0? > > to prevent some issues with ABI policy. To do that new capability > > array is allocated per device and returned to user instead of the > > original array passed by PMD. rte_cryptodev_info is provided by the caller of the function. I don't understand what you explained above, and the code is missing some comments explaining the reason of the logic. I still don't know whether this patch or not because it is missing some clear explanations.