From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Common netlink parsing?
Date: Sat, 25 Apr 2020 21:37:06 +0200 [thread overview]
Message-ID: <3921713.uADA5c2rLh@thomas> (raw)
In-Reply-To: <20200425122426.351675d7@hermes.lan>
25/04/2020 21:24, Stephen Hemminger:
> While adding error handling to tap device, I noticed we already have two
> places rolling their own netlink message handling (tap and mlx5) and now
> with proposed IF proxy there is a third.
>
> Netlink is non-trivial and easy to get wrong and doing error handling
> also requires work. There should be a common library for this.
>
> My preference would be to use pre-existing code (libmnl) but the
> DPDK maintainers seem to have an aversion to taking a dependency on
> any external code and reinvent everything (see RCU etc).
We should avoid reinventing wheels.
About RCU, I think it was said no library meets the same requirements.
Honnappa, any comment?
About libmnl, it was used in mlx5 some time ago.
It has been removed when it was thought it is not required anymore.
Maybe you could demonstrate libmnl benefit by integrating it with
the tap PMD first.
next prev parent reply other threads:[~2020-04-25 19:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 19:24 Stephen Hemminger
2020-04-25 19:37 ` Thomas Monjalon [this message]
2020-04-27 11:43 ` Andrzej Ostruszka [C]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3921713.uADA5c2rLh@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).