From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76276A00C2; Sat, 25 Apr 2020 21:37:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5828D1C19F; Sat, 25 Apr 2020 21:37:10 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id DDB701C194 for ; Sat, 25 Apr 2020 21:37:08 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 2E7015C01AC; Sat, 25 Apr 2020 15:37:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sat, 25 Apr 2020 15:37:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= hTgLllcpahqa7SW2WZhV593W2Aefncbym/8smj66x5k=; b=SGykNVi8/wH8B1C7 lnJSnAoqFAoSBk/fKdbm8hMTNwotZzNJCzwdv8OxWJYPYCOQ4NubEkeEIe3XYCsU og3FHHoh3iXYgIP7Mh1IZgHleRg5pF7eDoqYf5ki5DJT97F02EQ3EP8g5qaU6MPE +KFR0icygqofKm+C86Ic+aLVzVfwBhPLZLaRtKcDh/SUDlpjInFGbwjPCwJzDSsL wkTN7fhE33ugMWkwwBICUa45Ts2s2MWlMa8WtTrD3lyxh775ikM9ne4CzMJg/V4D poIwg4myxsuRV89CPaP6RLeqGTm5zGQiFkR6SqU1nmk1c7UAbsV51msLSfV8ipl4 s2FTaw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=hTgLllcpahqa7SW2WZhV593W2Aefncbym/8smj66x 5k=; b=N/7jIy39jbT8yyqgnzYwJbMQRVtETGzHf4Pdx2s53hwuzMtUbCHDoiprf AxTx+wNO6g/hcHUYvYwxQk9//TNIMrqhUIWqD1jzKRkoTV8jChS3HXK77K6Y7+g3 9FTVmlxNph+YAj10EinQ2PlO+i4UhBxnSymFrBl8O7kKuHLxry+1MpBdkRH65c+f UFT+PFk6kxMKCPw2dObuWPgAe+fw8OeNtuv/av9f6979LA97VY4moznFn3y6X9Dc Wv49ZqN+gqJfrMRAc7n6NI4/i5pr6JekONyvubDyM3rFIbqySZPLEwHn4C1UGlkC d+uAgHkUbRbz5iokIE9lOnfDU8zLQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrheeggdduudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7F5F53065E02; Sat, 25 Apr 2020 15:37:07 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org Date: Sat, 25 Apr 2020 21:37:06 +0200 Message-ID: <3921713.uADA5c2rLh@thomas> In-Reply-To: <20200425122426.351675d7@hermes.lan> References: <20200425122426.351675d7@hermes.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] Common netlink parsing? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/04/2020 21:24, Stephen Hemminger: > While adding error handling to tap device, I noticed we already have two > places rolling their own netlink message handling (tap and mlx5) and now > with proposed IF proxy there is a third. > > Netlink is non-trivial and easy to get wrong and doing error handling > also requires work. There should be a common library for this. > > My preference would be to use pre-existing code (libmnl) but the > DPDK maintainers seem to have an aversion to taking a dependency on > any external code and reinvent everything (see RCU etc). We should avoid reinventing wheels. About RCU, I think it was said no library meets the same requirements. Honnappa, any comment? About libmnl, it was used in mlx5 some time ago. It has been removed when it was thought it is not required anymore. Maybe you could demonstrate libmnl benefit by integrating it with the tap PMD first.