From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 224B9A00C3; Tue, 1 Feb 2022 15:11:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1644F40698; Tue, 1 Feb 2022 15:11:56 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 96BEE40691 for ; Tue, 1 Feb 2022 15:11:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643724714; x=1675260714; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=be326C7ERLImy2Oz6k+aGy1FvL6GjjBVoEtXL8rHRkU=; b=azC9SLa1MnlOCG1zzQghvGpbKAmF8NIPeG4uNLut2kkuxmHk0bjgfth4 uwf7kulp/+SUbDqSFA+1uq6ILKVZbwFQv1JSZ+Acl1XJv0BJZas+ehRjb D37rcDfWTKVvMkqI8vfnrj1PQbyjUpL0o+0P9SrUo7LWdlDxnLJ3rJWpc oghvVqvKhdBQNcQi0CU8d6w9fes8jrJt3nimP7YXnGy96oNgX884+PObQ 41tc/rG4uS46fA9aR3rQDgOgkH78ZBumVZRtbguwKMTO82cEMG8hnvSyE hg35noygBzhZAXh67Zx/R9uLixYv1JOk785huyuewCU8+u9SdyQiQ741y A==; X-IronPort-AV: E=McAfee;i="6200,9189,10244"; a="247467313" X-IronPort-AV: E=Sophos;i="5.88,334,1635231600"; d="scan'208";a="247467313" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2022 06:11:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,334,1635231600"; d="scan'208";a="523061644" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 01 Feb 2022 06:11:53 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 1 Feb 2022 06:11:53 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 1 Feb 2022 06:11:52 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 1 Feb 2022 06:11:52 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 1 Feb 2022 06:11:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lholI+LD7RoaBh7XbJOG9WsPx0TFtDzNr5SgfchyQDN6PbHZlYhST01ZS/g2b9bQXMDVMY81qjr7uagkD0/Sgj6blb4+ErwkYB9RyX4htXNq0qjpY/xFID+UrBBTq/q9d1RbeJleBQo3GUfZI3fvCJPH3iZNR0sPuycT5iFP1gtj1kuKDY9TvsKfrPexL4N6jUBHbX4sgzkg5x8EGjIDcd1WGahjqo1x1LCvfoGTAidxS4oo9h/s0x61MPMkQ46lmffFBeK9AM27RIEFs9sn1/e0/2v/xHWwg08y3qzL9RYGY+uTt9UD5zO9QTVUthqazc9QP6NZGxCFswg9qrXRew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KcVrn+KKsfs1AhCy5sB7ht17VuAwp86bOlTofJohDYM=; b=SEFcU+Xnyep+5IWnfoMwUrjOTbNzDCQxhMY2OtDb5wxIhFKHs6hbQ/E7vqvv9sA9y5/tHW0B3zxsa33y8eZ1JENPVlVY4Z0Zkp6S2wtm/+akS8M6Rawsu7ur2X2kMFySGNKryN9gw9vTcDu12h1fMDxz3jNn6kl60t8EPtuiOv47IjI/E0v6mbi+jGExeKS09UolKT50BJ65HsKiLCho5Pc6BlePdthGgBlbx07aY0T0WZe34BMg3hX702dMGnIPToFtgjywkbPwujNS+jHq2uPDjcjiTSXA+UopPhv3ILYh+h2wAKb7Vt9QeDkRx2yMVsud6/kR+XAQavyGXx2WfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BL0PR11MB3073.namprd11.prod.outlook.com (2603:10b6:208:7c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Tue, 1 Feb 2022 14:11:49 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022 14:11:49 +0000 Message-ID: <39225266-65b0-78b7-04ad-56be65d835f0@intel.com> Date: Tue, 1 Feb 2022 14:11:42 +0000 Content-Language: en-US To: Akhil Goyal , , Olivier Matz CC: , , , , , , , , References: <20220120162627.4155695-1-gakhil@marvell.com> <20220130175935.1947730-1-gakhil@marvell.com> <20220130175935.1947730-4-gakhil@marvell.com> From: Ferruh Yigit Subject: Re: [PATCH v3 3/4] ethdev: add mbuf dynfield for incomplete IP reassembly X-User: ferruhy In-Reply-To: <20220130175935.1947730-4-gakhil@marvell.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0009.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::14) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8d384045-ec75-4c62-bf24-08d9e58cc997 X-MS-TrafficTypeDiagnostic: BL0PR11MB3073:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uPrAeghVTDyVXEZf0xg7lgX88DWv7LxjHxtPRft0+uhr7lihBQsFsqKoYd64SpSliLZCoLSh6rALNK3wK69f3Q22RSfgxciNzex8x3+hHsXMjT9XkV3cwIyC1h+S/TGgL9En8WwZeFlP7EETlQ9o1294AoqQonEVPD4xx/TT++YJf8Iy1ZY0ufvIeXMCEmHnobYQk1asr5njAVkD/RQyLN4xlBkxZly2vfJEIRrnfSrwGPgWrJrkywdmSFNxr8qdGjKLdLuIbazWaD/ReGxffy/mNHrgjdgPUNbCvP9rV9nDSsWqkus6W/bjxjTN0awsK7zib9PnoqEhb1HwuRank9hwGtzE+bbg+oX0kO6x1ll58udMNpjWH+SEPyIfeOiUJX/eV1jPVSKsa6qto7cKj/dtDff2iIJWkrmiMDnRTMyPeZsswjrFKhy1kfF+qc7Ihl3P4pUVwcfF6INmcod1y3u9yPP/UWjUm8kn85t1CO6GQw19Yq/vw/NtDcvAS2qiKqFL16LQPVd0VElDlBmaQfpn2HTQVBvrB+WS3KuKw2sYSOV4NkUyY09jao9iGe3FeWuPg/l2vFVdUiaRuwx4iPIxJGe7Uu5D+JiJzPXc8X2FmbDxtj7Uc4nfUl15Bp4rM2Y+/wDLdLaUZH+7ZAY+fqFCWYGtY+oAwFHtRQvT3in24naUAt3OW3KZUhdfWMx+Q1tuAxOxc8M7VkLkZyirAA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66946007)(31686004)(110136005)(6486002)(31696002)(44832011)(2906002)(82960400001)(5660300002)(316002)(36756003)(6512007)(86362001)(38100700002)(8676002)(8936002)(4326008)(186003)(2616005)(6506007)(6666004)(26005)(66476007)(508600001)(7416002)(53546011)(55236004)(66556008)(45980500001)(20210929001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajZHYTRGdy9CajdlSFVXbWtzVDZFaTgrcFdsTTVRRCtGdXlUeGwyTWhQSm5p?= =?utf-8?B?Uk1FNHFiTGF5cnpCQVVUTm1kZFpPLzJSeDdlQkxUV1BmZDMxc2NpT2tISy9t?= =?utf-8?B?ZkdoMlNkaW5QdFM2NTNoaFdxYjVOVEQ0c3Vod0lrL1pjdlAxaysvTWJXSXV0?= =?utf-8?B?S2dvaVlsRWNwanRsVlpGa3R1SDhUNWxJSWRRWUtRRVl3ZzRGQThzUEg3bVdZ?= =?utf-8?B?enovcCtwejJBUncvM3dpT253YUxxelNpbk5zWmlueEdXR2pxNVk5d043Y0Jr?= =?utf-8?B?NnZOWkdxVURUeW0zOE1aUjdFZktKVUxacnpIQWdnTDBTbzJHR0xOUjZ5S2lL?= =?utf-8?B?UFBDRUpYK1AydjJib0NMMTdkTzJnTDBHRjNXSFdOQ25EdzNhNUlLWnRLcDYz?= =?utf-8?B?NnQ0OXovYlBzaDhCL1VHTE5NWEx3ZVpNdHdzc3BzR2szN0VWYmxxZlF5SzhQ?= =?utf-8?B?bkpmaVpPanVqanFxR0JtcEk3bnJLOGZaUUlmNXdOSUVzVURqa2txa1A3cXVn?= =?utf-8?B?aWZ1V3JFQ1h5TE1TK3orZmMwaHUxTTJRZkpxbWtFUEdmVWI3TWdEOUl4TDJv?= =?utf-8?B?UGo1cndBMnQyV05nc243T2ZDeDkxdkpBZkdrakwvV2NzMG53c3dLYWQ1LzJW?= =?utf-8?B?TXhnNWExakpJbUtCY3ZYOTFlT3ZiaS9sLzJ6VFNPTS9aSytGZnBrV1EyKzht?= =?utf-8?B?eU1EbmdQL1BXREFPUUd5ZmtPWGl6akptdzFHN2Zkd0twSVZqWUxockQ5QmFJ?= =?utf-8?B?d3FoTWxjajE1UXVWaG4zUlRtZjMwRE9wTiswd2tiNW1RNWk0Z1VJZC81QkYz?= =?utf-8?B?WXZHTUxzYmowaHlFMUdGWDNhandmWFo5WG15c2JOelcxc25CT1dnOWVFRmlm?= =?utf-8?B?ZStwVFNvMVB6dFBwSkEzTUJqOU0yVmxER2tFZTlaYWRYalJDWkdFM241NTMz?= =?utf-8?B?bnBEMU0zSXFCcFoxcllYNGxNSnRuRGRZV1cwS3ZGWTFlczJhcS9NY3Fya0ZB?= =?utf-8?B?VWI0ckVhUk5HZG1mSkV6NE1tUWwxckM0eUVYV2xGS242V01qZ2JScERsNER4?= =?utf-8?B?ajFWRk1kRDByNzU3RGo2bytERDIxR2hrS2VQb3NNNmZHTk5SQmxMTUFXUUZM?= =?utf-8?B?WCsvWEo1dE1FaTl1cTBVN1RUTkcxTmp2VjJjR2gxSk9DNGpuSDlHU254UzMx?= =?utf-8?B?N0piZ2Z1OThMaGVMSTI0bXJlUHdMVjBMZ0hkWDZkTkRCQlczZzVBdVhJRkpT?= =?utf-8?B?WHlYNEZHVzVCT0ROSzB3MUVSRHZYdW9SSjVETlBaZ0dvZXkyTmlFbFNndFE1?= =?utf-8?B?MGlFeFRaTUQ1OGY0SGMrY3Y1UGtoMVlyWFlmeDJZVkRaeDJid0xoTVJJS3hJ?= =?utf-8?B?aytpcC9KaWxBK2NXNHFBelIrWUlnaHZGcWtrSjJwdjRGSUxnSGtITEw1eTU2?= =?utf-8?B?MjJ0Ni9VUFhFSjRnMTVKY1YrcGExbnc1NFA1V2hpYXhuTzNWZExsR2NPT2d2?= =?utf-8?B?ZytBRGUyeWgvRnlKcitZRnJYR0Y3OEpUQmRqSjJpaHE2WnpGSUp0dGZUM3VM?= =?utf-8?B?cGpzMStFSDdZNmI0NkUvR0VXZ3FhWG9ld0hjR2NXQWkyd0JYVGNvR3oxdTRi?= =?utf-8?B?MkZWR1owcEZ4SUVEeVdiZVl4NDd3aGtIcE1PWkFwTkVaNnlZUGNyRnhwbFNo?= =?utf-8?B?NHN4SFpHNVc3RHBjSCt5RXdFWktURHcrMHprWHUxVnRjbC9lZ3lJK2lYb24y?= =?utf-8?B?Z3M3NDAwdU9VWThmMDhHRkNuNi9OMnZDYUdMbUphcjFkYVV0WEI0Y09XR1pn?= =?utf-8?B?Z3dvYU55dkRNQ2N6TWtub0h0dDRyNFI2eEZpbkVHRXJGTVpGNXNhdzBzREtL?= =?utf-8?B?d3VWYkVkQUp4YWhKOCttT00yNENLQlRDeXQrQkFOV0wraUhZUnp2WUNpQ21B?= =?utf-8?B?OXAwblBpL1ZsZHRhV2ZneTR2TjV6VU1Xa2tteVJCTEwwNzFPWDlNWmkyeDg5?= =?utf-8?B?OGRITHRFRHRKL1BlcFlPbkpxRThKZmxFV2oxalhFSUYvZUdvV1lLV3Q1a2U5?= =?utf-8?B?T3hvL05JbXZyajM3Vk9Ma1FZVm9XNGVieDJyTksvZUFlUW01TjFQd0d1MWd0?= =?utf-8?B?TEppTTYxbmdkVnBqaDlGSnovdFIyTEtZWnZaRWgyeHpvTGx5Q05GQm1pRERs?= =?utf-8?Q?F0jE1Ku7LNVtjZACmvvQz1M=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8d384045-ec75-4c62-bf24-08d9e58cc997 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 14:11:49.2482 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pxqpAC0pkK8/jN/vcXQJaKIJRIdk2Lur+4j0slenAsiEwhPNnpZeq4VQft3ifc6MMSXI0aMH/uITxEMRamtIuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3073 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/30/2022 5:59 PM, Akhil Goyal wrote: > Hardware IP reassembly may be incomplete for multiple reasons like > reassembly timeout reached, duplicate fragments, etc. > To save application cycles to process these packets again, a new > mbuf dynflag is added to show that the mbuf received is not > reassembled properly. > > Now if this dynflag is set, application can retrieve corresponding > chain of mbufs using mbuf dynfield set by the PMD. Now, it will be > up to application to either drop those fragments or wait for more time. > > Signed-off-by: Akhil Goyal <...> > index e3532591f4..e3e6368a1d 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -5264,6 +5264,27 @@ __rte_experimental > int rte_eth_ip_reassembly_conf_set(uint16_t port_id, > struct rte_eth_ip_reass_params *conf); > > +#define RTE_ETH_IP_REASS_DYNFIELD_NAME "rte_eth_ip_reass_dynfield" > +#define RTE_ETH_IP_REASS_INCOMPLETE_DYNFLAG_NAME "rte_eth_ip_reass_incomplete_dynflag" For other dynfield/dynflag these defines resides in mbuf library, not sure if these also should go there. cc'ed Olivier for comment.