DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
	"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "Doherty, Declan" <declan.doherty@intel.com>,
	"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] test/crypto: do not check for IMB_VERSION_NUM
Date: Tue, 14 Apr 2020 19:48:39 +0200	[thread overview]
Message-ID: <3924051.KRxA6XjA2N@thomas> (raw)
In-Reply-To: <SN6PR11MB310190569DFA23C2EEBE45CD84DA0@SN6PR11MB3101.namprd11.prod.outlook.com>

14/04/2020 19:22, De Lara Guarch, Pablo:
> Hi Thomas,
> 
> From: Thomas Monjalon <thomas@monjalon.net>
> > 14/04/2020 12:22, Pablo de Lara:
> > > Now that capabilities are checked to see if an algorithm is supported
> > > by a device, there is no need to check for a specific version of a
> > > library used in a PMD.
> > 
> > Yes, and even no need to check the PMD at all.
> > All *_TEST_TARGET_PMD_* constants should be removed.
> > 
> 
> I am currently working on this. However, I would like to split this effort
> into multiple patchsets. A first one addressing the problem of needing to check for
> specific information from PMDs (such as IMB_VERSION_NUM), which should not
> have any effect on the number of test cases ran for each PMD, and another one which
> addresses your comment, and that will enable test cases for all PMDs.
> This last patchset will require testing from all PMD maintainers and it is a less urgent
> problem to resolve, so we can decide if we want to merge it in this release or wait
> for more time in 20.08.

Thanks for your efforts Pablo.
If the basic is working, I am for removing *_TEST_TARGET_PMD_* in 20.05,
and allow PMD maintainers to validate the tests during -rc phases.



  reply	other threads:[~2020-04-14 17:48 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 10:22 [dpdk-dev] [PATCH 1/2] test/crypto: add capability check Pablo de Lara
2020-04-14 10:22 ` [dpdk-dev] [PATCH 2/2] test/crypto: do not check for IMB_VERSION_NUM Pablo de Lara
2020-04-14 10:34   ` Thomas Monjalon
2020-04-14 17:22     ` De Lara Guarch, Pablo
2020-04-14 17:48       ` Thomas Monjalon [this message]
2020-04-22  9:16         ` Thomas Monjalon
2020-04-22  9:43           ` Akhil Goyal
2020-04-22 10:56             ` Thomas Monjalon
2020-04-15 10:28   ` Dybkowski, AdamX
2020-04-14 10:35 ` [dpdk-dev] [PATCH v2 1/2] test/crypto: add capability check Pablo de Lara
2020-04-14 10:35   ` [dpdk-dev] [PATCH v2 2/2] test/crypto: do not check for IMB_VERSION_NUM Pablo de Lara
2020-04-15 10:30     ` Dybkowski, AdamX
2020-04-14 17:40   ` [dpdk-dev] [PATCH v3 0/2] Crypto test refactoring (first phase) Pablo de Lara
2020-04-14 17:40     ` [dpdk-dev] [PATCH v3 1/2] test/crypto: add capability check Pablo de Lara
2020-04-15 10:31       ` Dybkowski, AdamX
2020-04-16 11:15       ` De Lara Guarch, Pablo
2020-04-14 17:40     ` [dpdk-dev] [PATCH v3 2/2] test/crypto: do not check for internal PMD information Pablo de Lara
2020-04-15 10:30       ` Dybkowski, AdamX
2020-04-16  9:08     ` [dpdk-dev] [PATCH v4 0/2] Crypto test refactoring (first phase) Pablo de Lara
2020-04-16  9:08       ` [dpdk-dev] [PATCH v4 1/2] test/crypto: add capability check Pablo de Lara
2020-04-16 15:35         ` Ruifeng Wang
2020-04-16 16:26         ` Trahe, Fiona
2020-04-16 16:44           ` De Lara Guarch, Pablo
2020-04-16  9:08       ` [dpdk-dev] [PATCH v4 2/2] test/crypto: do not check for internal PMD information Pablo de Lara
2020-04-16 15:35         ` Ruifeng Wang
2020-04-16 17:24       ` [dpdk-dev] [PATCH v5 0/2] Crypto test refactoring (first phase) Pablo de Lara
2020-04-16 17:24         ` [dpdk-dev] [PATCH v5 1/2] test/crypto: add capability check Pablo de Lara
2020-04-16 17:53           ` Trahe, Fiona
2020-04-16 17:24         ` [dpdk-dev] [PATCH v5 2/2] test/crypto: do not check for internal PMD information Pablo de Lara
2020-04-16 17:53           ` Trahe, Fiona
2020-04-19 21:15         ` [dpdk-dev] [PATCH v5 0/2] Crypto test refactoring (first phase) Akhil Goyal
2020-04-15 10:29   ` [dpdk-dev] [PATCH v2 1/2] test/crypto: add capability check Dybkowski, AdamX
2020-04-15  9:16 ` [dpdk-dev] [PATCH " Dybkowski, AdamX
2020-04-15  9:23 ` Dybkowski, AdamX
2020-04-15 10:29 ` Dybkowski, AdamX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3924051.KRxA6XjA2N@thomas \
    --to=thomas@monjalon.net \
    --cc=akhil.goyal@nxp.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).