* [dpdk-dev] [PATCH] ixgbe: Disable GCC warning on IXGBE base codes
@ 2014-10-09 7:27 Ouyang Changchun
2014-10-10 16:04 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Ouyang Changchun @ 2014-10-09 7:27 UTC (permalink / raw)
To: dev
This patch disables compilation complain from lower GCC version (less than 4.6).
Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
---
lib/librte_pmd_ixgbe/Makefile | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/librte_pmd_ixgbe/Makefile b/lib/librte_pmd_ixgbe/Makefile
index 0b647bd..3588047 100644
--- a/lib/librte_pmd_ixgbe/Makefile
+++ b/lib/librte_pmd_ixgbe/Makefile
@@ -66,6 +66,11 @@ ifeq ($(shell test $(GCC_MAJOR_VERSION) -ge 4 -a $(GCC_MINOR_VERSION) -ge 6 && e
CFLAGS_ixgbe_common.o += -Wno-unused-but-set-variable
CFLAGS_ixgbe_x550.o += -Wno-unused-but-set-variable -Wno-maybe-uninitialized
endif
+
+ifeq ($(shell test $(GCC_MAJOR_VERSION) -le 4 -a $(GCC_MINOR_VERSION) -le 6 && echo 1), 1)
+CFLAGS_ixgbe_x550.o += -Wno-uninitialized
+CFLAGS_ixgbe_phy.o += -Wno-uninitialized
+endif
endif
#
--
1.8.4.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] ixgbe: Disable GCC warning on IXGBE base codes
2014-10-09 7:27 [dpdk-dev] [PATCH] ixgbe: Disable GCC warning on IXGBE base codes Ouyang Changchun
@ 2014-10-10 16:04 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2014-10-10 16:04 UTC (permalink / raw)
To: Ouyang Changchun; +Cc: dev
2014-10-09 15:27, Ouyang Changchun:
> This patch disables compilation complain from lower GCC version (less than 4.6).
>
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> --- a/lib/librte_pmd_ixgbe/Makefile
> +++ b/lib/librte_pmd_ixgbe/Makefile
> @@ -66,6 +66,11 @@ ifeq ($(shell test $(GCC_MAJOR_VERSION) -ge 4 -a $(GCC_MINOR_VERSION) -ge 6 && e
> CFLAGS_ixgbe_common.o += -Wno-unused-but-set-variable
> CFLAGS_ixgbe_x550.o += -Wno-unused-but-set-variable -Wno-maybe-uninitialized
> endif
> +
> +ifeq ($(shell test $(GCC_MAJOR_VERSION) -le 4 -a $(GCC_MINOR_VERSION) -le 6 && echo 1), 1)
> +CFLAGS_ixgbe_x550.o += -Wno-uninitialized
> +CFLAGS_ixgbe_phy.o += -Wno-uninitialized
> +endif
> endif
Note that the tests in this file are valids only because we don't support
GCC 3 and there is no GCC 5 yet.
But I feel we should fix it soon.
Applied
Thanks
--
Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-10 15:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-09 7:27 [dpdk-dev] [PATCH] ixgbe: Disable GCC warning on IXGBE base codes Ouyang Changchun
2014-10-10 16:04 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).