From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
 [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id B8F878085
 for <dev@dpdk.org>; Fri, 10 Oct 2014 17:57:51 +0200 (CEST)
Received: by mail-wi0-f174.google.com with SMTP id cc10so2493455wib.7
 for <dev@dpdk.org>; Fri, 10 Oct 2014 09:05:18 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=BBxqhytMQAhD40ZY15R+YIXR7bJIqfIraS4mBw5pmTk=;
 b=l/QiHjsW3EThqj2X53avcFdrtC4qo5Bc3QmfadJdlnZunALSk5XWCCyTL3BkVWAbKc
 s2VH2xfLMW+DVVqJKo+MC/9TfKez0WTU5i7m9klCvSyUL00xsiTF6/xqUWGaQSozOefO
 YRn55H8D2P8Llz2qRRxuFWFy3Hwakn6z73mWJ2itZwe/4HagjI5Ajhsvn5iLbNbP+edK
 Uku/ybzg0BCzjmeOfTk6Ng49xZMSY7xL7T4v3Y5V24MF76Fah+GVMAb3b80I5RGfuW9T
 y9ykSkm2DNey1hRqBRrPeT4jxDSW4Ch7F4QCbuAUwWzfTuPgKMFGqPJ1T3dQi2YO8O/Z
 kvpg==
X-Gm-Message-State: ALoCoQkNthuCR/9dMNUvUYXVkqT5u2GAGFAifsLH/tw0UBOXWlrUn5w1sez50kEVAQ4IzOMlKcv6
X-Received: by 10.181.5.42 with SMTP id cj10mr5982896wid.28.1412957118238;
 Fri, 10 Oct 2014 09:05:18 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id wm6sm7491439wjb.5.2014.10.10.09.05.16
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 10 Oct 2014 09:05:17 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ouyang Changchun <changchun.ouyang@intel.com>
Date: Fri, 10 Oct 2014 18:04:59 +0200
Message-ID: <3936396.9kzqsUDoQ1@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )
In-Reply-To: <1412839679-8242-1-git-send-email-changchun.ouyang@intel.com>
References: <1412839679-8242-1-git-send-email-changchun.ouyang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: Disable GCC warning on IXGBE base
	codes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Oct 2014 15:57:51 -0000

2014-10-09 15:27, Ouyang Changchun:
> This patch disables compilation complain from lower GCC version (less than 4.6).
> 
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>

> --- a/lib/librte_pmd_ixgbe/Makefile
> +++ b/lib/librte_pmd_ixgbe/Makefile
> @@ -66,6 +66,11 @@ ifeq ($(shell test $(GCC_MAJOR_VERSION) -ge 4 -a $(GCC_MINOR_VERSION) -ge 6 && e
>  CFLAGS_ixgbe_common.o += -Wno-unused-but-set-variable
>  CFLAGS_ixgbe_x550.o += -Wno-unused-but-set-variable -Wno-maybe-uninitialized
>  endif
> +
> +ifeq ($(shell test $(GCC_MAJOR_VERSION) -le 4 -a $(GCC_MINOR_VERSION) -le 6 && echo 1), 1)
> +CFLAGS_ixgbe_x550.o += -Wno-uninitialized
> +CFLAGS_ixgbe_phy.o += -Wno-uninitialized
> +endif
>  endif

Note that the tests in this file are valids only because we don't support
GCC 3 and there is no GCC 5 yet.
But I feel we should fix it soon.

Applied

Thanks
-- 
Thomas