From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D556A04DD; Wed, 18 Nov 2020 16:04:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9CC37C912; Wed, 18 Nov 2020 16:04:32 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 054FFC910 for ; Wed, 18 Nov 2020 16:04:30 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 99032580476; Wed, 18 Nov 2020 10:04:29 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 18 Nov 2020 10:04:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= fXWFGDgFadjEpfQ2RcOc0mrN6CfshGZWOogI10TrY0E=; b=LzpySLXqR7KiudLp 34E5wXqLgOib0Ld9HUOraJzhkcQ3Mv4IcJHtuy5Wwq4XBKaHcexuOL+7PdwClXpn 3VSpuMGf0iJtDuT1MXCRKlJC+F3YAYhce9UfEw4/aj7o92yrzyx1PVZmfYJJdzjJ BGnqwlccdG3FKcS6QnzF8wNTErvMVy5uOdRyCnWJD0iaXjOigRaD7yKzviyXh4cv 0EVvZiSYyo0P21KLCxBq+OXX8lY7RFzNr3M99Jz8dEAwC47cdSidwrkwlPoqfhwt WeEPRth2fFxcatilhv0H3+d2BlWf2l8XwD7JNtp1cbvl2jyYm+etZW8IuzKbjgN8 XzfYOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=fXWFGDgFadjEpfQ2RcOc0mrN6CfshGZWOogI10TrY 0E=; b=fxg3NI6p8mNb6lXpsTh7mjUdj8iIP4q9ahWW8yi/3+0EtqUJtGn5yK9Gt nYMZwmOvw55Y6U2nlh/Yx0cLlEue6df/GcznmarkrN27e5cnBCOsj0WlZT9N80B2 OliJ9z4fk0lbhNA0st39EIFIsYM0M6my2zkime5cNEK/yS6oQg1i1n2Wpc4hBcvt QJ2Eq2frAiJ59/N/CstosUUbss0YIUduScjytMpsTq7fQydNSlCLOvrH5HG1lo4H bGToh1ZcXJP6+BDZ4Cf8OIvpLg7QN+DbdZiMgcEDC9tf7D7mSL4oM8Ilna2ZGjlh D0iAK9LrPtXMLPdSsY9cvj5HmSRgQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudefhedgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepueehueeuvdfggefftdeilefgtdfggfejfeehveekieegvdduieei uddtuedufeeunecuffhomhgrihhnpeguvghtvggtthhiohhnrdhsohenucfkphepjeejrd dufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D567E3064AB2; Wed, 18 Nov 2020 10:04:26 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: Juraj =?utf-8?B?TGlua2XFoQ==?= , "Ruifeng.Wang@arm.com" , "Honnappa.Nagarahalli@arm.com" , "Phil.Yang@arm.com" , "vcchunga@amazon.com" , "Dharmik.Thakkar@arm.com" , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "ajit.khaparde@broadcom.com" , "ferruh.yigit@intel.com" , "dev@dpdk.org" Date: Wed, 18 Nov 2020 16:04:25 +0100 Message-ID: <3940561.vbGRsYJtP0@thomas> In-Reply-To: <20201118145440.GB1362@bricha3-MOBL.ger.corp.intel.com> References: <1605267483-13167-1-git-send-email-juraj.linkes@pantheon.tech> <2337679.hKZaPKL2be@thomas> <20201118145440.GB1362@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v12 09/14] build: optional NUMA and cpu counts detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/11/2020 15:54, Bruce Richardson: > On Wed, Nov 18, 2020 at 03:42:36PM +0100, Thomas Monjalon wrote: > > 18/11/2020 15:19, Juraj Linke=C5=A1: > > > From: Thomas Monjalon > > > > 16/11/2020 10:13, Bruce Richardson: > > > > > On Mon, Nov 16, 2020 at 08:24:48AM +0100, Thomas Monjalon wrote: > > > > > > 13/11/2020 15:31, Juraj Linke=C5=A1: > > > > > > > +option('max_lcores', type: 'integer', value: 0, > > > > > > > + description: 'maximum number of cores/threads supported by = EAL. > > > > > > > +Set to positive integer to overwrite per-arch or cross-compi= lation > > > > defaults. Set to -1 to detect the number of cores on the build mach= ine.') > > > > option('max_numa_nodes', type: 'integer', value: 0, > > > > > > > + description: 'maximum number of NUMA nodes supported by EAL= =2E Set > > > > > > > +to positive integer to overwrite per-arch or cross-compilati= on > > > > > > > +defaults. Set to -1 to detect the number of numa nodes on the > > > > > > > +build machine.') > > > > > > > > > > > > First comment: I don't like having so long description. > > > > > > Second: I don't understand. > > > > > > > > > > > > It is said the default value is 0 so I expect it means automati= c detection. > > > > > > But later it is said -1 is for detection. So ? > > > > > > > > > > > Zero is for the "per-arch or cross-compilation default". This was > > > > > discussed quite a bit in previous versions and this was te best > > > > > compromise we could come up with. Having a default of auto-detect= is > > > > > definitely not something I think we should go with - just thinkin= g of > > > > > all the build CI jobs running on > > > > > 2 or 4 core VMs! However, Juraj really felt there was value in ha= ving > > > > > auto-detection, so it's set as a -1 value, which I'm ok with. > > > >=20 > > > > The problem is that I don't understand what 0 means. > > > >=20 > > >=20 > > > There are three pieces of information which we need to convey: > > > 1. The default value (0) indicates that per-arch or cross-compilation= defaults will be used. > > > 2. Positive integer values will be used instead of these defaults. > >=20 > > Where these positive values come from? > >=20 > > > 3. Detected values will be used for native build when the value is -1. > >=20 > > Why not detect for any native build set up with 0 (default)? > >=20 > That was one of the original suggestions, but I strongly disagreed with > that, because many builds are done on hardware very different from the > final deployment. It would mean that any builds done in e.g. jenkins or > travis, with a 2-core vm, would be limited to running with two cores only. Yes that's the difference between native and cross build: native build is not for running on a different machine. I feel you have a different understanding of native build?