* [dpdk-dev] [PATCH v1] test/rcu: remove redundant header file
@ 2019-07-24 3:25 Ruifeng Wang
2019-07-24 18:01 ` Honnappa Nagarahalli
0 siblings, 1 reply; 3+ messages in thread
From: Ruifeng Wang @ 2019-07-24 3:25 UTC (permalink / raw)
To: honnappa.nagarahalli; +Cc: dev, nd, Ruifeng Wang
RCU library now includes stdbool.h header itself.
There is no need to include this header file in RCU user files.
Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
app/test/test_rcu_qsbr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c
index 1d273e39d..d1b9e46a2 100644
--- a/app/test/test_rcu_qsbr.c
+++ b/app/test/test_rcu_qsbr.c
@@ -3,7 +3,6 @@
*/
#include <stdio.h>
-#include <stdbool.h>
#include <rte_pause.h>
#include <rte_rcu_qsbr.h>
#include <rte_hash.h>
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v1] test/rcu: remove redundant header file
2019-07-24 3:25 [dpdk-dev] [PATCH v1] test/rcu: remove redundant header file Ruifeng Wang
@ 2019-07-24 18:01 ` Honnappa Nagarahalli
2019-07-30 9:30 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Honnappa Nagarahalli @ 2019-07-24 18:01 UTC (permalink / raw)
To: Ruifeng Wang (Arm Technology China)
Cc: dev, nd, Ruifeng Wang (Arm Technology China), nd
>
> RCU library now includes stdbool.h header itself.
> There is no need to include this header file in RCU user files.
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
> app/test/test_rcu_qsbr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c index
> 1d273e39d..d1b9e46a2 100644
> --- a/app/test/test_rcu_qsbr.c
> +++ b/app/test/test_rcu_qsbr.c
> @@ -3,7 +3,6 @@
> */
>
> #include <stdio.h>
> -#include <stdbool.h>
> #include <rte_pause.h>
> #include <rte_rcu_qsbr.h>
> #include <rte_hash.h>
> --
> 2.17.1
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v1] test/rcu: remove redundant header file
2019-07-24 18:01 ` Honnappa Nagarahalli
@ 2019-07-30 9:30 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2019-07-30 9:30 UTC (permalink / raw)
To: Ruifeng Wang (Arm Technology China); +Cc: dev, Honnappa Nagarahalli, nd
24/07/2019 20:01, Honnappa Nagarahalli:
> >
> > RCU library now includes stdbool.h header itself.
> > There is no need to include this header file in RCU user files.
> >
> > Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-30 9:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-24 3:25 [dpdk-dev] [PATCH v1] test/rcu: remove redundant header file Ruifeng Wang
2019-07-24 18:01 ` Honnappa Nagarahalli
2019-07-30 9:30 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).