From: Thomas Monjalon <thomas@monjalon.net>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
"Ma, WenwuX" <wenwux.ma@intel.com>
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
"Hu, Jiayu" <jiayu.hu@intel.com>,
"Wang, Yinan" <yinan.wang@intel.com>,
"He, Xingguang" <xingguang.he@intel.com>,
"Ling, WeiX" <weix.ling@intel.com>
Subject: Re: [PATCH v3] examples/multi_process: reconfigure port when rss or csum isn't supported
Date: Tue, 08 Mar 2022 14:22:02 +0100 [thread overview]
Message-ID: <3942958.QZUTf85G27@thomas> (raw)
In-Reply-To: <PH7PR11MB6006D25ED1FBA1F99A9DCEAAEE019@PH7PR11MB6006.namprd11.prod.outlook.com>
28/02/2022 08:55, Ling, WeiX:
> From: Bruce Richardson <bruce.richardson@intel.com>
> > On Tue, Feb 22, 2022 at 10:51:27AM +0000, Wenwu Ma wrote:
> > > The default values of rx mq_mode and rx offloads for port will cause
> > > symmetric_mp startup failure if the port do not support rss or csum.
> > > This Patch make the app to reconfigure the NIC without them. Only quit
> > > the app if the second reconfiguration fails.
> > >
> > > Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
> > > ---
> >
> > While I am surprised to see different error codes for different essentially the
> > same issue - lack of HW support, that is a separate problem to the one this is
> > addressing. Given this is just a sample app, I think this approach is fine for
> > configuring things - keeping things simple for the user.
> >
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> Tested-by: Wei Ling <weix.ling@intel.com>
Applied with title "examples/multi_process: make RSS and checksum optional"
prev parent reply other threads:[~2022-03-08 13:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 15:17 [PATCH] examples/multi_process: add options to control port configuration Wenwu Ma
2022-02-17 9:06 ` Bruce Richardson
2022-02-18 6:49 ` Ma, WenwuX
2022-02-18 9:41 ` Bruce Richardson
2022-02-18 10:10 ` Ma, WenwuX
2022-02-18 10:22 ` Bruce Richardson
2022-02-21 15:35 ` [PATCH v2] examples/multi_process: reconfigure port when rss or csum isn't supported Wenwu Ma
2022-02-21 9:21 ` Bruce Richardson
2022-02-22 10:51 ` [PATCH v3] " Wenwu Ma
2022-02-22 9:41 ` Bruce Richardson
2022-02-28 7:55 ` Ling, WeiX
2022-03-08 13:22 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3942958.QZUTf85G27@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=weix.ling@intel.com \
--cc=wenwux.ma@intel.com \
--cc=xingguang.he@intel.com \
--cc=yinan.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).