From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EB7DA00C2; Tue, 8 Mar 2022 14:22:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDC904068E; Tue, 8 Mar 2022 14:22:10 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 5A6F84068B for ; Tue, 8 Mar 2022 14:22:09 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id D8BEC3200564; Tue, 8 Mar 2022 08:22:05 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 08 Mar 2022 08:22:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=E4SB9d9rmrUtcA wNO+Ssuk0QkC8l8ciEn11UzQAhKGs=; b=YGibMYcopyJmM6tpkIwOp33KdPcrdR RTCXeIGuypRaiVZVz7jcK0Cq8S0sw+p6+vpZaNp7CLHe9CoRL0lVt6N8VRhuvHNP kqO30+Lct7IK0T0wEQt4m1mUmDNtSx/FRIjWwLooW3VSiocw+wwMWEhBDpiFL/FX S/K8gDi2mx6DWTw5W7izhqdJo1hMXERRK39rQmtH5lqleBqRvKkesfqojbFJmGEv kpALO5GUC7GXzCJHh9iB1eroumI4IKFflY2rHMbZf/k8Y1PNqwakg5oJ20lI+STa 9tUOkGOtIRx0WvfSwJRrDgUf2h3+3dgqJhB0PX4uynK+cvLzNxDZFbfA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=E4SB9d9rmrUtcAwNO+Ssuk0QkC8l8ciEn11UzQAhK Gs=; b=cEIjnCvMUZA/W5DGGGa5G2c/EopToQB38pKdIKrHlxSUO5objp+0POACy rpjI0Ti64DDEg9LNGQ2gT61vZtNe3SMn7vNAwV04nvZpSmn02jtkkeZ/4Lz40kM2 5iU2iDz1M6vFOhcev2YsPE/kICuuARalBRz7jdtFVJ1TEmt01fO519pH1D1FD1Rj gPDLEH1fUx0a8j9BlNP8OA5KNQMeDnacegmNp/Mxq3NnKF0Q2AVx1kf/7ezoJOSg 4bTWyz17wsYHeyvGgyB1iNS0kuKqNx0vVOWJK85lZznnI6Iy6wGySobldNYi2ISg W5RlcR5Pm52qqGXC2EbdqtRZ/qozg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudduiedgheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Mar 2022 08:22:03 -0500 (EST) From: Thomas Monjalon To: "Richardson, Bruce" , "Ma, WenwuX" Cc: dev@dpdk.org, "Burakov, Anatoly" , "Hu, Jiayu" , "Wang, Yinan" , "He, Xingguang" , "Ling, WeiX" Subject: Re: [PATCH v3] examples/multi_process: reconfigure port when rss or csum isn't supported Date: Tue, 08 Mar 2022 14:22:02 +0100 Message-ID: <3942958.QZUTf85G27@thomas> In-Reply-To: References: <20220217151755.442306-1-wenwux.ma@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 28/02/2022 08:55, Ling, WeiX: > From: Bruce Richardson > > On Tue, Feb 22, 2022 at 10:51:27AM +0000, Wenwu Ma wrote: > > > The default values of rx mq_mode and rx offloads for port will cause > > > symmetric_mp startup failure if the port do not support rss or csum. > > > This Patch make the app to reconfigure the NIC without them. Only quit > > > the app if the second reconfiguration fails. > > > > > > Signed-off-by: Wenwu Ma > > > --- > > > > While I am surprised to see different error codes for different essentially the > > same issue - lack of HW support, that is a separate problem to the one this is > > addressing. Given this is just a sample app, I think this approach is fine for > > configuring things - keeping things simple for the user. > > > > Acked-by: Bruce Richardson > > > Tested-by: Wei Ling Applied with title "examples/multi_process: make RSS and checksum optional"