From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A97514611D; Wed, 29 Jan 2025 17:13:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4474B402AE; Wed, 29 Jan 2025 17:13:58 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A073440274 for ; Wed, 29 Jan 2025 17:13:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738167235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=n7NUx87QGlfcOldnn7y4cCt/AH+n03X/m3s+1xwvHW8=; b=ch0SU7T5wCOClqiCoOmU2AM4NEAWNmknoDVjfFzyx2G5ODVoOw1mzelOMFe4yfR8u87z76 8X+lCdPIaQ1LCjihQqICyP+qVKtRkeFJhH4pFFY1O61Jayx+nBY8jq/f8+vIIMfgP6NE24 trh4jqiaSsBN+Zo7+4VQjnML7mcwE7o= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-98-s_b93YLFMveeQu-zfwlTEQ-1; Wed, 29 Jan 2025 11:13:50 -0500 X-MC-Unique: s_b93YLFMveeQu-zfwlTEQ-1 X-Mimecast-MFC-AGG-ID: s_b93YLFMveeQu-zfwlTEQ Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ACC7918009FD; Wed, 29 Jan 2025 16:13:44 +0000 (UTC) Received: from [10.39.208.40] (unknown [10.39.208.40]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0DD2019560A3; Wed, 29 Jan 2025 16:13:41 +0000 (UTC) Message-ID: <394449d9-3511-436b-a397-ee4608e71317@redhat.com> Date: Wed, 29 Jan 2025 17:13:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v2 2/2] examples/vhost_crypto: add asymmetric support To: Gowrishankar Muthukrishnan , dev@dpdk.org, Akhil Goyal , Chenbo Xia , Fan Zhang , Jay Zhou Cc: jerinj@marvell.com, anoobj@marvell.com References: <5126c7ca239ffc9f64d32c6cfa8b74308bc04125.1736270125.git.gmuthukrishn@marvell.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= xsFNBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABzSxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPsLBeAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASrOwU0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAHC wV8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= In-Reply-To: <5126c7ca239ffc9f64d32c6cfa8b74308bc04125.1736270125.git.gmuthukrishn@marvell.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kLKTGYlNM0O0Qc8cTWPMRpIUWCwIAxM8WAufLq8bi0o_1738167228 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/7/25 7:02 PM, Gowrishankar Muthukrishnan wrote: > Add symmetric support. > > Signed-off-by: Gowrishankar Muthukrishnan > --- > examples/vhost_crypto/main.c | 54 ++++++++++++++++++++++++++---------- > 1 file changed, 40 insertions(+), 14 deletions(-) > > diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c > index 558c09a60f..8bdfc40c4b 100644 > --- a/examples/vhost_crypto/main.c > +++ b/examples/vhost_crypto/main.c > @@ -59,6 +59,7 @@ struct vhost_crypto_options { > uint32_t nb_los; > uint32_t zero_copy; > uint32_t guest_polling; > + bool asymmetric_crypto; > } options; > > enum { > @@ -70,6 +71,8 @@ enum { > OPT_ZERO_COPY_NUM, > #define OPT_POLLING "guest-polling" > OPT_POLLING_NUM, > +#define OPT_ASYM "asymmetric-crypto" > + OPT_ASYM_NUM, > }; > > #define NB_SOCKET_FIELDS (2) > @@ -202,9 +205,10 @@ vhost_crypto_usage(const char *prgname) > " --%s ,SOCKET-FILE-PATH\n" > " --%s (lcore,cdev_id,queue_id)[,(lcore,cdev_id,queue_id)]\n" > " --%s: zero copy\n" > - " --%s: guest polling\n", > + " --%s: guest polling\n" > + " --%s: asymmetric crypto\n", > prgname, OPT_SOCKET_FILE, OPT_CONFIG, > - OPT_ZERO_COPY, OPT_POLLING); > + OPT_ZERO_COPY, OPT_POLLING, OPT_ASYM); > } > > static int > @@ -223,6 +227,8 @@ vhost_crypto_parse_args(int argc, char **argv) > NULL, OPT_ZERO_COPY_NUM}, > {OPT_POLLING, no_argument, > NULL, OPT_POLLING_NUM}, > + {OPT_ASYM, no_argument, > + NULL, OPT_ASYM_NUM}, > {NULL, 0, 0, 0} > }; > > @@ -262,6 +268,10 @@ vhost_crypto_parse_args(int argc, char **argv) > options.guest_polling = 1; > break; > > + case OPT_ASYM_NUM: > + options.asymmetric_crypto = true; > + break; > + > default: > vhost_crypto_usage(prgname); > return -EINVAL; > @@ -362,8 +372,8 @@ destroy_device(int vid) > } > > static const struct rte_vhost_device_ops virtio_crypto_device_ops = { > - .new_device = new_device, > - .destroy_device = destroy_device, > + .new_connection = new_device, > + .destroy_connection = destroy_device, It may be worth explaining in the commit message why you are moving from new_device to new_connection. > }; > > static int > @@ -376,6 +386,7 @@ vhost_crypto_worker(void *arg) > int callfds[VIRTIO_CRYPTO_MAX_NUM_BURST_VQS]; > uint32_t lcore_id = rte_lcore_id(); > uint32_t burst_size = MAX_PKT_BURST; > + enum rte_crypto_op_type cop_type; > uint32_t i, j, k; > uint32_t to_fetch, fetched; > > @@ -383,9 +394,13 @@ vhost_crypto_worker(void *arg) > > RTE_LOG(INFO, USER1, "Processing on Core %u started\n", lcore_id); > > + cop_type = RTE_CRYPTO_OP_TYPE_SYMMETRIC; > + if (options.asymmetric_crypto) > + cop_type = RTE_CRYPTO_OP_TYPE_ASYMMETRIC; > + > for (i = 0; i < NB_VIRTIO_QUEUES; i++) { > if (rte_crypto_op_bulk_alloc(info->cop_pool, > - RTE_CRYPTO_OP_TYPE_SYMMETRIC, ops[i], > + cop_type, ops[i], > burst_size) < burst_size) { > RTE_LOG(ERR, USER1, "Failed to alloc cops\n"); > ret = -1; > @@ -411,12 +426,11 @@ vhost_crypto_worker(void *arg) > fetched); > if (unlikely(rte_crypto_op_bulk_alloc( > info->cop_pool, > - RTE_CRYPTO_OP_TYPE_SYMMETRIC, > + cop_type, > ops[j], fetched) < fetched)) { > RTE_LOG(ERR, USER1, "Failed realloc\n"); > return -1; > } > - > fetched = rte_cryptodev_dequeue_burst( > info->cid, info->qid, > ops_deq[j], RTE_MIN(burst_size, > @@ -477,6 +491,7 @@ main(int argc, char *argv[]) > struct rte_cryptodev_qp_conf qp_conf; > struct rte_cryptodev_config config; > struct rte_cryptodev_info dev_info; > + enum rte_crypto_op_type cop_type; > char name[128]; > uint32_t i, j, lcore; > int ret; > @@ -539,12 +554,21 @@ main(int argc, char *argv[]) > goto error_exit; > } > > - snprintf(name, 127, "SESS_POOL_%u", lo->lcore_id); > - info->sess_pool = rte_cryptodev_sym_session_pool_create(name, > - SESSION_MAP_ENTRIES, > - rte_cryptodev_sym_get_private_session_size( > - info->cid), 0, 0, > - rte_lcore_to_socket_id(lo->lcore_id)); > + if (!options.asymmetric_crypto) { > + snprintf(name, 127, "SYM_SESS_POOL_%u", lo->lcore_id); > + info->sess_pool = rte_cryptodev_sym_session_pool_create(name, > + SESSION_MAP_ENTRIES, > + rte_cryptodev_sym_get_private_session_size( > + info->cid), 0, 0, > + rte_lcore_to_socket_id(lo->lcore_id)); > + cop_type = RTE_CRYPTO_OP_TYPE_SYMMETRIC; > + } else { > + snprintf(name, 127, "ASYM_SESS_POOL_%u", lo->lcore_id); > + info->sess_pool = rte_cryptodev_asym_session_pool_create(name, > + SESSION_MAP_ENTRIES, 0, 64, > + rte_lcore_to_socket_id(lo->lcore_id)); > + cop_type = RTE_CRYPTO_OP_TYPE_ASYMMETRIC; > + } > > if (!info->sess_pool) { > RTE_LOG(ERR, USER1, "Failed to create mempool"); > @@ -553,7 +577,7 @@ main(int argc, char *argv[]) > > snprintf(name, 127, "COPPOOL_%u", lo->lcore_id); > info->cop_pool = rte_crypto_op_pool_create(name, > - RTE_CRYPTO_OP_TYPE_SYMMETRIC, NB_MEMPOOL_OBJS, > + cop_type, NB_MEMPOOL_OBJS, > NB_CACHE_OBJS, VHOST_CRYPTO_MAX_IV_LEN, > rte_lcore_to_socket_id(lo->lcore_id)); > > @@ -567,6 +591,8 @@ main(int argc, char *argv[]) > > qp_conf.nb_descriptors = NB_CRYPTO_DESCRIPTORS; > qp_conf.mp_session = info->sess_pool; > + if (options.asymmetric_crypto) > + qp_conf.mp_session = NULL; > > for (j = 0; j < dev_info.max_nb_queue_pairs; j++) { > ret = rte_cryptodev_queue_pair_setup(info->cid, j,