From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90307A04DC; Mon, 19 Oct 2020 13:45:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DBDE3C970; Mon, 19 Oct 2020 13:45:19 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 597FCC92A for ; Mon, 19 Oct 2020 13:45:17 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 0670F5C01A5; Mon, 19 Oct 2020 07:45:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 19 Oct 2020 07:45:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 1SvjvASs7VJnhH4Ll4wb+FGSasygYOOK/lb/PxiNraU=; b=f0GXkeGjzYXTh0Yn bzTYz48FraViR13HHXVDTnHqKsk3HuwwsQ2db7wnVs7QxRLqK/oA25AKXufPhM32 veZILHgylhxKccz388MRGQOb79uuP0hxsmOy85zV0Nq/nhty7u3Xdbtx3OCzRyxb E4CHzCdEnk2vsire88c7RHPjTFkzXI49X+LSZx2WeP6f3tVn9/6pbEzQiydpnUl3 EbmfZ/YxF/Sjk8yHe0ropsI02GHsgvvZI/C9xmsRnTEkW/0iaaHAPIb+5yZ5YSg3 rXedz+bAhH3/3FCUCTZGRkJgi7/QFt5EVuXgXu+ovGrHjlgR5xcMWO3Dymm92rMr yCWeLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=1SvjvASs7VJnhH4Ll4wb+FGSasygYOOK/lb/PxiNr aU=; b=qN5wT0AtQoZ8PoUTzfdcKj0V5nTY2r4zDcaY422iL5wDcFZTBM7Ns/Bl6 SrNgJB6Yy0Gl8owg7+22KfQjiRGKsQiQiMUwBIxyN7OBdAcfXaIheGscIDDLlkRX 79DffiARseMiiHwr+RsFIyBMCUhiLw25bBU3tGCgcVIIvsUAhtMcX/ovjITV6ibq E8hp580fiOaikuzd5wvZimq+tiST9c+lJbdQT7DCb1GuiYlfjslp7xX0TPCBeoch RiVXWb3Go1FoL0moEfhTSZ2poVPRKhgRDBoGpxoz4BPI8eCGjd7IvTxThV252Yer 9o4y6H24tGb3OGqoAAry1XqC9g8+Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjedugdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 580BD306467E; Mon, 19 Oct 2020 07:45:11 -0400 (EDT) From: Thomas Monjalon To: Gagandeep Singh Cc: dev@dpdk.org, nipun.gupta@nxp.com, hemant.agrawal@nxp.com, akhil.goyal@nxp.com, bruce.richardson@intel.com, mdr@ashroe.eu Date: Mon, 19 Oct 2020 13:45:09 +0200 Message-ID: <3949727.8Yj2jQpKuY@thomas> In-Reply-To: <1602755228-25535-2-git-send-email-g.singh@nxp.com> References: <1599470764-30569-1-git-send-email-g.singh@nxp.com> <1602755228-25535-1-git-send-email-g.singh@nxp.com> <1602755228-25535-2-git-send-email-g.singh@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/7] raw/dpaa2_qdma: change DPAA2 QDMA APIs to rawdev ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/10/2020 11:47, Gagandeep Singh: > dpaa2_qdma was partially using direct pmd APIs. > This patch changes that and adapt the driver to use > more of the rawdev APIs > > Signed-off-by: Gagandeep Singh > --- > drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 339 ++++++++++---------- > drivers/raw/dpaa2_qdma/dpaa2_qdma.h | 3 +- > drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h | 207 ++---------- > 3 files changed, 195 insertions(+), 354 deletions(-) You missed removing all the symbols from the .map. Note also that it is an unannounced API breakage. I take the decision to merge it anyway. We will have to be stricter next time. Applied