From: Thomas Monjalon <thomas@monjalon.net>
To: "Guo, Jia" <jia.guo@intel.com>
Cc: ferruh.yigit@intel.com, dev@dpdk.org, jingjing.wu@intel.com,
jianfeng.tan@intel.com
Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix uevent montior issue
Date: Mon, 12 Feb 2018 10:46:56 +0100 [thread overview]
Message-ID: <3951509.LRgmqiM9ue@xps> (raw)
In-Reply-To: <899b1116-cf19-249e-cc55-8993ef7729e6@intel.com>
12/02/2018 09:28, Guo, Jia:
>
> On 2/9/2018 6:01 AM, Thomas Monjalon wrote:
> > 30/01/2018 11:01, Jeff Guo:
> >> udev could not detect remove and add event of device when hotplug in
> >> and out devices, that related with the fix about using pointer of
> >> rte_uio_pci_dev as dev_id instead of uio_device for irq device handler,
> >> that would result igb uio irq failure when kernel version after than 3.17.
> >> so this patch correct it by use kernel version check before handle the
> >> pci interrupt.
> >>
> >> Fixes: 6b9ed026a870 ("igb_uio: fix build with kernel <= 3.17")
> >> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> >> ---
> >> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 17, 0)
> >> struct rte_uio_pci_dev *udev = (struct rte_uio_pci_dev *)dev_id;
> >> struct uio_info *info = &udev->info;
> >> -
> >> +#else
> >> + struct uio_device *idev = (struct uio_device *)dev_id;
> >> + struct uio_info *info = idev->info;
> >> + struct rte_uio_pci_dev *udev = info->priv;
> >> +#endif
> > Can we avoid checking Linux version number?
> > This method won't work with kernel backports.
> i don't think that is a bug rather than a kernel feature parameter
> change , so i am not sure if it will definitely a chance exist for the
> kernel backport fix for that.
Features are also backported in some kernels.
next prev parent reply other threads:[~2018-02-12 9:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 10:01 Jeff Guo
2018-01-31 2:15 ` Wu, Jingjing
2018-02-08 22:01 ` Thomas Monjalon
2018-02-12 8:28 ` Guo, Jia
2018-02-12 9:46 ` Thomas Monjalon [this message]
2018-02-13 9:32 ` Ferruh Yigit
2018-02-27 6:17 ` Guo, Jia
2018-02-27 7:20 ` [dpdk-dev] [PATCH V2] " Jeff Guo
2018-03-26 18:28 ` Ferruh Yigit
2018-03-27 7:46 ` Guo, Jia
2018-03-27 17:10 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2018-01-30 9:55 [dpdk-dev] [PATCH] " Jeff Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3951509.LRgmqiM9ue@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jia.guo@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).