From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org, byron.marohn@intel.com
Subject: Re: [dpdk-dev] [PATCH] app/test: fix overflow in EFD test
Date: Mon, 30 Jan 2017 17:14:49 +0100 [thread overview]
Message-ID: <3954309.lYGbWXjxrN@xps13> (raw)
In-Reply-To: <1485343758-179761-1-git-send-email-pablo.de.lara.guarch@intel.com>
2017-01-25 11:29, Pablo de Lara:
> When RTE_EFD_VALUE_NUM_BITS is 32, there was a compilation issue
> because of an overflow:
>
> app/test/test_efd.c:157:55: error: overflow in expression;
> result is 2147483647 with type 'int' [-Werror,-Winteger-overflow]
> data[0] = mrand48() & ((1 << RTE_EFD_VALUE_NUM_BITS) - 1);
>
> This commit fixes the issue by using a setting a different
> macro VALUE_BITMASK with a conditional
>
> Fixes: 0e925aef2779 ("app/test: add EFD functional and perf tests")
>
> Reported-by: Yong Liu <yong.liu@intel.com>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks
prev parent reply other threads:[~2017-01-30 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 11:29 Pablo de Lara
2017-01-30 16:14 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3954309.lYGbWXjxrN@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=byron.marohn@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).