From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id ECADFA00C5;
	Sun,  5 Jul 2020 10:55:28 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 36A561DA87;
	Sun,  5 Jul 2020 10:55:28 +0200 (CEST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A28F11DA6C
 for <dev@dpdk.org>; Sun,  5 Jul 2020 10:55:26 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
 by mailout.nyi.internal (Postfix) with ESMTP id 02D355C009F;
 Sun,  5 Jul 2020 04:55:25 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute7.internal (MEProxy); Sun, 05 Jul 2020 04:55:25 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm1; bh=
 0pE9ZYNyYitldny74KceC+e1GKezFQZe5dCTZ0NMRiE=; b=LZ7R27y89lJj6p9g
 VBPMrUV6gkfDrTJNxTTa8RU9yDoKUFauTcEYALvc5uOO/47nyPnGS4t2xW5LFj57
 U/ASpHo0012DNXYp8crQfaUTuVbeBOh8s2UtEBsBNpUIgFqfBKfspVs58WeOjKTC
 tMNgpGeJZfZ4xQ0N5LzdSItxulVRlzoW+RqvJOQP04DbC/5qjsA4bRlAyYAjAb+/
 Oug0cYS2XGYNcf+VyQ2xjGGl9X8Yrm4svTWOaH3T+VzjsBIFC8IxovHC3bkp3Iqo
 KCPLiteQkybiKkaGSRrJKVM+6AqFPtufSG2WuRkvNAa/gkZeMHkfflb8xyaCt/NM
 mqdQ0Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm3; bh=0pE9ZYNyYitldny74KceC+e1GKezFQZe5dCTZ0NMR
 iE=; b=hKFHIio1qB1fLYuwjpoFifTHqEG0+IzJaE9EsHuzcH9u6u5D2CXX6WZpK
 lpV/Hxq16igEWu0fqAXXLAlHK7PJtWdFXdspjOea0WaeLh/dvVBChsY+Mtf+5Hb+
 y9JFji9MTBoOivH7zR6m8taXTm90N9sZw1YspeuC55m3hEXE9jAVT8Vza+jd7K7z
 MqKOyFabJzCbvUeVIO7GkJeb770M+ottpMS6wPW0qHq2HnobujeqlRF6gIUjJXtS
 I5yx+ixT4wNIhuTtstQ6FQJ3b6Wl/7NNHVUMxmrA3eSRuM+67oFkV10zKBwaQGKY
 Bl1LbgsHqhrLDFrivXK9Fd2ldArIA==
X-ME-Sender: <xms:fJUBX1e-kM3o8CSfR0ZmqQZsSETgg-OI2JCCnwOri2oS5epAE9I8wQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddugddutdcutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
 ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
 frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei
 iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih
 iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho
 nhdrnhgvth
X-ME-Proxy: <xmx:fJUBXzNRzcMJ2HjmF9km0l1M5BCmfjE3mPWaWYHYMX7gOfuB_wXy1A>
 <xmx:fJUBX-i8w-FYlGMBRSaZ21Qq9ZgWYW9K5z5oZ18jcILk5_J7g2-OaA>
 <xmx:fJUBX-9K05b3SQ8wSc0IgGZlFhT5_nCUsNbmjkU43D7IuzndetoCbQ>
 <xmx:fJUBX1hnFt69WD5I1IBDGwokBQz-oxMmuCC8RmqoxNxQw_EMDENYGQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 8B7E7306896E;
 Sun,  5 Jul 2020 04:55:23 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerinjacobk@gmail.com>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Jiawei Wang <jiaweiw@mellanox.com>, Ori Kam <orika@mellanox.com>,
 Slava Ovsiienko <viacheslavo@mellanox.com>, Matan Azrad <matan@mellanox.com>,
 dpdk-dev <dev@dpdk.org>, Raslan Darawsheh <rasland@mellanox.com>,
 ian.stokes@intel.com, fbl@redhat.com
Date: Sun, 05 Jul 2020 10:55:21 +0200
Message-ID: <3958339.50gt9z0IZg@thomas>
In-Reply-To: <CACZ4nhsF9hyaskBo8AnMZudvTtRFLp8fqTA19H_d0fUJ4YtAWg@mail.gmail.com>
References: <1593102379-400132-1-git-send-email-jiaweiw@mellanox.com>
 <CALBAE1N2rv0e79qAKe8Zmhssi4NOu1_7oHX63e_qpqrkphUojQ@mail.gmail.com>
 <CACZ4nhsF9hyaskBo8AnMZudvTtRFLp8fqTA19H_d0fUJ4YtAWg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for
	rte flow
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

04/07/2020 16:44, Ajit Khaparde:
> On Thu, Jul 2, 2020 at 11:40 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> > When adding overlapping API(rte_eth_mirror_rule_set()) in the same
> > library(ethdev).
> > Please depreciate the old API.
> > We should not have two separate paths for the same function in the
> > same ethdev library. It is pain for app and driver developers.
> >
> > With the above deprecation notice,
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> >
> I am fine with the proposed RTE_FLOW_ACTION_TYPE_SAMPLE. But..
> 
> When rte_eth_mirror_rule_set() is deprecated, are we going to add
> RTE_FLOW_ACTION_TYPE_MIRROR for full fledged mirror action?
> Or we are proposing to use RTE_FLOW_ACTION_TYPE_SAMPLE with
> ratio of 1 to mirror all packets, thereby doing away with the need for
> a separate RTE_FLOW_ACTION_TYPE_MIRROR?

The idea is to use RTE_FLOW_ACTION_TYPE_SAMPLE with ratio=1 for mirroring.