From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0051.outbound.protection.outlook.com [104.47.42.51]) by dpdk.org (Postfix) with ESMTP id 08E39BB06 for ; Wed, 26 Oct 2016 08:21:54 +0200 (CEST) Received: from DM2PR03CA0038.namprd03.prod.outlook.com (10.141.96.37) by CY1PR0301MB1625.namprd03.prod.outlook.com (10.162.166.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.679.12; Wed, 26 Oct 2016 06:21:52 +0000 Received: from BL2FFO11FD012.protection.gbl (2a01:111:f400:7c09::169) by DM2PR03CA0038.outlook.office365.com (2a01:111:e400:2428::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.679.12 via Frontend Transport; Wed, 26 Oct 2016 06:21:52 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD012.mail.protection.outlook.com (10.173.161.18) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.679.5 via Frontend Transport; Wed, 26 Oct 2016 06:21:51 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u9Q6LlN2002611; Tue, 25 Oct 2016 23:21:48 -0700 To: "Pattan, Reshma" References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1474000200-16705-1-git-send-email-shreyansh.jain@nxp.com> <1474000200-16705-12-git-send-email-shreyansh.jain@nxp.com> <3AEA2BF9852C6F48A459DA490692831F010BD36E@IRSMSX109.ger.corp.intel.com> From: Shreyansh Jain Message-ID: <39622c65-4cbd-4841-541f-8673e1935036@nxp.com> Date: Wed, 26 Oct 2016 11:53:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F010BD36E@IRSMSX109.ger.corp.intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131219365116440237; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(199003)(377454003)(24454002)(13464003)(189002)(6916009)(7110500001)(189998001)(305945005)(2420400007)(68736007)(65956001)(97736004)(65806001)(11100500001)(33646002)(586003)(31686004)(110136003)(626004)(15650500001)(15395725005)(92566002)(36756003)(5660300001)(104016004)(93886004)(8936002)(10710500007)(77096005)(31696002)(4326007)(105606002)(6666003)(76176999)(54356999)(64126003)(86362001)(356003)(2950100002)(65826007)(4001350100001)(83506001)(19580405001)(106466001)(7846002)(50466002)(50986999)(19580395003)(15975445007)(47776003)(81156014)(23746002)(87936001)(81166006)(85426001)(8666005)(230700001)(8676002)(2906002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB1625; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD012; 1:X5EAm08lqAU25vrVw0kWtMZBsIkI3zNNq+x5hNCS5M9DMuOpRGhZi+XlUbyNt6R/uUYDwtxvCSSuX1STSY1OFxE9+SJqfz46whE81SvGft016ZXO55hJOaBdAqwcYlkI878tfaR/f5A/Yp6dH5VFq0f0kFtOOzfi8HTDJgZmZ4E04MAIRLv9uN315vW8KrA2EjWA5+ye3/XGmlWnE7NmkApMpIzTTq5WdHoTgJLQdXFQ1aJBLzthiqfBlVVFX94kfBA27fpEseZb4HPci1w6YvQYxEkhtFZ62epw8ZKfS2T6uMx1R/fCJl9XezjX8HQuydHLaFZcr8t3t7oFmhZ6rQ+2KRE/0QZ/Hc+UdxMJsboHP5+VUv7QY6AGvkupWkHVZzMou7qL8Bt4TYC/Bk9pr1mxriytu5MWItyutx9w4q9pDpH7a3jlcMK+/9KbQpsd6BEbpb95klky9QGrwUz11kkHxUNOM2/+5B31RT88PLMnmsZLRpU0T2B2DseKmut3JhnnzkkqZCnOJxGy2oVCs+sKbaTprxH/n1VPbUO4KKWlw2ePoQBcMhlhRhYWl90RxmF+qy+11jb1aKiLzE7sAmQr+UtufikuwTSI34UNh4m4UTFEskXi0y/c6VjCozN0jgEYYjjTPFW++mrcB7y2liz6auy81fO+NTkpK9BKQxs= X-MS-Office365-Filtering-Correlation-Id: 20f5e8e8-134e-490c-eead-08d3fd685fe1 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1625; 2:YEj2cpDhrw5dr/ogbfnyqyaUYQphQSUX0bujD5CUIGeXJxqHR+4zGORkElXzqagGUXI63axoahElDckonolJzDOv5v95Wr7Tg6tqyC9IBi5Vw++IbAMEkpWeyAjoLYXgfaftA+giYy1i3+LOh4amjJvy+9jsC+PFq8DTNSADOwb0z8MKGdhrj5lDCia3qA9VCPkUVh4safAwaBRohsQToQ==; 3:OsyfwhkOQ80DQZkJ1A6dsQztUNolkfjKr1GugU3R4ZMV7wB9KKpCUtPi/UedB5wqpPoKd+lfNTEGbNiUE28Hkne88aA07q2Jztaq0RR9RdHjNQMy9iPcMnr60myrCB7+a+d9T9364DvwyhiJwQsy39cPOG+xOYZveMBJ9+o3IUip1bk12q2cHQvyW3fEJzJfYXp2OL5LXwXAHuKvrweD1/4yf/RHXsProtd+uBYSwe+su4Vr5wmWexCvFyZF9FXJ X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1625; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1625; 25:++5kKe63kfdsgFKJxfAlFAgOvfPY9UN351VxRJjzqz/X/SYw0csFRw1RryIuW1pO/A4I37YM9TvxdgBbCLpOzrZtS2tKC3n8ABY77QfFu6wcewX9VcTnpgx/aN1UIcT2r8HpNRNOWnG5d39XTNoq3KOJFkjKCjt2gjixisaoChh1o3Sha7AuV7gM+RmMd8T6lDh0Rvylw+vu7Pl7qaEkDdAuQ5X/BmptSg2S2vC0CLkLy0PGWrKQ6Qmtr9bb3x2B+5gf+gcCQF/IUMqb+fT32Nx3cdMZaaQcdBxb54ERA8NBV8YnqvaCQJFQK1x+Ja9M/MUWAOFjScfCn7sARZxw9ePnUWoIQDk9tt7QqHrJ2mvMzxyJWel24SdfPRqw92AiuFG4siseLalE5BepBF0q0BTL20KtVIko90bZn5ZHIyBb6uYfbqi529XUPr/DTa4gm61C3+eP3mhVVwzRW6JIVhSPuW4U/1A7Ly7eVBTPlxrzCuCL/iVTwD+PxOE8mVlLaYhjZxEjpWYYtXZ2t89aintNi4HiGAhi3HFR5ruJuSzA9bbVu5+KgG8t+4nC4hkL1Hri2+WlkWFUZKJQHWb7Li9xZKrCD3N/mc+kgsnJuUgnXFDzB5oXBSbv7jqb5Q6jUhhMNLl/TbObIC/LDwUZ1li0oA1tMyuJVNEjQ7bbQh2UukHtIyuuvFozOLGDff7cGd7/6PNM6FYeMZ6TNvAxDoPujTTIyeicMoknSTvs7rxtJAfMasS0hZ/FsxQfyP1sjguFXdntsRW3yTK7bDB1aeu9mv/1rCKSqrkAQn/66LtfaOKKiJ+Lm16UfIJJjMYhPzPcoUjzxepRGSWJ99IPmxo/a0UG8SFCPdn7Wj55tzeZ9KMd1s8tsfaKd9Sj54Pp X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1625; 31:ae2Yic8b/9Xn5QKfUnO3G4ZjOynueuQoyq+YCEx0HUg7xPcNCpt+rzf1mKpHvy6zrTR0o23YPWBrz9KgWv+Hq0pDyP2CPzkDFXmY6Rlup91Xcld/25xZOxvnR+Gd/bnEu0OhuaMm0GiN+EndFvDb2bvFZqiu+XvgRAXUUCzaO9Jpo+wdKP9OCydsJMwwZ252l6FBdthJRwyetbUQU95fX4N5L8IPtPxKS4XBjYSlAQ3MGs74nZlILB+nKSwqzMaxVK57sSkVauMwv5cRxwoarA==; 4:L4Q/qw2Tby2goRoMmNSCfD7FAHbpg4EUUJQEL2DY8N0qQXPXYgEF0acIYaJ3sqGkYfSueZUuvhF4YX/rWkTfd91o+ky5vSXoEPT/w4gIxmyar1Ntr44Jw4E7WdPLmvTHt5r0JSqUyUbqPx/0tP/N0fiir4ZWO3uZrGliIGyjJUsLkBbBYOmO8XwDa5IrSZdwg9iZbBcBmLD0wBEywhjKeKQsOZa3QjVOuiiwYorG+Y30u2KnF9XVvDsmg1PNz5MJNhKZs9h0/i10etOb5PGXFa8UrZQsNwC8x4wvOKzD6E5hVGJzCTo5I2Xup7NIOP+JyL/vdUvGz1rgDurfbjMUeOTJb7EVuh8rXqFzaCJ9LZi5I2grlJNJY5OoYleJvpSOHbza49R24Qqc/hjxXJQXnaHLeTo1utbrxN2nicyNZuSv27j+4c4YVRjN4OTBusYy6/VlG03xVqAUUfi9WfunYgHMPFOxoq+pfKp1CFIKOHcbUlSWPE9gCteOOHAwKNtM5WsFzUo/Ph7CH3I55NXjHOlFm4TAodDwPoZC0KZhkpZxWaw0Sl8onbc4gPxr8CJP X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13024025)(13018025)(13015025)(13023025)(13017025)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:CY1PR0301MB1625; BCL:0; PCL:0; RULEID:(400006); SRVR:CY1PR0301MB1625; X-Forefront-PRVS: 0107098B6C X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY1PR0301MB1625; 23:pYaQOnEME0DlwmB6On9WlAuiEuopbVfz6/c?= =?Windows-1252?Q?zQ4g/0CzWEaCcNSy9vta05WiMgDfzSdd7J8mOxNImIbjgrHq0kiXiY2X?= =?Windows-1252?Q?mwqieSsGXaU7AHxqfXGQxEqF+euZMh0y8RJXbsHyzP6sAkfZzU729sDA?= =?Windows-1252?Q?h3zW8CtXAAstCuAKw6Xs4Y21Wj604Ad8hT0NHgJVJk9QUMuC3RbwWGem?= =?Windows-1252?Q?PEKDUx6hf9rHxyTaJ8fsusrIG+iOimjuss5/P6riVU4mb9QphinxRTiD?= =?Windows-1252?Q?XyHDQ1y5abs1qOLCluUWqpMwJWipmEqiEw0qUy0BuOkwHhJlwGQc+x7G?= =?Windows-1252?Q?+KJ8JmYYVXNE/Ne+dFkegBt+ncN243FbK3J/AcvyVHJanJa8nMDJoUqw?= =?Windows-1252?Q?Y+zwwE2bQo2QhxEg92PPIb5vVHBKk5AEjXh0F5EpBD7cBpP/ehlFVvnX?= =?Windows-1252?Q?b21g7y3MM6aCbHHRR8erp+8s96s+o9RcmcnARC9olwbjFHGatf2pGRth?= =?Windows-1252?Q?7XC/hw4B2DPEVXSHpHWCLFtKZSngUt6Dsjt3ZkHSC/7p+KCWXB/AVV/c?= =?Windows-1252?Q?mOcPzSnilKmGDL73QNdaHtHO1dVgqpoiIsOnYYZvnoWb/tXkROKBGqAe?= =?Windows-1252?Q?u77CaLkTnUUBjrszWk4KGDUKcBx99/c23qOq1Y+p97iaUMthMXx/zZwg?= =?Windows-1252?Q?zyGNFTRWls3iJm4MaEZWPvHQO3Mvmij5iXGYQxXB1Vve8UOPek6kySgk?= =?Windows-1252?Q?ej381Y1Ti87bMA6yRXDQfjD/5yAMup+fbVXh7HNNWU61QeG72wKgkTKz?= =?Windows-1252?Q?bg6OD3E8X5Co6W+MDFp+h1RU2gVTSiYDkYs2PX5CQ62ofOY9BV8o7V97?= =?Windows-1252?Q?f1fjqHXQtJI1CPSUw34WHQoq8inIKF4yn1iK/B/QGkz4pgYStQnygVht?= =?Windows-1252?Q?4yuUH27Pi84JaeJ+X0DmeunxsTJMOGb7IGoihdcmmSVVUdeb1NSxzFyP?= =?Windows-1252?Q?DqhqGAdiYnXp/CmJ7AZ/lR5yUcxMYxX5BHg2qYFWrbQiGp53agD6Tyla?= =?Windows-1252?Q?U66fuOcI+gmNz4nigAKY0FBJB08fYpE4drkOi8EJbQQ5/2C8eNEhmjRy?= =?Windows-1252?Q?FCcWa4DhFNS3B5B+Xi3kLoemQSsEdSNZoZFBOu3IFdNsyBoW9i0k7j6C?= =?Windows-1252?Q?Cs6Et+wVMVUxx6B8WyuXo0eM4NVamGLELBryvkmLkgblXulyzSvRbNtS?= =?Windows-1252?Q?nrz2nGmR4BCd4QderQ5X0drI/G5QDh2bofJvlAV9Xi1U03ms13/Xjd8z?= =?Windows-1252?Q?4RFC0pPLrq2e7EydbHB6s5DTUW51WMxvWyqczyXyLjoQGR0yoAFSsDSt?= =?Windows-1252?Q?/aetvvNeo9mEB1RU5hbang9PM7bcwa107Ya/4cp4Opf53hVOhF83iQj9?= =?Windows-1252?Q?Y+fxaDVW8TVsTq/Q1ZIK/9DLjRkMlePMIa7TH47Zzsii932+XqUlgRtm?= =?Windows-1252?Q?dSbhhu6Lwe2JWJsNC6bYrHDdhgY54IoVKaHlM0ZO/yuV2Umcb+d3VUEQ?= =?Windows-1252?Q?JB5c5rf1YcqyKOhh6Lt1eKs8DuXHoMt+Lp/HZZx48R9Tb7iJvWl7MDpL?= =?Windows-1252?Q?wUYlFiBBF2pWESV/gsG6OW8DjKmm/q2Bwuof8ItoY0On4/79Kyv7qa/M?= =?Windows-1252?Q?ntcGjDwgFYxHsc70RUIEtDqXkEqMGjstOx5ywL7W5KX3i+0PpHxBJTop?= =?Windows-1252?Q?0GAXEBvwTUeC9ATI5Ig=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1625; 6:rTyma5LkfpJx5IZTsmN52B6zXFAHlMbZEGmR/7Ni0WR+G1owxxhEL2MdaRJwHttGCpg8e1XqsB64yXJG1eOX2EJL4DSVvHLV24KEm3agqEDdGkoTvZRor13aaKLgODLTP2b6vEo+XLITvF2fpYGfKBwz2xYyvkr1MjtXoKgBpGELqPIL9/cqTLfi8JLAq4ysAbVZ91PJW61SknTXt2QjYwETvSPjRpmBvRwHAWAxp3OecQQN0HQvPbfFGASfWmVtI70gQPrDV0TIu2Nl62wb7whomTTd9dhv9j4rphhmciFu8hyeisZ8hpdWw7WH1Xqd; 5:ZaAFwXeClawVkvBupwO+MJxsAKnOBWujHvQA6Ztt+oaGgv/xV8WxYTC9dVxE56NSaHnBLfXOEH6X02s+zDeAv9vymOF155DA97SoiNNkMZtVwpO3Q104IrveY58pvQYSp0cLpyqu9Cvm0Sh5jdKpbExzuIZiXFS49MT15GKNGY/k5iIOaqogYPM941E0mGHq; 24:YqwIAPqhnHiU+yLX3hzqe1zemkc3P61IWRmVXhe6YSJ0E/6uV6nRw86LJxQBj8vhR5ciJbpgPZVgaPXFb67LpmcRRcxIi7MEodyogx2gbv4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1625; 7:lmksXeUz2DMNPeQYtGpBkz6ho76RNCYJ4r8oUCcBr0AGl9k/wZeqbfDd56X9Fxm5EffqZFsKEgvfcJ0aPaCh/BgjlQUt7Aq0Q2LYyv609BmXFFDTZs672KwoMMN3Tlhxb2jJfAqpjPCRw2bGmNKyWuGp0c5FezMVRJINVFiix7Nj8YPzutBCSy9ETTGP8S7yGUv3nVnII93B+b5JtZ6DMj8vlLp55mX+4LySQG99hD1LORfOhsIMa2gHwfjnsz+Cd5XAQl70lbgSeZQ+HHyK8dO348yfGeNmyDO4gv3A8jFf6LkU+i9o32eaAT0Bw5EyCoPiSoPuVeEivYINy3kYf1swoDfl5Mz1Lv2P+VF1YgE= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2016 06:21:51.4256 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1625 Cc: "dev@dpdk.org" , Thomas Monjalon , "viktorin@rehivetech.com" Subject: Re: [dpdk-dev] [PATCH v10 11/25] eal/pci: helpers for device name parsing/update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Oct 2016 06:21:54 -0000 Hello Reshma, On Tuesday 25 October 2016 09:19 PM, Pattan, Reshma wrote: > Hi Shreyansh, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shreyansh Jain >> Sent: Friday, September 16, 2016 5:30 AM >> To: dev@dpdk.org >> Cc: viktorin@rehivetech.com; David Marchand ; >> hemant.agrawal@nxp.com; Thomas Monjalon >> ; Shreyansh Jain >> Subject: [dpdk-dev] [PATCH v10 11/25] eal/pci: helpers for device name >> parsing/update >> >> From: David Marchand >> >> - Move rte_eth_dev_create_unique_device_name() from ether/rte_ethdev.c to >> common/include/rte_pci.h as rte_eal_pci_device_name(). Being a common >> method, can be used across crypto/net PCI PMDs. >> - Remove crypto specific routine and fallback to common name function. >> - Introduce a eal private Update function for PCI device naming. >> >> Signed-off-by: David Marchand >> [Shreyansh: Merge crypto/pci helper patches] >> Signed-off-by: Shreyansh Jain >> --- >> lib/librte_cryptodev/rte_cryptodev.c | 27 +++--------------- >> lib/librte_eal/bsdapp/eal/eal_pci.c | 49 >> +++++++++++++++++++++++++++++++++ >> lib/librte_eal/common/eal_private.h | 13 +++++++++ >> lib/librte_eal/common/include/rte_pci.h | 24 ++++++++++++++++ >> lib/librte_eal/linuxapp/eal/eal_pci.c | 13 +++++++++ >> lib/librte_ether/rte_ethdev.c | 24 +++------------- >> 6 files changed, 107 insertions(+), 43 deletions(-) >> >> diff --git a/lib/librte_cryptodev/rte_cryptodev.c >> b/lib/librte_cryptodev/rte_cryptodev.c >> index 2a3b649..c81e366 100644 >> --- a/lib/librte_cryptodev/rte_cryptodev.c >> +++ b/lib/librte_cryptodev/rte_cryptodev.c >> @@ -365,23 +365,6 @@ rte_cryptodev_pmd_allocate(const char *name, int >> socket_id) >> return cryptodev; >> } >> >> * >> * This function is private to EAL. >> diff --git a/lib/librte_eal/common/include/rte_pci.h >> b/lib/librte_eal/common/include/rte_pci.h >> index cf81898..e1f695f 100644 >> --- a/lib/librte_eal/common/include/rte_pci.h >> +++ b/lib/librte_eal/common/include/rte_pci.h >> @@ -82,6 +82,7 @@ extern "C" { >> /** Formatting string for PCI device identifier: Ex: 0000:00:01.0 */ #define >> PCI_PRI_FMT "%.4" PRIx16 ":%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8 >> +#define PCI_PRI_STR_SIZE sizeof("XXXX:XX:XX.X") >> >> /** Short formatting string, without domain, for PCI device: Ex: 00:01.0 */ >> #define PCI_SHORT_PRI_FMT "%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8 @@ -308,6 >> >> +static inline void >> +rte_eal_pci_device_name(const struct rte_pci_addr *addr, >> + char *output, size_t size) >> +{ >> + RTE_VERIFY(size >= PCI_PRI_STR_SIZE); >> + RTE_VERIFY(snprintf(output, size, PCI_PRI_FMT, >> + addr->domain, addr->bus, >> + addr->devid, addr->function) >= 0); } >> + >> >> +int >> +pci_update_device(const struct rte_pci_addr *addr) { >> + char filename[PATH_MAX]; >> + >> + snprintf(filename, sizeof(filename), "%s/" PCI_PRI_FMT, >> + pci_get_sysfs_path(), addr->domain, addr->bus, addr->devid, >> + addr->function); >> + >> + return pci_scan_one(filename, addr->domain, addr->bus, addr->devid, >> + addr->function); >> +} >> + > > > Earlier device names were created in the format "bus:deviceid.function" as per the below ethdev API. > Now after above new eal API the name format is "domain:bus:deviceid.func" was that intentional and why is that so. Yes, this is intentional. It is to bring the naming in sync with the device name being used for scanning on the bus (/sys/bus/pci/devices/AAAA:BB:CC.D/). Also, it was proposed in a separate patch [1] but merged in this series. [1] http://dpdk.org/ml/archives/dev/2016-July/044614.html (Just as a note: I am not the original author of this patch but above is what I understood and acked it). > >> -static int >> -rte_eth_dev_create_unique_device_name(char *name, size_t size, >> - struct rte_pci_device *pci_dev) >> -{ >> - int ret; >> - >> - ret = snprintf(name, size, "%d:%d.%d", >> - pci_dev->addr.bus, pci_dev->addr.devid, >> - pci_dev->addr.function); >> - if (ret < 0) >> - return ret; >> - return 0; >> -} >> - > - Shreyansh