From: Thomas Monjalon <firstname.lastname@example.org> To: David Marchand <email@example.com> Cc: dev <firstname.lastname@example.org>, "Burakov, Anatoly" <email@example.com>, Bruce Richardson <firstname.lastname@example.org>, Ray Kinsella <email@example.com>, "Traynor, Kevin" <firstname.lastname@example.org>, Stephen Hemminger <email@example.com> Subject: Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal Date: Mon, 05 Aug 2019 17:13:19 +0200 Message-ID: <3963110.nb0tCvxbkm@xps> (raw) In-Reply-To: <CAJFAV8w3H9=v53NJ4i1c3wyLQHzc6h9itPaP5HcTHqaXHmnaMg@mail.gmail.com> 05/08/2019 17:05, David Marchand: > On Mon, Aug 5, 2019 at 4:39 PM Thomas Monjalon <firstname.lastname@example.org> wrote: > > 02/08/2019 15:29, David Marchand: > > > This symbol has been deprecated for quite some time. > > > Let's drop it in the next release. > > > --- > > > --- a/doc/guides/rel_notes/deprecation.rst > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > +* eal: The ``rte_malloc_virt2phy`` function has been deprecated and replaced > > > + by ``rte_malloc_virt2iova`` since v17.11 and will be removed in DPDK 19.11. > > > > For this patch and another one about removing rte_cpu_check_supported(), > > I have a general comment on the date of removal. > > > > As was stated recently in the contribution guide: > > http://git.dpdk.org/dpdk/commit/?id=7abe4a24cc > > "Deprecated APIs are removed completely just after the next LTS." > > > > The idea behind this policy is to avoid removals during LTS releases, > > in order to have at least one release before X.11 LTS for end users > > to prepare replacing the usage of the removed API. > > > > Does it make sense to postpone any API removal after 19.11? > > Those symbols have been marked as deprecated for a long time. > Users had to either disable Werror or they actually migrated to the new apis. > If they chose the lazy way of not migrating to the new apis, I suspect > they forgot about it and/or they won't look at the release notes. Yes I agree. That's why they can be surprised when hitting the removal. Avoiding this removal in LTS release is one more care for the lazy users. The question: is too much caution? > I don't particularly have a problem with waiting for 20.02, those are > easy to remove anyway.
next prev parent reply index Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-02 13:29 David Marchand 2019-08-02 16:04 ` Burakov, Anatoly 2019-08-02 16:10 ` Jerin Jacob Kollanukkaran 2019-08-05 14:39 ` Thomas Monjalon 2019-08-05 15:05 ` David Marchand 2019-08-05 15:13 ` Thomas Monjalon [this message] 2019-08-12 10:42 ` Kinsella, Ray 2019-08-06 13:50 ` Andrew Rybchenko 2019-08-06 14:00 ` Ananyev, Konstantin 2019-08-08 9:32 ` [dpdk-dev] [PATCH v2] " David Marchand 2019-08-08 15:44 ` Thomas Monjalon
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3963110.nb0tCvxbkm@xps \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions Archives are clonable: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ email@example.com public-inbox-index dev Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/ public-inbox