Re: [dpdk-dev] [PATCH v2 2/3] log: add ability to match dynamic log based on shell pattern

[Thomas Monjalon <thomas@monjalon.net>]

Hi Stephen,

04/04/2018 13:34, Thomas Monjalon:
> 23/02/2018 22:17, Stephen Hemminger:
> > Regular expressions are not the best way to match a hierarchical
> > pattern like dynamic log levels. And the separator for dynamic
> > log levels is period which is the regex wildcard character.
> > 
> > A better solution is to use filename matching 'globbing' so
> > that log levels match like file paths. For compatibility,
> > use colon to separate pattern match style arguments. For
> > example:
> > 	--log-level 'pmd.net.virtio.*:debug'
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > +int
> > +rte_log_set_level_match(const char *pattern, uint32_t level)
> [...]
> > +/* set level by regular expression (using pattern match is preferred) */
> >  int
> >  rte_log_set_level_regexp(const char *pattern, uint32_t level)
> 
> I think "pattern" is more appropriate than "match" to differentiate
> from "regexp". So I suggest this function name:
> 	rte_log_set_level_pattern

Are you OK to do a v3 with this change?