From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBD4BA04B1; Wed, 23 Sep 2020 22:41:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 17B091DB36; Wed, 23 Sep 2020 22:41:34 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id A47611DB32 for ; Wed, 23 Sep 2020 22:41:32 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id D77B35803E7; Wed, 23 Sep 2020 16:41:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 23 Sep 2020 16:41:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= +S7eCg68s62EuF5ADfHqMvh+NuudFLfHQS1Gx+DjJZw=; b=nbUnia5U0yfVD7f1 etJTopi/ErasLUIteC2aX6G6qKxa9+k/Zpysr4y7+T5rHft1hj9+rZPEdisHDUmc H68HqywExh/jjhySrk5rI9PtK0lLuBWhVzSHe6VYs7CZN+kxlHIrtCxsEssiivzX Sfh7yOX1EW5w2jxfpCyumISn6ZwGPV5XXNafDaNnk49GXVxtVL0Srg/oinrWXYOC BOwcgBbgpP8+DVUhctiQrLAMDr0FgOFd9ZK8NkdqJAR5bom/L6pcHGQHNzBortDR 8GVpA02zOgIJ+jszg6ylQDm7j+Tiw2Q//Xw72+7kwjJRgYnRy32wAPuHvYsW6FqD 1QATwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=+S7eCg68s62EuF5ADfHqMvh+NuudFLfHQS1Gx+DjJ Zw=; b=dFEV1jZPnZvZtKa3DsU3cPAHXTKOXuSEk+ixGNnJW+kDzxwv8+7v4kpl/ szWcINsprCKwNaXysDGLlJqM7l4bixpnMjBZo8Gx5d/wg3hM2+bEkyFFg98Zg3st 9H8JjZu81KK1B2iMyNEOr3oIjGqChbmsaQZIoy5pK++dskOF1VqkYivWX/2IEaM+ H67IybGB+WsXrgIX09xBlVk/M8NHWPgKqeRKtbmJTRr+w5DZ14SqjDNlmT4ujmOV nmUZOI5Rq/M+O/yCPCbm6MQ5FZXzg87H9k+JKWZor7ls3rt3g4gNJOJ/ESTUlM9R AvSRZ3yKrvMpREI9eUNM5ggHWCN/Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeigdduheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 55672328005D; Wed, 23 Sep 2020 16:41:20 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, arybchenko@solarflare.com, Rahul Lakkireddy , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Rasesh Mody , Shahed Shaikh , Heinrich Kuhn , Hemant Agrawal , Sachin Saxena , Gagandeep Singh , Akhil Goyal , Alfredo Cardigliano , Ray Kinsella , Neil Horman , John McNamara , Marko Kovacevic , "John W. Linville" , Ciara Loftus , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , Ajit Khaparde , Somnath Kotur , Chas Williams , "Wei Hu (Xavier)" , Wei Zhao , Jeff Guo , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Beilei Xing , Jingjing Wu , Qiming Yang , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Martin Spinler , Tetsuya Mukawa , Harman Kalra , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Bruce Richardson , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Maxime Coquelin , Chenbo Xia , Zhihong Wang , Yong Wang Date: Wed, 23 Sep 2020 22:41:19 +0200 Message-ID: <3974758.YRqNSdGFa7@thomas> In-Reply-To: References: <20200913220711.3768597-1-thomas@monjalon.net> <20200913220711.3768597-17-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 16/20] ethdev: remove old close behaviour X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/09/2020 18:44, Ferruh Yigit: > On 9/13/2020 11:07 PM, Thomas Monjalon wrote: > > * Note 3: > > The port is supposed to be in a stopped state when it is closed. > > If it is not the case, it is free to the PMD implementation > > how to react when trying to close a non-stopped port: > > either try to stop it automatically or just return an error. > > For this note, 'rte_eth_dev_close()' assumes port stopped and sets > "dev->data->dev_started = 0;" blindly. > > should we verify this, or perhaps should call 'rte_eth_dev_stop()' > within the 'rte_eth_dev_close()' to be sure. Good point. I wonder why dev_started is changed in the close. It is set in rte_eth_dev_stop(), that should be enough. But clearly it is a different issue which should be adressed separately. > Also many PMDs doesn't check primary process check in the close, which > should be fixed too, I wonder if it can be fixed in this series? You mean forbid close operation from secondary process?