* [dpdk-dev] [PATCH] mk: use ?= instead of := for RTE_DEVEL_BUILD
@ 2016-09-14 10:50 Luca Boccassi
2016-09-14 10:54 ` Christian Ehrhardt
0 siblings, 1 reply; 3+ messages in thread
From: Luca Boccassi @ 2016-09-14 10:50 UTC (permalink / raw)
To: dev; +Cc: Luca Boccassi, stable
RTE_DEVEL_BUILD is set to := y in mk/rte.vars.mk, which makes it
impossible to override via an environment variable, and forces users
to pass it inline in the make call.
Use ?= instead to have it pick up the environment variable as well.
Cc: <stable@dpdk.org>
Signed-off-by: Luca Boccassi <lboccass@brocade.com>
---
mk/rte.vars.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mk/rte.vars.mk b/mk/rte.vars.mk
index 28982a5..21ee0ca 100644
--- a/mk/rte.vars.mk
+++ b/mk/rte.vars.mk
@@ -104,7 +104,7 @@ export RTE_TOOLCHAIN
# developer build automatically enabled in a git tree
ifneq ($(wildcard $(RTE_SDK)/.git),)
-RTE_DEVEL_BUILD := y
+RTE_DEVEL_BUILD ?= y
endif
# SRCDIR is the current source directory
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: use ?= instead of := for RTE_DEVEL_BUILD
2016-09-14 10:50 [dpdk-dev] [PATCH] mk: use ?= instead of := for RTE_DEVEL_BUILD Luca Boccassi
@ 2016-09-14 10:54 ` Christian Ehrhardt
2016-09-23 16:29 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Christian Ehrhardt @ 2016-09-14 10:54 UTC (permalink / raw)
To: Luca Boccassi; +Cc: dev, stable
On Wed, Sep 14, 2016 at 12:50 PM, Luca Boccassi <lboccass@brocade.com>
wrote:
> RTE_DEVEL_BUILD is set to := y in mk/rte.vars.mk, which makes it
> impossible to override via an environment variable, and forces users
> to pass it inline in the make call.
> Use ?= instead to have it pick up the environment variable as well.
>
> Cc: <stable@dpdk.org>
> Signed-off-by: Luca Boccassi <lboccass@brocade.com>
>
Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
--
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] mk: use ?= instead of := for RTE_DEVEL_BUILD
2016-09-14 10:54 ` Christian Ehrhardt
@ 2016-09-23 16:29 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-09-23 16:29 UTC (permalink / raw)
To: Luca Boccassi; +Cc: stable, Christian Ehrhardt, dev
2016-09-14 12:54, Christian Ehrhardt:
> On Wed, Sep 14, 2016 at 12:50 PM, Luca Boccassi <lboccass@brocade.com>
> wrote:
>
> > RTE_DEVEL_BUILD is set to := y in mk/rte.vars.mk, which makes it
> > impossible to override via an environment variable, and forces users
> > to pass it inline in the make call.
> > Use ?= instead to have it pick up the environment variable as well.
> >
> > Cc: <stable@dpdk.org>
> > Signed-off-by: Luca Boccassi <lboccass@brocade.com>
>
> Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
I'm surprised you need to pass it via an environment variable.
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-23 16:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14 10:50 [dpdk-dev] [PATCH] mk: use ?= instead of := for RTE_DEVEL_BUILD Luca Boccassi
2016-09-14 10:54 ` Christian Ehrhardt
2016-09-23 16:29 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).