From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 9DD6D1B5C0; Thu, 25 Apr 2019 20:14:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 11:14:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,394,1549958400"; d="scan'208";a="145728272" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 25 Apr 2019 11:14:17 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 25 Apr 2019 11:14:17 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.26]) by FMSMSX112.amr.corp.intel.com ([169.254.5.167]) with mapi id 14.03.0415.000; Thu, 25 Apr 2019 11:14:16 -0700 From: "Wiles, Keith" To: "Lipiec, Herakliusz" CC: dpdk-dev , "Burakov, Anatoly" , "rasland@mellanox.com" , "stable@dpdk.org" Thread-Topic: [PATCH v4 2/2] ipc: fix tap pmd memleak Thread-Index: AQHU+2UiNvq+YIQU4EGtVZyVYfOEcKZNo/EA Date: Thu, 25 Apr 2019 18:14:16 +0000 Message-ID: <397C206A-DBA4-468C-8570-2E9E0C1C948A@intel.com> References: <20190425114324.611-1-herakliusz.lipiec@intel.com> <20190425124817.28409-1-herakliusz.lipiec@intel.com> <20190425124817.28409-3-herakliusz.lipiec@intel.com> In-Reply-To: <20190425124817.28409-3-herakliusz.lipiec@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.188.160] Content-Type: text/plain; charset="us-ascii" Content-ID: <7DD5DB77B026DB4DA288E79AD5FA928E@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/2] ipc: fix tap pmd memleak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Apr 2019 18:14:19 -0000 > On Apr 25, 2019, at 7:48 AM, Lipiec, Herakliusz wrote: >=20 > When sending synchronous IPC requests, the caller must free the response > buffer if the request was successful and reply is no longer needed. > Fix the code to correctly > use the IPC API. >=20 > Bugzilla ID: 228 > Fixes: c9aa56edec8e ("net/tap: access primary process queues from seconda= ry") > Cc: rasland@mellanox.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Herakliusz Lipiec > --- > drivers/net/tap/rte_eth_tap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.= c > index 7f74b5dc9..f8a4169c5 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -2118,7 +2118,7 @@ tap_mp_attach_queues(const char *port_name, struct = rte_eth_dev *dev) > process_private->rxq_fds[queue] =3D reply->fds[fd_iterator++]; > for (queue =3D 0; queue < reply_param->txq_count; queue++) > process_private->txq_fds[queue] =3D reply->fds[fd_iterator++]; > - > + free(reply); > return 0; > } Acked-by: Keith Wiles >=20 > --=20 > 2.17.2 >=20 Regards, Keith From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 67BA8A05D3 for ; Thu, 25 Apr 2019 20:14:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F36771B5D5; Thu, 25 Apr 2019 20:14:19 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 9DD6D1B5C0; Thu, 25 Apr 2019 20:14:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 11:14:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,394,1549958400"; d="scan'208";a="145728272" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 25 Apr 2019 11:14:17 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 25 Apr 2019 11:14:17 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.26]) by FMSMSX112.amr.corp.intel.com ([169.254.5.167]) with mapi id 14.03.0415.000; Thu, 25 Apr 2019 11:14:16 -0700 From: "Wiles, Keith" To: "Lipiec, Herakliusz" CC: dpdk-dev , "Burakov, Anatoly" , "rasland@mellanox.com" , "stable@dpdk.org" Thread-Topic: [PATCH v4 2/2] ipc: fix tap pmd memleak Thread-Index: AQHU+2UiNvq+YIQU4EGtVZyVYfOEcKZNo/EA Date: Thu, 25 Apr 2019 18:14:16 +0000 Message-ID: <397C206A-DBA4-468C-8570-2E9E0C1C948A@intel.com> References: <20190425114324.611-1-herakliusz.lipiec@intel.com> <20190425124817.28409-1-herakliusz.lipiec@intel.com> <20190425124817.28409-3-herakliusz.lipiec@intel.com> In-Reply-To: <20190425124817.28409-3-herakliusz.lipiec@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.188.160] Content-Type: text/plain; charset="UTF-8" Content-ID: <7DD5DB77B026DB4DA288E79AD5FA928E@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/2] ipc: fix tap pmd memleak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190425181416.5DCy65ad6I_u2FQFbSlaSSdTrIOJtl7TnDhDUtl_Xow@z> > On Apr 25, 2019, at 7:48 AM, Lipiec, Herakliusz wrote: >=20 > When sending synchronous IPC requests, the caller must free the response > buffer if the request was successful and reply is no longer needed. > Fix the code to correctly > use the IPC API. >=20 > Bugzilla ID: 228 > Fixes: c9aa56edec8e ("net/tap: access primary process queues from seconda= ry") > Cc: rasland@mellanox.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Herakliusz Lipiec > --- > drivers/net/tap/rte_eth_tap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.= c > index 7f74b5dc9..f8a4169c5 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -2118,7 +2118,7 @@ tap_mp_attach_queues(const char *port_name, struct = rte_eth_dev *dev) > process_private->rxq_fds[queue] =3D reply->fds[fd_iterator++]; > for (queue =3D 0; queue < reply_param->txq_count; queue++) > process_private->txq_fds[queue] =3D reply->fds[fd_iterator++]; > - > + free(reply); > return 0; > } Acked-by: Keith Wiles >=20 > --=20 > 2.17.2 >=20 Regards, Keith