From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6170DA0487 for ; Tue, 30 Jul 2019 10:13:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 57D3A1BFD5; Tue, 30 Jul 2019 10:13:57 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 45A841BFD1; Tue, 30 Jul 2019 10:13:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8604921731; Tue, 30 Jul 2019 04:13:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 30 Jul 2019 04:13:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=u2Ps1wwbXZqQipEWcTjGZE+d3eZsV9QHkd07xvRmZgg=; b=Aj3wwVNGzJXq +oqZZU/o/C2ZQx/B9kX1KmxxHKZ/3W0m0PexXY9NtQPJDZvfncEgkgJI03co1qLy Q5YqC/tiaaErs0yn/0oXg8rLVZYC2gIWAHAK4voec6QLwFUigMKzSOpvYDwaMUbA i15246uNBl/MgF8/FFOX3jGb//qhJ+E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=u2Ps1wwbXZqQipEWcTjGZE+d3eZsV9QHkd07xvRmZ gg=; b=GS1VgE+6FEpRJmHDMKRGpGslCxyNwqIAKzfBGPT+OF7DUQqPRB3EtFsrO uIOqOhVLqckVOJf3OqtN1c7K8derAQMQkn6HD+ZYCuRlOeyOa4NEDM8t0s9tusvN k5JMz3cnD1IRJAdHJzxDB3lvp7uSfUV49JN2wzMZuu6UBbaFyWhAYoYHKvMQWkmZ bDHS4yTVWU4c+BuNdBrzXwDOFYRZl2PFMsuS7UCUwNBJnd2PGvRZBullGq0DRxsZ ryVG5cnjHprFBTAyfKY7uBjY+/LDl4oVThTPDlZIQPv+KnKvM7dEcpcMW2Yqw/3L P9BBd+jICTcbJbqPVYikXhbtXvY1A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrleefucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofho nhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejje drudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghs sehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5EB5C80059; Tue, 30 Jul 2019 04:13:54 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, Bruce Richardson , stephen@networkplumber.org, stable@dpdk.org Date: Tue, 30 Jul 2019 10:13:53 +0200 Message-ID: <3981792.lQiNHBRo4J@xps> In-Reply-To: <67a795e77bc9f5ac79ab78a878ae19abbead9f50.1563984454.git.anatoly.burakov@intel.com> References: <67a795e77bc9f5ac79ab78a878ae19abbead9f50.1563984454.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] eal: fix proc type auto detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/07/2019 18:07, Anatoly Burakov: > Currently, primary process holds an exclusive lock on the config > file, thereby preventing other primaries from spinning up. However, > when the primary dies, the lock is no longer being held, even though > there might be other secondary processes still running. > > The fix is two-fold. First of all, downgrade the primary process's > exclusive lock to a shared lock once we have it. Second of all, > also take out shared locks on the config from the secondaries. We > are using fcntl() locks, which get dropped when the file handle is > closed, so also remove the closure of config file handle. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov This is not a new bug, and the fix is a bit complex, so it is deferred to 19.11 cycle. OK?