From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 75704559A for ; Tue, 5 Mar 2019 18:41:17 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0D38E2546C; Tue, 5 Mar 2019 12:41:16 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 05 Mar 2019 12:41:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=3c7rDFOMpnywpAdk/Q49kgwjad8iVh0Ha6nXEgmMfGg=; b=bPRgPnniOzdu +fnkoG6yCXNGCrHiVF4NKAPzj2kBWgtToaG/c7wF3xh7h2OBhgohAAn7fd43nJ+j x4dBZWTtELyqFOsyjbGJ7LDcrU4U1JUgd3g3buIfbjm+Gapz82DSG+0Xde2s8VDb bUDc2n7VbaWXG2BOK8LB0f5W0DtZq/s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=3c7rDFOMpnywpAdk/Q49kgwjad8iVh0Ha6nXEgmMf Gg=; b=oRpH4nzqrigXVFjhGpLqbuLraJ02efqoBHV+ZSYoYq+t2Qqx7J8IslRn9 fJ1TTi94jcELWzvkOSbknAj8WuUjwRvH+llsAkb1MmDti1aqLr5AFdtlUdvpZ3AF mLFVazPzuIeuhqRz+QSRytUA5R30stXB9loT9T5FdOz6l3VLFLjVfJGw5fHYCSUf SYYi0/syLM3JjGDXzH+mhScS/nohU79kVSM2isnipovArn6busbTQhaOCwwI9Qw/ MxgCJsPcGGxWvLmQK/1xSaaJzp8A6+Jzvgkj6jmlirLgX1ZUsL+xp++bS16YOcJE hdKgS9nSC1lbae8OFuLanT2qPuWkw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrfeefgddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 02BFFE4362; Tue, 5 Mar 2019 12:41:14 -0500 (EST) From: Thomas Monjalon To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet Cc: Raslan Darawsheh , "dev@dpdk.org" , "stephen@networkplumber.org" Date: Tue, 05 Mar 2019 18:41:12 +0100 Message-ID: <3989540.z5LmgLb1Al@xps> In-Reply-To: <20190305174002.b52wokrajmnbbqsh@bidouze.vm.6wind.com> References: <1551779507-10857-1-git-send-email-rasland@mellanox.com> <20190305164326.pu4y4srtnnt7zc7k@bidouze.vm.6wind.com> <20190305174002.b52wokrajmnbbqsh@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/failsafe: replace local device with shared data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 17:41:17 -0000 05/03/2019 18:40, Ga=EBtan Rivet: > On Tue, Mar 05, 2019 at 05:43:26PM +0100, Ga=EBtan Rivet wrote: > > I have had a little trouble reading the patches. I think the 3 first > > should be squashed into a single one, it would be more coherent. > >=20 > > I think I have seen a few points where doing so would have prevented > > some unnecessary changes for example, simplifying the series. (thinking > > about at least two PORT_ID() and a few ETH() removal that might have > > been prevented, I will try to point them all to you.) > >=20 [...] > >=20 > > Beside the squashing, this patch seems ok. >=20 > Okay after reading a little more closely, it does not seem interesting > to squash finaly, and it will be simpler for you to continue with your > current series, so forget about that. Yes, and it's easier to track changes when split as it is.