From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wj0-f178.google.com (mail-wj0-f178.google.com
 [209.85.210.178]) by dpdk.org (Postfix) with ESMTP id 363D03DC
 for <dev@dpdk.org>; Fri, 23 Dec 2016 15:28:55 +0100 (CET)
Received: by mail-wj0-f178.google.com with SMTP id sd9so68449241wjb.1
 for <dev@dpdk.org>; Fri, 23 Dec 2016 06:28:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=AoOvJAOcii5W0a6xsHWQJ5AyDZsYuwtHcW7FPZxPx9U=;
 b=tvyQYIfc1Sfiu4AZXfTES9mJee7kbvKQ6BFWYh3N1cYOcSI7N2cHVg7iA/5BHvmhYj
 U4X7H+Z68zROPnhLo+tLx89Dny+l0rqlfeFvF1k/d3JEarEL/oJ8Q0puiV9xOWGLGMwG
 V389VI4mFqCBlXr5b8+v5WKvKOVbEd9FMU53IBDt/fLMCw/UVousLWYI+HHrLux8uuOl
 yGDALtZC4hrIq/yT4pCbUn0DAOAeavouwwnbK3QeSGFDyL0CYdHFos0asxTFgltnzyD+
 jiooEMWHATHxWM4GM8VNR2vIwdiSNdT1krhckt7z2h9zsysLrCd30sV2euP+5IL+FjaB
 0CZA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=AoOvJAOcii5W0a6xsHWQJ5AyDZsYuwtHcW7FPZxPx9U=;
 b=TT8YvWwLe2fdwFX5Jxay+RStbRwgTGSBfeXvwsyfaZd2ApgcKYrsXr1G4ClW1ylUff
 gsudh38XWs4AdFnZG3Y4km9RLSpc/HUay1zeil9f1NsniO+PZazhmGvMe+grWENaKCyg
 vUA6qepSQTZcp6q6Sb95FU78I7pVjzQgwtyre+40mOjf76pz/enZQP0j9xcUNtHaHNz6
 vBQaq2OIuG/78xnMujhb0ndFU3drAHDPeJSk5TaNpS10AEo8iySO2UgRA2azlBIemg/v
 zLPvmn5JcyXIALagLCqgBDXhsdMSF12OY2KRw1trz47IwpUa10D8dQZwzYyIcFcwf1wY
 5acg==
X-Gm-Message-State: AIkVDXItgd8n4Qii9a5y84/H+ip1km8YuAEApC04mG5geceJCgY6VsUe4v80yigvoAuq6BVu
X-Received: by 10.194.39.7 with SMTP id l7mr13694621wjk.182.1482503335524;
 Fri, 23 Dec 2016 06:28:55 -0800 (PST)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id l67sm37163462wmf.20.2016.12.23.06.28.54
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 23 Dec 2016 06:28:54 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jan Blunck <jblunck@infradead.org>
Cc: dev@dpdk.org, shreyansh.jain@nxp.com, david.marchand@6wind.com,
 stephen@networkplumber.org
Date: Fri, 23 Dec 2016 15:28:54 +0100
Message-ID: <3994780.tjQ5v5j6qv@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <10047221.5fZJY41fdK@xps13>
References: <1482332986-7599-1-git-send-email-jblunck@infradead.org>
 <10047221.5fZJY41fdK@xps13>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v4 00/23] Decouple ethdev from PCI device
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Dec 2016 14:28:56 -0000

2016-12-22 16:26, Thomas Monjalon:
> I think it would easier to read if RTE_PCI_DEV macro was introduced at
> the beginning with container_of macro and used in the "localize patches".
> So the patches
> 	[PATCH v4 19/23] drivers: Replace per-PMD macros with rte_eth_dev_to_pci() helper
> and
> 	[PATCH v4 20/23] drivers: Use rte_eth_dev_to_pci() helper
> could be squashed in the "localize patches".

After a private discussion, I've understood that my proposal was stupid :)
RTE_PCI_DEV is used when the ethdev field is converted from pci_dev to device.