From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3B60A0577; Mon, 6 Apr 2020 11:03:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 22C411BED9; Mon, 6 Apr 2020 11:03:59 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 788961BED8 for ; Mon, 6 Apr 2020 11:03:57 +0200 (CEST) IronPort-SDR: CgvRq83Bi0JhM5ThUaJje8RzbVcftBoSLSPqhBiufngzj5XYIRxyJWOadYEOYFeDEz9KDqNcdt NcGAp3maFy8A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2020 02:03:56 -0700 IronPort-SDR: cWRi3s+wJHrZSgNs76ySC14IvbEc/830ZL6klMuUEMpCm19c0wsYXU9Vf7y4HvoORi+/wC/VqS BfI9RMjzBa4g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,350,1580803200"; d="scan'208";a="424293154" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.251.92.43]) ([10.251.92.43]) by orsmga005.jf.intel.com with ESMTP; 06 Apr 2020 02:03:53 -0700 To: "Sardar, Shamsher singh" Cc: "Kumar, Ravi1" , "dev@dpdk.org" References: <20200403062001.2728-1-ssardar@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <39b86649-17c8-5473-dd9f-b9ee862e2a38@intel.com> Date: Mon, 6 Apr 2020 10:03:52 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] net/axgbe: vlan support enabling in axgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/5/2020 6:00 PM, Sardar, Shamsher singh wrote: > +dev@dpdk.org > > -----Original Message----- > From: Sardar, Shamsher singh > Sent: Friday, April 3, 2020 10:12 PM > To: Ferruh Yigit > Cc: Kumar, Ravi1 > Subject: RE: [dpdk-dev] [PATCH v2] net/axgbe: vlan support enabling in axgbe > > Hi Yigit, > > 1. The Rx vlan filter set calls vlan_offload_set as shown below: > rx_vlan_filter_set() <-- app/test-pmd/config.c ... > rte_eth_dev_set_vlan_offload(uint16_t port_id, int offload_mask) <--lib/librte_ethdev/rte_ethdev.c { ... > ret = (*dev->dev_ops->vlan_offload_set) <-- this calls the respective driver's func ... > } > 2. The tx vlan check for flags and based on same it add/remove as shown below the code flow: > tx_vlan_set(portid_t port_id, uint16_t vlan_id) <-- app/test-pmd/config.c ... > rte_eth_dev_info_get(port_id, &dev_info); <-- collect flags from driver check capability DEV_TX_OFFLOAD_VLAN_INSERT ... > ports[port_id].tx_vlan_id = vlan_id; <--insert vlan to respective port id Hi Shamsher singh, VLAN filter looks good, but in the VLAN insert/strip proper 'mbuf.ol_flags' and 'mbuf.vlan_tci' should be set. In the Rx path, driver should set 'PKT_RX_VLAN' and/or 'PKT_RX_VLAN_STRIPPED' flags (please check documentation) and 'mbuf.vlan_tci', otherwise how application can know about the vlan tag and use it. Like if the 'PKT_RX_VLAN' is set you will see additional log in the testpmd packet view, "VLAN tci=0x%x", showing the received VLAN tag. Similar in Tx, driver should check 'PKT_TX_VLAN' flag to insert 'mbuf.vlan_tci' VLAN tag for the packet it has this flag. Regards, ferruh > > Note: Also attached logs to check call for filter flow and strip on/off. > In strip log by default the strip is off and hence header shown when sent vlan pkt from pktgen running in other device and in strip on the header is getting removed. > Let me know if you need more logs. > > Note: In pkt-gen log, the log captured for filtering with different vlan settings to check data flow post addition/removal of vlan in both side (pkt-gen and DUT, device under test). > > Thanks & regards > S Shamsher Singh > Mob:7259016141 > > -----Original Message----- > From: Ferruh Yigit > Sent: Friday, April 3, 2020 6:26 PM > To: Sardar, Shamsher singh ; dev@dpdk.org > Cc: Kumar, Ravi1 > Subject: Re: [dpdk-dev] [PATCH v2] net/axgbe: vlan support enabling in axgbe > > [CAUTION: External Email] > > On 4/3/2020 7:20 AM, ssardar@amd.com wrote: >> From: Sardar Shamsher Singh >> >> adding below APIs for axgbe >> - axgbe_enable_rx_vlan_stripping: to enable vlan header stipping >> - axgbe_disable_rx_vlan_stripping: to disable vlan header stipping >> - axgbe_enable_rx_vlan_filtering: to enable vlan filter mode >> - axgbe_disable_rx_vlan_filtering: to disable vlan filter mode >> - axgbe_update_vlan_hash_table: crc calculation and hash table update >> based on vlan values post filter enable >> - axgbe_vlan_filter_set: setting of active vlan out of max 4K values >> before doing hash update of same >> - axgbe_vlan_tpid_set: setting of default tpid values >> - axgbe_vlan_offload_set: a top layer function to call stip/filter etc >> based on mask values >> >> Signed-off-by: Sardar Shamsher Singh >> --- >> doc/guides/nics/features/axgbe.ini | 1 + >> drivers/net/axgbe/axgbe_common.h | 29 +++++ >> drivers/net/axgbe/axgbe_dev.c | 171 +++++++++++++++++++++++++++-- >> drivers/net/axgbe/axgbe_ethdev.c | 169 +++++++++++++++++++++++++++- >> drivers/net/axgbe/axgbe_ethdev.h | 16 +++ >> drivers/net/axgbe/axgbe_rxtx.c | 6 + >> 6 files changed, 381 insertions(+), 11 deletions(-) >> >> diff --git a/doc/guides/nics/features/axgbe.ini >> b/doc/guides/nics/features/axgbe.ini >> index 0becaa097..b7b4dd992 100644 >> --- a/doc/guides/nics/features/axgbe.ini >> +++ b/doc/guides/nics/features/axgbe.ini >> @@ -11,6 +11,7 @@ Scattered Rx = Y >> Promiscuous mode = Y >> Allmulticast mode = Y >> RSS hash = Y >> +VLAN = Y > > There is no "VLAN" feautre defined [1], but "VLAN filter" [2] & "VLAN offload" > [3], and in this patch I guess you mean both. > > But for "VLAN offload", I don't see the driver sets "PKT_RX_VLAN" or "PKT_RX_VLAN_STRIPPED" mbuf flags at all. And it doesn't use 'mbuf.vlan_tci' at all, in both Rx & Tx. Are you sure VLAN offload supported by driver? > > And for Tx, driver still uses 'PKT_TX_VLAN_PKT' which is deprecated, can you please replace it with 'PKT_TX_VLAN'? > > > > [1] > https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Flxr.dpdk.org%2Fdpdk%2Fv20.02%2Fsource%2Fdoc%2Fguides%2Fnics%2Ffeatures%2Fdefault.ini&data=02%7C01%7CShamshersingh.Sardar%40amd.com%7C1c359b4b479d4ac7090608d7d7ce5e33%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637215153650573793&sdata=Ujp55KpjRyP%2FFFa9Y8v1RJQdCtS2qGjRj7sdE3y7uAk%3D&reserved=0 > > [2] > https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Flxr.dpdk.org%2Fdpdk%2Fv20.02%2Fsource%2Fdoc%2Fguides%2Fnics%2Ffeatures.rst%23L363&data=02%7C01%7CShamshersingh.Sardar%40amd.com%7C1c359b4b479d4ac7090608d7d7ce5e33%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637215153650583782&sdata=QUZF1xle9plBK1HeGEf4FMJaXrcMAr0%2BFpvyv7BB7ic%3D&reserved=0 > > [3] > https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Flxr.dpdk.org%2Fdpdk%2Fv20.02%2Fsource%2Fdoc%2Fguides%2Fnics%2Ffeatures.rst%23L474&data=02%7C01%7CShamshersingh.Sardar%40amd.com%7C1c359b4b479d4ac7090608d7d7ce5e33%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637215153650583782&sdata=cU%2FdVldaEzozUdoOdi3jkjIhx9K95NGPuZjdxM4YFl8%3D&reserved=0 >