DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal/ipc: fix missing ignore message name
Date: Sat, 14 Apr 2018 00:16:16 +0800	[thread overview]
Message-ID: <39d5ced1-0597-e529-3325-bbe7d94ae74b@intel.com> (raw)
In-Reply-To: <648478c5ff8bcbe49306d96022eef1f89c7a935a.1523634914.git.anatoly.burakov@intel.com>



On 4/13/2018 11:55 PM, Anatoly Burakov wrote:
> We are trying to notify sender that response from current process
> should be ignored, but we didn't specify which request this response
> was for. Fix by copying request name from the original message.
>
> Fixes: 579a4ccc345c ("eal: ignore IPC messages until init is complete")
> Cc: anatoly.burakov@intel.com
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>

> ---
>   lib/librte_eal/common/eal_common_proc.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c
> index 2d3bda3..5c2acd4 100644
> --- a/lib/librte_eal/common/eal_common_proc.c
> +++ b/lib/librte_eal/common/eal_common_proc.c
> @@ -323,6 +323,8 @@ process_msg(struct mp_msg_internal *m, struct sockaddr_un *s)
>   			 */
>   			struct rte_mp_msg dummy;
>   			memset(&dummy, 0, sizeof(dummy));
> +			snprintf(dummy.name, sizeof(dummy.name),
> +					"%s", msg->name);
>   			mp_send(&dummy, s->sun_path, MP_IGN);
>   		} else {
>   			RTE_LOG(ERR, EAL, "Cannot find action: %s\n",

  reply	other threads:[~2018-04-13 16:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-13 15:55 Anatoly Burakov
2018-04-13 16:16 ` Tan, Jianfeng [this message]
2018-04-16 23:28   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39d5ced1-0597-e529-3325-bbe7d94ae74b@intel.com \
    --to=jianfeng.tan@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).