From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6DBD45AF9; Thu, 10 Oct 2024 02:35:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D4E94025E; Thu, 10 Oct 2024 02:35:50 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2050.outbound.protection.outlook.com [40.107.244.50]) by mails.dpdk.org (Postfix) with ESMTP id 0985540156 for ; Thu, 10 Oct 2024 02:35:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jBQaIMmTJYSiBC7be1d7Le6UlaFBfpCjC2ltWoj1mW5oJQcCxwzoV0QmchOjD8c9BenT+9p+aCtsP0GzxQreBdmriqtLdDXH33etopD4FAdTQYlOdQUiIyvQFSTZDlWK/vhW4rzpTgaINmGdUosbbtqemnscNveZ+XykNNooTcVp9URBaqDnsHA6dj9GESF7SXVfaDpucC1SWuVjJGj/6ycc0Z5SFFB8DT0oTtI4wm96Irl/irfdPk5VbFcFRVv0MauSprNZJtlLmMmNAEMEn0YTr3UvcfWeJk1QGoO9g4tbRbqI1sIItVNAEyR7znM/rvFI3d5W1ntjH4whmZ5Vsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9qCN6jOkjPmuqi/70sA/aCOVNkqdeyP7nqRhKp1JIhI=; b=ZiKjFn+m5XJjwQ4wpZVCr4+HBvaKFPPyaGn+oL8xLAfmKR7tj7y2i2e2QgosGudOuOKf/iNxwiSqqbVXs3XuP+qPFMHMDgkrKH1LF2xzCgCQEQ0scMk2ZG9rA7md9QyTxcvElyzMUwlZA72Oiqq1Gpid/0ScRHiFGKU6nlZRGWMe6OjDI5BNJfhlDr4ghHXYTleAOdjmNPGa5T+Jac9qQYXGcffWqU9vTfrkPFAFaWOo+UJHbtiq0AIrov1wc8XGxKEHzO79J8Z5CNll2Afs4JsKe8sD+6NFEsS9fxMqt5YScybcObfRFi+uEiVKMBeAJZelgBZIgCXdn2Mc7gKGZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9qCN6jOkjPmuqi/70sA/aCOVNkqdeyP7nqRhKp1JIhI=; b=DclliGyYfeXeiGecE6gl+/pYfSovpFCouyacsgBrDAYUAnHMk7cwBFbY8grBhxzEyFuQ3GlNfVPgdCsrlX0qC/1CH7kUmJ6fzvftGJ+Nel0x+WNizNnONaFIUheN08fy1vy9WW8/Nk4dq6ifUMufKKDgCjFzJhwAcFLY9Lp+Moo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by MN0PR12MB5716.namprd12.prod.outlook.com (2603:10b6:208:373::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.23; Thu, 10 Oct 2024 00:35:43 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8026.020; Thu, 10 Oct 2024 00:35:42 +0000 Message-ID: <39e9241d-d6d5-4e94-a3cb-506af805880d@amd.com> Date: Thu, 10 Oct 2024 01:35:34 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs To: Dodji Seketeli References: <20240905101438.3888274-1-gakhil@marvell.com> <10591cfb-d78e-4d50-9bb5-f6d1246662b3@amd.com> <87msjkdx7x.fsf@redhat.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= Cc: Akhil Goyal , dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com, hemant.agrawal@nxp.com, anoobj@marvell.com, pablo.de.lara.guarch@intel.com, fiona.trahe@intel.com, declan.doherty@intel.com, matan@nvidia.com, g.singh@nxp.com, fanzhang.oss@gmail.com, jianjay.zhou@huawei.com, asomalap@amd.com, ruifeng.wang@arm.com, konstantin.v.ananyev@yandex.ru, radu.nicolau@intel.com, ajit.khaparde@broadcom.com, rnagadheeraj@marvell.com, mdr@ashroe.eu In-Reply-To: <87msjkdx7x.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0209.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::16) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|MN0PR12MB5716:EE_ X-MS-Office365-Filtering-Correlation-Id: 821c0d32-6d91-434a-1c81-08dce8c378f9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TUdxRllUWVBsL2haQlZPeFg4STlEUVBsbzdvYTRGbEh3NDNYQ3lhcEZFU3ZL?= =?utf-8?B?Y1JySE1hN0RnOFp2bjZMTEl3S2JERGhqS0V2UG96UENvREVjZFdZa3liYWxP?= =?utf-8?B?T2tYZ0NBMzQ3T3dvdFQvTnJiZjZBSldNbVVCMTFXM3M3cVh6dUFLV1g2V0lQ?= =?utf-8?B?c0I4SG8yQVg3d3BTMUoyMVNpL3B2VmVKUnowNUFRL29SS1FjbkMwOXArU1lN?= =?utf-8?B?Z0Q0c1NiRDNGZ3kxa3hzTURURmFGTDcwb0lvN3lLSmRyUnQrYUFxZElBblls?= =?utf-8?B?QTJReDBKdWR0M2ZZTndidUR4S2RETnM5bG5hTUlEYkpRVVB1eE1sMVdDZDFs?= =?utf-8?B?SVlkK1J3RllYeUNSb2ROL1laak4rSkZEcVRLZllHWThGNlVGZE9DWTBVMXl2?= =?utf-8?B?VnJ3ZzArbkVVNjJiV1hMbThTb2JnWU5YOGlkQ1Z6Z2p3WmxYV1pPSUhEM2pZ?= =?utf-8?B?Znc3OHF5NHpqc0VBemtrbWJmZGUwYUtmTkhHS0ZPT24rbW9oVVF1SllEdS9Y?= =?utf-8?B?WjdrR1NjckJlY25tUUNJOWxzT0VBOHB0TU5OOStVT1FEZlBGUnJmYWMzZ0Jn?= =?utf-8?B?bXhhRUJpZzRGSW84WUw5eFBLbHZwekpsNHlXUEZjSHhBeVM4SE9RaHNPYmdm?= =?utf-8?B?QjZGN0lqQ0c2YTluOGlldjNhUWxDN1Jlb1hZKzdlN1l0dmhlV0VjWmhpRkFH?= =?utf-8?B?Q0ZkYTVzTkhNTVVtRkpJd0lJOXBrN0UyT2NKTWlwMlhtQW1xeWJPbCtXU0p5?= =?utf-8?B?c2lqQVphSCs1YUt3YklTSVJ3c3lKMXR1bzBRR0VLNW40Y2p1NTJsa0hpR3o5?= =?utf-8?B?RW1peXAzemt2ZXhCanpJcHl4blYvWk5UOVNjV0JqYTJhUGVSc2tsRDJMdnVF?= =?utf-8?B?dEVQZUZXZGFWTHBndE1xbEtQQ1A5ZUoveGlEU0FiMVorb05KRE9pTVRSNWQw?= =?utf-8?B?VGRQRThJVTRKNFp5UkxyRWFJV1liQ21hVEI5K1lTZ3dxc3lwaUpHZ2RacW1q?= =?utf-8?B?alpiTkczTk8rTllFN0RvVlNWRmE3elpvdXYwN1prQkg1Z21NckV4NHhsNTkz?= =?utf-8?B?ZWQwZ1NsVGo1Z2ZxUWUwOHJMbDQrdjJXaDNNRG9vaE41akU2Q1FoeVBySWEv?= =?utf-8?B?STl5MzZ4MllnSVJzTWd0Skh4c3M1NVo5am9ZRWhKMzZoK0pldnh3ZStodlVm?= =?utf-8?B?R05XaXdJV1lzRlo0YzRtbTJXUW9leDArYWNyR1lQb1FlQzUzVlJPUVhYS1hx?= =?utf-8?B?R2hKVHBmRmptZkRSdXhoUlVHbG5JTEsyYmtJTnZQSWxlZ3NySUZ1WGRXT2VL?= =?utf-8?B?dDNLTU1kRkJXSXFpNTZkYWRqMG1xTWhkaDZob2RjdU9yMk5vbFBuS1QvRVRR?= =?utf-8?B?d21qSmRKYzhneEZEM3FQQmNNTCtOYzN4aXZqeURxcXpGbEZuSTdIVzFGZFVl?= =?utf-8?B?ekk3NEQveHhTYWliRnJPRDFkdXpvbUhGQ25vWGd4YUViNFRvZHQ5dXBlS2gr?= =?utf-8?B?U2JobWJ4L0Z1bzVuWFpqSXRMUkRhcHltdk05Yzc3RzI1Nitoa3F1VG1TMHZD?= =?utf-8?B?K0w0b21XOVpMUThPMXJmdlI2STNNQmNYbEwzd01NQ0ZtaVNXL2VIUTNYNEFF?= =?utf-8?Q?3OUex17R1q1M+f/+pF9Z6fynfQpqj3GDDDLlChctUxwM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(7416014)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGdOSFFlOWIwYXByZXY0eUpuZm45MGt3S2JibjI3bjZid25SbmFZRG9QSWha?= =?utf-8?B?T3B1K1JzeHJSb1UvWGYwYjNjb25mNTVnY1RkK0FCTkFvQXcxN1dhZWVKVWVT?= =?utf-8?B?bHRrbWVEWWRoQjBid0owYVRSTWFYd3NlT2F1YlcxbG5CdU5LdHI4NndWajBp?= =?utf-8?B?ZHJBQnVnOHVhQlJYZk81L0lnZ2RnWmp2UkxwK2hWWWllZGlwNGJ5ejFxbWhE?= =?utf-8?B?K1ZUZkRPMlhRQjYreU1EN3IxU1Zkbk5kVk5Zczl6NVAyMmFSOXdkd3hvSEhT?= =?utf-8?B?OWVqK05RZ0krU2E3Ui9ZeUdjamFHTkpGWXQ3ZEJwNXZwY0N2UVpwTTBxZE93?= =?utf-8?B?TjdYTVcveVhXeEN4Y1lZOFp0ZDdHMjZJVXNUZTUwS2hqTnFxMjE1NkdyaGV5?= =?utf-8?B?Q1A2czN4VGF6VkVYN05PVEJVQXBBYTNvOHk5Z2drazYyV0hoRk9wU1RRb01I?= =?utf-8?B?cm5zVFRhT3RzM3ExRk85UERmMExWM3lFRUZpaXN4cnBvNjIzcm9Sc3lEeTJW?= =?utf-8?B?KzV3aXpBdHR4bnpZZ09HMWJxeFdvdlJDQ0tIUjVXMm9BWnROa3FJNlJLeCtD?= =?utf-8?B?TktyT3NxeW1uUnhLK0I1NG1yVDcrWWdMUU5RQnIrampVMlN4b3BVbkt5NVMw?= =?utf-8?B?akxkK1pXMnlmckVMamlWVGZ3QTYvMkZscitFL1VzRTA3VGV2c1J5Yy92ekp4?= =?utf-8?B?OC84bC9iTDRRWWw2OHN6MTlYNFpzbG0vczFzRjh0bXYzWCtzZXJDQ1c4NDlw?= =?utf-8?B?M1B1YTNNMnRzQjN3bkVENGl5ZUh4eWIyZ2FySklSS01jVUcxZnFpb1htdlpr?= =?utf-8?B?TS95M1pScU5Nc3g3dUhNRGEzVGdPMTZlQ0Q1VXhvbHpBUEdZTXBCS0tZa045?= =?utf-8?B?eG84b2RDaUxBMTdnWWc1WW1uV3JZVzJESGl5cHkxNndpcHprbE5uYWtuWVhm?= =?utf-8?B?a05XSXQvcnRLT2NhNnIyamxPYVN4ZGdMbGwzOTJGdDAwc2tOSFpIQWpmMDRj?= =?utf-8?B?TzZNSTNReTdndXZreXlDYVk2TGxZaXcwRUFsMFlRcHVaREZjaHk2L0RiRzMx?= =?utf-8?B?L01HN1J0MjRRWW1zcFJCTzU2TEoxQzFkZ041NGo1WTZUZy9Xb1cxMmlKL2ll?= =?utf-8?B?amp2QnladytzY1FOdDJpT3l3czZXVi9zdFg1bUx0VFMwOWZjNnNuWFFqSU5q?= =?utf-8?B?OGgxN2QvZVdJK0ZxeHdYVU9Qcmtkdk9FeHBRTEM3K1IxOW9nMlUyeVBnQW9k?= =?utf-8?B?cXlnbFgvT1lhL3ZrblZuYmdQd0h3ekd1Q0IvVS9PVy96Rm1MTnQyL2N1TUcy?= =?utf-8?B?T0o4OVkrdnlROWVDYVdOSTVPL0NVcUFnZXRrbGhvaDUvVURHTlpwT0NmK0Vk?= =?utf-8?B?YXN0TjJ1TFhSbmNXZmlvdmNTTEFwMytLaDBhcVh1T1NWdlpQb1NVZTdHZkd5?= =?utf-8?B?L2hEVGM1OWY5MlJ0YUQwVGpZdU9yMnpDaVRveEtGNVNtNDlOVjZHdjhnL2Jk?= =?utf-8?B?VUJoTjZicnBZQzA0VGNhRERFa3BNclJxOWNzWGFtVzhvWjhYYzV3a1poNGNC?= =?utf-8?B?OTZoZU9qbHlJT05VMGNiUS91aGRQSWR3ZzFKeHhLMXZIZWpnWXFhdjhXMVV6?= =?utf-8?B?SHJvNERsSHA1WWlxY0tmdjlIeFFXZTVJR3VoZHgxbFNqZ1F5dG5kbkhUcllp?= =?utf-8?B?TXFpSGtFa2xWYVZpOFlUV2FSSFlxL2hEZHJVcVp6L0tUWi9lb1dYOWdmVkVN?= =?utf-8?B?QmNqUVVzby9RckZKUDUxb2NaaHNjQlBKZTQ4ekVacE1DcEM1ZzhqODJ6Titw?= =?utf-8?B?VnZ4R3dWVFo1MXpNT2E3OWFpamRqTk1UbTJqT1M0VnJ4aVByMHE0bjQ2UnM0?= =?utf-8?B?aHNNT3VtSkxXYmdzdEc0UkZPVFQ4cWR0ZFdYNDBKMkRNUmxCd2poWnZNV0hU?= =?utf-8?B?KzM5NytlTVQ0S1Vtc3lQeWFOZjFwWGx6RnpoQUpSZW56Ni8rdFV3YmYzM0t4?= =?utf-8?B?Wjl5MGZmK0loT3J1RmhTWVhRSWxtOUhYdUw4RUtLNnhET3Q5VG1hM2tacmpH?= =?utf-8?B?bVBNU203NDFoaDhHQWF5Z2JTRGk0YXEzb0lUWjl4dDdYT0lpb0tYZHlCblhF?= =?utf-8?Q?iNqB01QUPDn7eQk4Oofedyh/p?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 821c0d32-6d91-434a-1c81-08dce8c378f9 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2024 00:35:42.8358 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o1fLSMCqWBKcLn6pqNP5h/k2XcjK5SwS3eWWpUXgJ665ub/IbXBomfelI7/ZqbIG X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5716 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/4/2024 10:38 AM, Dodji Seketeli wrote: > Hello, > > Ferruh Yigit writes: > >> On 9/5/2024 11:14 AM, Akhil Goyal wrote: >>> Replace *_LIST_END enumerators from asymmetric crypto >>> lib to avoid ABI breakage for every new addition in >>> enums with inline APIs. >>> >>> Signed-off-by: Akhil Goyal >>> --- >>> This patch was discussed in ML long time back. >>> https://patches.dpdk.org/project/dpdk/patch/20211008204516.3497060-1-gakhil@marvell.com/ >>> Now added inline APIs for getting the list end which need to be updated >>> for each new entry to the enum. This shall help in avoiding ABI break >>> for adding new algo. >>> >> >> Hi Akhil, >> >> *I think* this hides the problem instead of fixing it, and this may be >> partially because of the tooling (libabigail) limitation. > > So, I am not sure to understand how this would be a libabigail > limitation in general. Let me explain. > Hi Dodji, Thank you for the clarification, a few notes below. > The abidiff tool that compares two binaries and emits reports about > their ABI changes can be given a suppression specification file which > instructs the tool about what type of change to avoid emitting reports > about. > > It turns out there is a construct specifically designed to handle the > case where an enumerator is added right before the last enumerator of a > enum. Such a change causes the value of the last enumerator to > increase. > > For instance, consider this enum: > > enum foo_enum > { > FOO_FIRST, > FOO_SECOND, > FOO_END > }; > > If I add a new enumerator right before the last enumerator, I would get > this: > > enum foo_enum > { > FOO_FIRST, > FOO_SECOND, > FOO_THIRD, > FOO_END > }; > > This change cause the value of the the FOOD_END enumerator to increase. > And that increase might be problematic. At the moment, for it being > problematic or not has to be the result of a careful review. > As you said, FOOD_END value change can be sometimes problematic, but sometimes it is not. This what I referred as limitation that tool is not reporting only problematic case, but require human review. (btw, this is a very useful tool, I don't want to sound like negative about it, only want to address this recurring subject in dpdk.) > So, by default, abidiff will complain by saying that the value of > FOO_END was changed. > > But you, as a community of practice, can decide that this kind of change > to the value of the last enumerator is not a problematic change, after > careful review of your code and practice. You thus can specify that > the tool using a suppression specification which has the following > syntax: > > [suppress_type] > type_kind = enum > changed_enumerators = FOO_END, ANOTHER_ENUM_END, AND_ANOTHER_ENUM_END > > or, alternatively, you can specify the enumerators you want to suppress > the changes for as a list of regular expressions: > > [suppress_type] > type_kind = enum > changed_enumerators_regexp = .*_END$, .*_LAST$, .*_LIST_END$ > > Wouldn't that be enough to address your use case here (honest question)? > We are already using suppress feature in dpdk. But difficulty is to decide if END (MAX) enum value change warning is an actual ABI break or not. When tool gives warning, tendency is to just make warning go away, mostly by removing END (MAX) enum without really analyzing if it is a real ABI break. >> This patch prevents the libabigail warning, true, but it doesn't improve >> anything from the application's perspective. >> Before or after this patch, application knows a fixed value as END value. >> >> Not all changes in the END (MAX) enum values cause ABI break, but tool >> warns on all, that is why I think this may be tooling limitation [1]. >> (Just to stress, I am NOT talking about regular enum values change, I am >> talking about only END (MAX) value changes caused by appending new enum >> items.) >> >> As far as I can see (please Dodji, David correct me if I am wrong) ABI >> break only happens if application and library exchange enum values in >> the API (directly or within a struct). > > Sorry, I am not sure to understand what you mean by "exchange enum values". > > I would say is that if a change to an enumerator value causes a change > to the layout of a type which is part of the ABI, then that enumerator > value change might change the ABI. That ABI change might be problematic > (i.e an ABI break) or not. > I mean if enum is used in the API, either as parameter or return value of it, and either directly or as part of other struct. Think about a case an enum is used in both application and library independently, but enum is not used in any API at all, for this usage I don't see a case increasing END (MAX) enum value causing an ABI break. I was thinking if this is something tool can detect. >> >> Exchanging enum values via API cause ABI issues because: >> 1. enum size is not fixed, it uses min storage size that can hold all >> values, adding new enums may cause its size change and of course this >> breaks ABI. >> 2. Library can send enum values that application doesn't know, this may >> cause application behave undefined. >> 3. Application sending MAX value (or more) to API expects error, but >> that may be a valid value in the new library and applications gets >> unexpected result. >> >> >> Let's assume above 1. happens, with this patch warning is prevented, but >> ABI break still can occur. >> >> One option can be not exchanging enums in APIs at all, this way changes >> in the END (MAX) enum values are harmless. But I can see cryptodev does >> this a lot. >> >> When enum is exchanged in APIs, and if we want to be strict about the >> ABI, safest option can be not appending to enums at all, and keeping END >> (MAX) items can be a way to enable warnings for this. >> >> >> More relaxed option is protect against only 1. since that is the real >> ABI issue, 2 & 3 are more defensive programming, so as long as enum size >> is not changed we may ignore the END (MAX) value change warnings. >> >> >> >> [1] It would be better if tool gives END (MAX) enum value warnings only >> if it is exchanged in an API, but not sure if this can be possible to >> detect. > > I believe that if you want to know if an enumerator value is *USED* by a > type (which I believe is at the root of what you are alluding to), then > you would need a static analysis tool that works at the source level. > Or, you need a human review of the code once the binary analysis tool > told you that that value of the enumerator changed. > > Why ? please let me give you an example: > > enum foo_enum > { > FOO_FIRST, > FOO_SECOND, > FOO_END > }; > > int array[FOO_END]; > > Once this is compiled into binary, what libabigail is going to see by > analyzing the binary is that 'array' is an array of 2 integers. The > information about the size of the array being initially an enumerator > value is lost. To detect that, you need source level analysis. > I see the problem. Is this the main reason that changing FOO_END value reported as warning? If we forbid this kind of usage of the FOO_END, can we ignore this warning safely? > But then, by reviewing the code, this is a construct that you can spot > and allow or forbid, depending on your goals as a project. > > [...] > > Cheers, >