From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id B65C56A68 for ; Thu, 12 May 2016 17:41:48 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP; 12 May 2016 08:41:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,610,1455004800"; d="scan'208";a="964569485" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 12 May 2016 08:41:28 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 12 May 2016 16:39:57 +0100 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.120]) by irsmsx111.ger.corp.intel.com ([169.254.2.233]) with mapi id 14.03.0248.002; Thu, 12 May 2016 16:39:57 +0100 From: "Pattan, Reshma" To: Jerin Jacob , "dev@dpdk.org" CC: "thomas.monjalon@6wind.com" , "Richardson, Bruce" , Maciej Czekaj , Kamil Rytarowski , Zyta Szpak , Slawomir Rosek , Radoslaw Biernacki Thread-Topic: [dpdk-dev] [PATCH 04/20] thunderx/nicvf: add get_reg and get_reg_length support Thread-Index: AQHRqHPJD71hhEx680qxo+dVYtuJN5+1dvbA Date: Thu, 12 May 2016 15:39:56 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F01025933@IRSMSX109.ger.corp.intel.com> References: <1462634198-2289-1-git-send-email-jerin.jacob@caviumnetworks.com> <1462634198-2289-5-git-send-email-jerin.jacob@caviumnetworks.com> In-Reply-To: <1462634198-2289-5-git-send-email-jerin.jacob@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDVkYmUwNzYtZjc4My00YTNlLTkxNDAtMjllZWEwNTNkZWNlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjVJMDNJc28xY2o0d05kK1Uxc3FMbjNLMk9PM1BZR0p1Z2hrRElZUFd3REU9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 04/20] thunderx/nicvf: add get_reg and get_reg_length support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2016 15:41:49 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > Sent: Saturday, May 7, 2016 4:16 PM > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; Richardson, Bruce > ; Jerin Jacob > ; Maciej Czekaj > ; Kamil Rytarowski > ; Zyta Szpak > ; Slawomir Rosek ; > Radoslaw Biernacki > Subject: [dpdk-dev] [PATCH 04/20] thunderx/nicvf: add get_reg and > get_reg_length support >=20 > + > +static int > +nicvf_dev_get_regs(struct rte_eth_dev *dev, struct rte_dev_reg_info > +*regs) { > + uint64_t *data =3D regs->data; > + struct nicvf *nic =3D nicvf_pmd_priv(dev); > + > + if (data =3D=3D NULL) > + return -EINVAL; nicvf_reg_dump prints to stdout if data in NULL, so do we still want to ret= urn here? Thanks, Reshma