From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 9EA275AB4 for ; Thu, 12 May 2016 17:40:37 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 12 May 2016 08:40:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,610,1455004800"; d="scan'208";a="701126674" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by FMSMGA003.fm.intel.com with ESMTP; 12 May 2016 08:40:21 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.120]) by IRSMSX107.ger.corp.intel.com ([169.254.10.133]) with mapi id 14.03.0248.002; Thu, 12 May 2016 16:40:20 +0100 From: "Pattan, Reshma" To: Jerin Jacob , "dev@dpdk.org" CC: "thomas.monjalon@6wind.com" , "Richardson, Bruce" , Maciej Czekaj , Kamil Rytarowski , Zyta Szpak , Slawomir Rosek , Radoslaw Biernacki Thread-Topic: [dpdk-dev] [PATCH 01/20] thunderx/nicvf/base: add hardware API for ThunderX nicvf inbuilt NIC Thread-Index: AQHRqHOkd5wlevjSaE+/cM2tBKXPDJ+zt09A Date: Thu, 12 May 2016 15:40:19 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F01025942@IRSMSX109.ger.corp.intel.com> References: <1462634198-2289-1-git-send-email-jerin.jacob@caviumnetworks.com> <1462634198-2289-2-git-send-email-jerin.jacob@caviumnetworks.com> In-Reply-To: <1462634198-2289-2-git-send-email-jerin.jacob@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzFiMDU4Y2UtMWIzZC00MmI2LWJjMGUtY2VlZGFjZGZmNzc1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InM2VlBBRXdtVHFlSzd4RnRtc2RpQysyeTJzc093YVM3aGxzSmplTE9ydXc9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 01/20] thunderx/nicvf/base: add hardware API for ThunderX nicvf inbuilt NIC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2016 15:40:38 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > Sent: Saturday, May 7, 2016 4:16 PM > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; Richardson, Bruce > ; Jerin Jacob > ; Maciej Czekaj > ; Kamil Rytarowski > ; Zyta Szpak > ; Slawomir Rosek ; > Radoslaw Biernacki > Subject: [dpdk-dev] [PATCH 01/20] thunderx/nicvf/base: add hardware API f= or > ThunderX nicvf inbuilt NIC >=20 > +int > +nicvf_reg_poll_interrupts(struct nicvf *nic) > +{ > + int msg =3D 0; > + uint64_t intr; > + > + intr =3D nicvf_reg_read(nic, NIC_VF_INT); > + if (intr & NICVF_INTR_MBOX_MASK) { > + nicvf_reg_write(nic, NIC_VF_INT, NICVF_INTR_MBOX_MASK); > + msg =3D nicvf_handle_mbx_intr(nic); > + } > + if (intr & NICVF_INTR_QS_ERR_MASK) { > + nicvf_reg_write(nic, NIC_VF_INT, NICVF_INTR_QS_ERR_MASK); > + nicvf_handle_qset_err_intr(nic); > + } > + return msg; > +} > + > + [Reshma]: Multiple blank lines > +int > +nicvf_qset_rbdr_reclaim(struct nicvf *nic, uint16_t qidx) > +{ > + uint64_t status; > + int timeout =3D 10; > + struct nicvf_rbdr *rbdr =3D nic->rbdr; > + > + /* Save head and tail pointers for freeing up buffers */ > + if (rbdr) { > + rbdr->head =3D nicvf_queue_reg_read(nic, > + NIC_QSET_RBDR_0_1_HEAD, > + qidx) >> 3; > + rbdr->tail =3D nicvf_queue_reg_read(nic, > + NIC_QSET_RBDR_0_1_TAIL, > + qidx) >> 3; [Reshma]: Mix of tabs + spaces, u can use all tabs, U can correct this for= other parts of the file and other files too.=20 Thanks, Reshma