From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2A8A65AB0 for ; Thu, 19 May 2016 11:30:50 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 19 May 2016 02:30:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,334,1459839600"; d="scan'208";a="810314689" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga003.jf.intel.com with ESMTP; 19 May 2016 02:30:48 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 May 2016 10:30:46 +0100 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.38]) by irsmsx155.ger.corp.intel.com ([169.254.14.240]) with mapi id 14.03.0248.002; Thu, 19 May 2016 10:30:46 +0100 From: "Pattan, Reshma" To: Jerin Jacob , "dev@dpdk.org" CC: "thomas.monjalon@6wind.com" , "Richardson, Bruce" , Maciej Czekaj , Kamil Rytarowski , Zyta Szpak , Slawomir Rosek , Radoslaw Biernacki Thread-Topic: [dpdk-dev] [PATCH 07/20] thunderx/nicvf: add rx_queue_setup/release support Thread-Index: AQHRqHPQOQv3muSMX0eKP8HdOiD8RZ/AChiQ Date: Thu, 19 May 2016 09:30:45 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F01031078@IRSMSX109.ger.corp.intel.com> References: <1462634198-2289-1-git-send-email-jerin.jacob@caviumnetworks.com> <1462634198-2289-8-git-send-email-jerin.jacob@caviumnetworks.com> In-Reply-To: <1462634198-2289-8-git-send-email-jerin.jacob@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWIxM2YyNzgtZWM3NC00ZDM2LWJkZDItNDQ1YTA3MjhkYmE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im5WenFGUjJPSVVBVXFGYkhHQUtpcXp3TGlXMkg2akpTbllBRlB2OWpcL0JzPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 07/20] thunderx/nicvf: add rx_queue_setup/release support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 09:30:51 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > Sent: Saturday, May 7, 2016 4:16 PM > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; Richardson, Bruce > ; Jerin Jacob > ; Maciej Czekaj > ; Kamil Rytarowski > ; Zyta Szpak > ; Slawomir Rosek ; > Radoslaw Biernacki > Subject: [dpdk-dev] [PATCH 07/20] thunderx/nicvf: add rx_queue_setup/rele= ase > support >=20 > diff --git a/drivers/net/thunderx/nicvf_ethdev.c > b/drivers/net/thunderx/nicvf_ethdev.c > index 1269672..3b94168 100644 > --- a/drivers/net/thunderx/nicvf_ethdev.c > +++ b/drivers/net/thunderx/nicvf_ethdev.c >=20 > +static int > +nicvf_qset_cq_alloc(struct nicvf *nic, struct nicvf_rxq *rxq, uint16_t q= idx, > + uint32_t desc_cnt) > +{ > + const struct rte_memzone *rz; > + uint32_t ring_size =3D desc_cnt * sizeof(union cq_entry_t); > + > + rz =3D rte_eth_dma_zone_reserve(nic->eth_dev, "cq_ring", qidx, ring_siz= e, > + NICVF_CQ_BASE_ALIGN_BYTES, nic->node); > + if (rz =3D=3D NULL) { > + PMD_INIT_LOG(ERR, "Failed allocate mem for cq hw ring"); Typo "Failed to"? > +static int > +nicvf_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t qidx, > + uint16_t nb_desc, unsigned int socket_id, > + const struct rte_eth_rxconf *rx_conf, > + struct rte_mempool *mp) > +{ > + uint16_t rx_free_thresh; > + struct nicvf_rxq *rxq; > + struct nicvf *nic =3D nicvf_pmd_priv(dev); > + > + PMD_INIT_FUNC_TRACE(); > + > + /* Socked id check */ Typo "Socket"? Thanks, Reshma