From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8B7EA68D1 for ; Thu, 19 May 2016 14:20:35 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 19 May 2016 05:20:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,334,1459839600"; d="scan'208";a="958020822" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga001.jf.intel.com with ESMTP; 19 May 2016 05:20:32 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.38]) by IRSMSX154.ger.corp.intel.com ([169.254.12.18]) with mapi id 14.03.0248.002; Thu, 19 May 2016 13:19:26 +0100 From: "Pattan, Reshma" To: Jerin Jacob , "dev@dpdk.org" CC: "thomas.monjalon@6wind.com" , "Richardson, Bruce" , Maciej Czekaj , Kamil Rytarowski , Zyta Szpak , Slawomir Rosek , Radoslaw Biernacki Thread-Topic: [dpdk-dev] [PATCH 08/20] thunderx/nicvf: add tx_queue_setup/release support Thread-Index: AQHRqHPaKZOYOZI2CkqZOMilBeZEBJ/APqeQ Date: Thu, 19 May 2016 12:19:26 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F01035133@IRSMSX109.ger.corp.intel.com> References: <1462634198-2289-1-git-send-email-jerin.jacob@caviumnetworks.com> <1462634198-2289-9-git-send-email-jerin.jacob@caviumnetworks.com> In-Reply-To: <1462634198-2289-9-git-send-email-jerin.jacob@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGYxYjJmN2MtZTI3Yy00YjkwLTk4ZjEtMmExOTA2MTNlMTA5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkpCU1RhMVwvQVwvY1lhdWkzbGR6SU9JVUx5UytDRmNqdStBUXZjYWhOYmVFND0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 08/20] thunderx/nicvf: add tx_queue_setup/release support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 12:20:35 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > Sent: Saturday, May 7, 2016 4:16 PM > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; Richardson, Bruce > ; Jerin Jacob > ; Maciej Czekaj > ; Kamil Rytarowski > ; Zyta Szpak > ; Slawomir Rosek ; > Radoslaw Biernacki > Subject: [dpdk-dev] [PATCH 08/20] thunderx/nicvf: add tx_queue_setup/rele= ase > support > + txq->txq_flags & > ETH_TXQ_FLAGS_NOMULTMEMP); > + > + /* Choose optimum free threshold value for multipool case */ > + if (!txq->is_single_pool) > + txq->tx_free_thresh =3D > + (uint16_t)(tx_conf->tx_free_thresh =3D=3D > DEFAULT_TX_FREE_THRESH ? > + DEFAULT_TX_FREE_MPOOL_THRESH : > + tx_conf->tx_free_thresh); > + txq->tail =3D 0; > + txq->head =3D 0; > + txq->tail and txq->head are set to 0 in nicvf_tx_queue_reset(). So will th= at be ok to remove here? Thanks, Reshma