From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E075E5691 for ; Tue, 24 May 2016 10:09:27 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 24 May 2016 01:09:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,359,1459839600"; d="scan'208";a="983468810" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga002.jf.intel.com with ESMTP; 24 May 2016 01:09:26 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.38]) by irsmsx105.ger.corp.intel.com ([169.254.7.27]) with mapi id 14.03.0248.002; Tue, 24 May 2016 09:09:25 +0100 From: "Pattan, Reshma" To: Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 3/9] librte_ether: add new fields to rte_eth_dev_info struct Thread-Index: AQHRtTyOyV8IRK/MlUeIIND5N7/KLp/HCIwAgACyHEA= Date: Tue, 24 May 2016 08:09:24 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F01036C46@IRSMSX109.ger.corp.intel.com> References: <1463503030-10318-1-git-send-email-reshma.pattan@intel.com> <1464039512-2683-1-git-send-email-reshma.pattan@intel.com> <1464039512-2683-4-git-send-email-reshma.pattan@intel.com> <20160523152438.674d3afe@xeon-e3> In-Reply-To: <20160523152438.674d3afe@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzc0OTA3ZjktMjkwNS00MTgzLWI4OTItZWMwMjMzZmZmN2Q1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik50ZVBDXC9zT216SGhGTFoxa3EwXC9HNStENlIyOUl1UmtGbnNlZlFHdWVCbz0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 3/9] librte_ether: add new fields to rte_eth_dev_info struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2016 08:09:28 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Monday, May 23, 2016 11:25 PM > To: Pattan, Reshma > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 3/9] librte_ether: add new fields to > rte_eth_dev_info struct >=20 > On Mon, 23 May 2016 22:38:26 +0100 > Reshma Pattan wrote: >=20 > > Add new fields to rte_eth_dev_info struct New fields nb_rx_queues and > > nb_tx_queues are added to rte_eth_dev_info structure. > > Changes to API rte_eth_dev_info_get() are done to update these new > > fields to rte_eth_dev_info object. > > > > Signed-off-by: Reshma Pattan >=20 > This is an ABI break because rte_dev_info_get will clobber the the stack = of the > caller if the caller thinks dev_info is old size. Yes and the ABI breakage was announced as RFC earlier, please check the be= low mails, now this is formal patch for the same. http://dpdk.org/ml/archives/dev/2016-April/037458.html http://dpdk.org/ml/archives/dev/2016-April/037459.html http://dpdk.org/ml/archives/dev/2016-April/037460.html Thanks, Reshma