From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <reshma.pattan@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 84B2A28FD
 for <dev@dpdk.org>; Fri, 10 Jun 2016 18:22:44 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga104.fm.intel.com with ESMTP; 10 Jun 2016 09:22:44 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,450,1459839600"; d="scan'208";a="999398183"
Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25])
 by fmsmga002.fm.intel.com with ESMTP; 10 Jun 2016 09:22:44 -0700
Received: from irsmsx109.ger.corp.intel.com ([169.254.13.193]) by
 irsmsx110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0248.002;
 Fri, 10 Jun 2016 17:22:41 +0100
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: Aaron Conole <aconole@redhat.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v6 5/8] lib/librte_pdump: add new library
 for packet capturing support
Thread-Index: AQHRwmfj9S7y19T32kyqbRS3pZtne5/i4zdQ
Date: Fri, 10 Jun 2016 16:22:41 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F0104AC41@IRSMSX109.ger.corp.intel.com>
References: <1465393107-32587-1-git-send-email-reshma.pattan@intel.com>
 <1465462210-4203-1-git-send-email-reshma.pattan@intel.com>
 <1465462210-4203-6-git-send-email-reshma.pattan@intel.com>
 <f7ty46enyk9.fsf@redhat.com>
In-Reply-To: <f7ty46enyk9.fsf@redhat.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDFlODkwMzAtNmU2MS00NzQwLWI3NjYtZTlkMjhlYjVjMDNmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImVUQ21nVE5pa25sZmdLc0tZbUJKUGVnZWZ4SHdlWWo2ZldYdkduWVI1MVU9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v6 5/8] lib/librte_pdump: add new library for
 packet capturing support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jun 2016 16:22:45 -0000

Hi,

> -----Original Message-----
> From: Aaron Conole [mailto:aconole@redhat.com]
> Sent: Thursday, June 9, 2016 4:59 PM
> To: Pattan, Reshma <reshma.pattan@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 5/8] lib/librte_pdump: add new library =
for
> packet capturing support
>=20
> > +
> > +int
> > +rte_pdump_init(void)
>=20
> Would you be opposed to having an argument here which takes a path to the
> server socket?  That way the application can have some control over the s=
erver
> socket location rather than using the guesses from pdump_get_socket_path.
>=20

This is fixed in v8 patch set.=20

Thanks,
Reshma