From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <reshma.pattan@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 6D8922B92
 for <dev@dpdk.org>; Tue, 30 Aug 2016 18:34:15 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga105.fm.intel.com with ESMTP; 30 Aug 2016 09:34:14 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,257,1470726000"; d="scan'208";a="1022347180"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by orsmga001.jf.intel.com with ESMTP; 30 Aug 2016 09:34:09 -0700
Received: from irsmsx109.ger.corp.intel.com ([169.254.13.24]) by
 IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0248.002;
 Tue, 30 Aug 2016 17:34:09 +0100
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "viktorin@rehivetech.com" <viktorin@rehivetech.com>,
 "david.marchand@6wind.com" <david.marchand@6wind.com>,
 "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>,
 "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
Thread-Topic: [dpdk-dev] [PATCH v8 10/25] eal/pci: Helpers for device name
 parsing/update
Thread-Index: AQHR/6JHmU5l8zASC0ecKJAAA3yksaBhuKxA
Date: Tue, 30 Aug 2016 16:34:08 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F01075153@IRSMSX109.ger.corp.intel.com>
References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com>
 <1472219823-29486-1-git-send-email-shreyansh.jain@nxp.com>
 <1472219823-29486-11-git-send-email-shreyansh.jain@nxp.com>
In-Reply-To: <1472219823-29486-11-git-send-email-shreyansh.jain@nxp.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTc3YTQ5YzAtNTkwZi00ZjhmLWFhMzgtMDY0NjViZTJiZTUwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlIwbkpzWFJ6Vndpa3BMYWlrSUticGgwb3RYeUFGU0x1UHZkSnM0YzRYbjg9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v8 10/25] eal/pci: Helpers for device
	name	parsing/update
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Aug 2016 16:34:15 -0000

Hi,

> +/**
> + * Utility function to write a pci device name, this device name can
> +later be
> + * used to retrieve the corresponding rte_pci_addr using
> +eal_parse_pci_*
> + * BDF helpers.
> + *
> + * @param addr
> + *	The PCI Bus-Device-Function address
> + * @param output
> + *	The output buffer string
> + * @param size
> + *	The output buffer size
> + * @return
> + *  0 on success, negative on error.
> + */

This function doesn't have any return value. Need to change the @return des=
cription.

> +static inline void
> +rte_eal_pci_device_name(const struct rte_pci_addr *addr,
> +		    char *output, size_t size)
> +{
> +	RTE_VERIFY(size >=3D PCI_PRI_STR_SIZE);
> +	RTE_VERIFY(snprintf(output, size, PCI_PRI_FMT,
> +			    addr->domain, addr->bus,
> +			    addr->devid, addr->function) >=3D 0); }
> +

Thanks,
Reshma