From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id CF921FB92 for ; Thu, 30 Mar 2017 12:24:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490869498; x=1522405498; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=a4jM4W3Dj6xvOnVVi5HTztxF/rfkJ9XuUVToPQMv84c=; b=UlF07ZKbFY6c5tjL+KOxGZ+kJWeFaudn+d0nikFJwk5via5GWJYQ0wPU 84gLUCOGAlfh6wZoup6jy7hz/OgKdw==; Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Mar 2017 03:24:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,246,1486454400"; d="scan'208";a="839991153" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by FMSMGA003.fm.intel.com with ESMTP; 30 Mar 2017 03:24:55 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.151]) by IRSMSX154.ger.corp.intel.com ([169.254.12.233]) with mapi id 14.03.0319.002; Thu, 30 Mar 2017 11:22:29 +0100 From: "Pattan, Reshma" To: "Horton, Remy" , "dev@dpdk.org" CC: Thomas Monjalon , "Van Haaren, Harry" Thread-Topic: [PATCH v13 6/6] app/test-pmd: add latency statistics calculation Thread-Index: AQHSqLpWNmRPjMAZ+EynvPEewhnHH6GtKweQ Date: Thu, 30 Mar 2017 10:22:29 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F0112F1C8@irsmsx110.ger.corp.intel.com> References: <1490812128-4172-1-git-send-email-remy.horton@intel.com> <1490812128-4172-7-git-send-email-remy.horton@intel.com> In-Reply-To: <1490812128-4172-7-git-send-email-remy.horton@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGVjNWZkYmQtZTI5ZC00MDliLWFhYTUtMWJlMTNhODk4YjhhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ind3amREN05qXC9TN0pmVWc1K01wNkVjTG5pRDlyb1VZVWR2NkZkdnArczJrPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v13 6/6] app/test-pmd: add latency statistics calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 10:24:58 -0000 Hi, Few nits.=20 > -----Original Message----- > From: Horton, Remy > Sent: Wednesday, March 29, 2017 7:29 PM > To: dev@dpdk.org > Cc: Pattan, Reshma ; Thomas Monjalon > ; Van Haaren, Harry > > Subject: [PATCH v13 6/6] app/test-pmd: add latency statistics calculation >=20 >=20 > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index > 28db8cd..30b60ba 100644 > --- a/app/test-pmd/parameters.c > +++ b/app/test-pmd/parameters.c > @@ -1,7 +1,7 @@ > +#ifdef RTE_LIBRTE_LATENCY_STATS > + printf(" --latencystats=3DN: enable latency and jitter statistcs " > + "monitoring on lcore id N.\n"); #endif In the above printf , we need to mention "monitoring on forwarding lcore id= " > + { "latencystats", 1, 0, 0 }, Do we need to add ifdef RTE_LIBRTE_LATENCY_STATS flag here also ? > pmd/testpmd.h b/app/test-pmd/testpmd.h index 8cf2860..f0652ee 100644 > --- a/app/test-pmd/testpmd.h > +++ b/app/test-pmd/testpmd.h > @@ -1,7 +1,7 @@ > /*- Do we need to add ifdef RTE_LIBRTE_LATENCY_STATS flag here also ? > + > +extern uint8_t latencystats_enabled; > +extern lcoreid_t latencystats_lcore_id; Thanks, Reshma